Re: [Corelinux-public] Feedback

[Jens B. J. <jjo...@bd...>]

"Frank V. Castellucci" wrote:

> Here is another one I received direct and felt a group discussion was a
> better idea. (My comments are noted by the /* */
> ------------------------------------------------------------------------------------
>
> Frank,
>
> 4.1 Abuse of Member Data
> Classes should access their own member data via accessor and modifier
> functions, just like clients. If a class provides overloadable modifier
> functions, but does not use them internally, then descendant
> implementations
> may no work correctly.
>
> <sp> ...may not work correctly.
>
> -- Will correct
>
> What about the function call overhead incurred by accessing readily
> available data by calling accessor and mutator functions by other member
> functions?

Simple accessor/mutator functions should be written in the class declaration and
declared as inline. This way there will be no overhead.

 [snip]

> 6.11 Portability
> Standard: Native C++ data types shall not be used. Use the Types.hpp.
>
> /*
> This applies to built-in types (int, long, double, etc).
> */

Really?! Hmmm. This is a new and austere requirement for me. What sort of things are in
Types.hpp? Also, do he really have to name the headers .hpp? Why not just .h or at least
.H?

--
Jens B. Jorgensen
jjo...@bd...