Re: [Corelinux-develop] comment on corelinux macros

[Frank V. C. <fr...@co...>]

Christophe Prud'homme wrote:
> 
> Hi
> 
> I use CORELINUX_MAP and CORELINUX_VECTOR macros
> they are fine but don't you think that it is a brain pain
> to remember to swap the name and the type all the time?
> 
> I mean generally we do
> 
> typedef Type newType;
> 
> BTW DECLARE_TYPE is just fine for that
> 
> but in the _MAP and VECTOR macros the arguments are not in the right order.
> 
> Now it is
> CORELINUX_VECTOR( NewVector, double)
>  and IMHO should be
> CORELINUX_VECTOR( double, NewVector )
> just for the sake of a coherent behaviour.
> 
> Comments?
> Am I missing something?

There is no logic to the order in the macro, other than they are
consistent between themselves (name,type, ...).

so I take it you are suggesting (type, name,...) to be more like the
DECLARE_TYPE.

That is fine, except we are now faced with an interface change
throughout the library, examples, and whatever else users in the world
will have to change.

If you feel it is right (and I think both you and Hans do, and I do as
well), go for it. It won't be the last time some legacy stuff I threw in
there will come back to haunt us. :)

-- 
Frank V. Castellucci