Re: [Core-lan-org-devel] CVS Update and bugfixing

[Dennis F. <de...@co...>]

Hi Andrew,

Great work!

The getting started is just great, it provides users a step-by-step example
and rundown of the technology, i've now included in the install file so that
people are forced to read it.

A few misalignment bugs that we need to squash before releasing:

- All the [] - buttons need to be on the right in the same size. So I'll
make a css tag for it ( squarebutton ) and I'll try to get them all, please
also look for missed buttons or so.

- Menu-structure; are the links in the menus sane ? Are they in the ideal
sequence ? Re-align as you see fit.

- Opera, CSS and HTML file structural integrity.
http://www.htmlhelp.com/tools/validator/direct.html it is NOT html 4.01
compatible at the moment and I'd really love to see that status back ( saves
on rendering-problems too ).

- Code clean. Check for bugs, indent right and maybe, also and this is
especially important, try to look for security-bugs. We need to fix them
before releasing. This brengs me to another area. php 4+ has superglobals
( $_GET, $_POST ) that hold the arrays of the given values. If you install
coreapm on a clean machine you need to alter the php-config to allow
(register_globals=On ) using the direct name instead of the superglobal name
(example http://www.site.com/page.php?hello=me ) that will result in
$_GET["hello"]="me"; and if register_globals is on it will also lead to
$hello = me; You can see the obvious mistakes you can make here and
therefore I opt to use the $_GET and $_POST superglobals everywhere we can.
What does this mean:

- Check a lot of files.
- Use a lot more isset()'s
- if a variable checks out convert it to it's real variable:

if( isset( $_GET["lala"] && is_numeric( $_GET["lala"]) ) {
  $lala = $_GET["lala"];
}

The plus side is that we have a more bullitporrf version of core-lan-org AND
that we re-audit out code ( can't this just be in OpenBSD default install
;) ).

I'll start converting the code and the buttons, but can somebody else please
check the accounting code as I agree with Andrew and do not yet fully trust
it.

That's my E0.02 (approx.)

Dennis Fleurbaaij
de...@co...



----- Original Message -----
From: "Andrew Simpson" <and...@pa...>
To: <cor...@li...>
Sent: Sunday, August 25, 2002 8:12 AM
Subject: [Core-lan-org-devel] CVS Update and bugfixing


> Hi all,
>
> Just entered a large amount of bugfixes in the CVS.  Please test and
> check whether I've broken something.  It all works for me (tm).
>
> Areas of concern:
>
> - found lots of NULL's, 0's and "" mixed up in tasks.  Variables input
> into database are NULL, and variables output are "".  Many cases were
> wrong.  I've found it confusing to debug - please check.
>
> - fixed deleting usergroups.  This appears to have been broken since
> version 1.0 - unless I've missed something?
>
> After some more testing, I think we will be ready for Version 2.0. The
> rendering on Opera is not fixed yet, otherwise I don't know of any major
> bugs.
>
> IMHO the time estimate code is not very mature / fully functioned yet,
> but it works.
>
> Andrew
>
>
> -------------------------------------------------------
> This sf.net email is sponsored by: OSDN - Tired of that same old
> cell phone?  Get a new here for FREE!
> https://www.inphonic.com/r.asp?r=sourceforge1&refcode1=vs3390
> _______________________________________________
> Core-lan-org-devel mailing list
> Cor...@li...
> https://lists.sourceforge.net/lists/listinfo/core-lan-org-devel
>