Re: [Core-lan-org-devel] jumbo edits, cvsdiff -u

[Marshall R. <mr...@db...>]

> Hi,
> 
> Looks impressive Marshall. Is this a diff against current CVS ? See my
> comments on it below.

yes, it's a diff against the current CVS.


> ----- Original Message -----
> From: "Marshall Rose" <mr...@db...>
> To: <cor...@li...>
> Sent: Friday, July 05, 2002 1:20 AM
> Subject: [Core-lan-org-devel] jumbo edits, cvsdiff -u
> 
> 
> > 1. in includes/security.php, there was a malformed SQL query (missing a
> >    closing-paren). yikes! i also took the liberty of changing
> >    "as" to "AS" to be consistent with the upcase of the other SQL
> >    keywords in the query.
> 
> Um <shame>. But actually PHP would fix the problem unnoted by using
> auto-delimiters.

i agree that the "AS" changes are gratuituous. the malformed SQL query caused the script to bomb though...

> >
> > 2. in includes/time.php, a previous edit tried to use alpha months
> >    instead of numeric months. there are two problems with this, first,
> >    postgres uses numeric months (at least as of 7.1.2); and, second, the
> >    code that sets the "SELECTED" bit stopped working.
> 
> True this is done to let it work in postgres 7.2.1.

well, there ought to be a way of having it work in both. what that is, i don't know. the changes were pretty broken for 7.1.2


> 
> > functional changes
> > 2. timeout is now configurable, viz., $TIMEOUT_SECS and
> >    $TIMEOUT_TEXT. the default remains unchanged (one of my users got bit
> >    by the 1 hour thing, so i'm running it at 8 hours...)
> 
> Okay. Note to your user that he has to work harder though ;)

i agree.


> > 4. the default checked behavior for task edits is configurable, viz.,
> >    $CHECKED_DEFAULT. choices are either "" (the default) or "CHECKED".
> 
> Why do we need that ?

you may not need it. in my case, i want CHECKED to be the default so email gets sent unless the user specific unchecks it...


> > 7. when creating/editing a usergroup, you can now set the membership
> >    (indicate which users are in the group).
> 
> Wasn't this allready in CVS ?

the only thing in CVS was the "show" part of this, when you viewed the usergroups, you saw what the membership was. the "create" and "edit" parts weren't in cvs...

 
> > editorial changes
> >
> > 1. there were a couple of edit forms where the submit button was
> >    labelled as "Edit ..." instead of "Submit". since this appears on a
> >    page where you're already editing, some of my users found it
> >    confusing.  so, i changed the label to "Submit".
> >
> > 2. while looking through the code for any other mismatched parens in SQL
> >    queries, i took the liberty of making the spacing of parens
> >    consistent in a couple of queries.
> >
> > 3. when looking at a user, if there aren't any files owned by the user,
> >    it would say " Bytes", now it says "0 Bytes".
> 
> True.
> 
> Well marshall it seems that you've put a LOAD of effort in this. Thak you
> very much for the code and we'll try to implement it asap.

you bet. hey, is there a mailing list for cvs updates? i didn't see one on the sourceforge site.


> As core-lan-org is becoming mature and stable now I'm looking forward to
> coreapm.sourceforge.net if anyone who reads this is interested in creating a
> task-manager there you can check it out of cvs and also grab module_pm.
> Tha'll give you a gantt-chart-o-matic and the management tools needed to
> support it.
> 
> I think that will be the way to go. Please tell me what you guys think of
> it.

that would be very cool.

/mtr