core-lan-org-devel — Developers and feature-requests overhere please

Re: [Core-lan-org-devel] jumbo edits, cvsdiff -u

[Dennis F. <de...@co...>]

Hi Dave,


Um I think I must better describe the problem :/ Or maybe I didn't
understand your code. The REAL problem is that if you the data in a database
and you want to upgrade tot the newer version you need to do a couple of
things:

- get the data to a file
- erase the database
- insert the new database scheme
- change the 0's into NULLs in the file
- put the data back.

(real-time in a database just doesn't sound like a good thing to me)

So as this hack seems okay it bypasses the real problem. That is to actually
change all the data. Am I wrong here ?

Dennis




----- Original Message -----
From: "Dave Cridland" <da...@cr...>
To: "Dennis Fleurbaaij" <de...@co...>
Cc: <cor...@li...>
Sent: Sunday, July 07, 2002 1:08 PM
Subject: Re: [Core-lan-org-devel] jumbo edits, cvsdiff -u


> On Sat, 2002-07-06 at 17:35, Dennis Fleurbaaij wrote:
> > The point is that the data you now have is full of 0's and the database
> > won't allow you to insert them as they refer to non-existant tasks (0 is
not
> > a possible task, SQL starts couting at 1). So as I've said before we
need a
> > script to take all the 0's and convert them into NULL's.
>
> I hasten to add this is not a good example of my coding, but anyway.
>
> Attached is a very quick, highly untested perl hack which ought to read
> in create_database.sql, spot the REFERENCES (ACtually the trigger
> statements), parse them according to my weak knowledge of what these
> are, and then - hopefully - generate reasonable SQL statements which
> should fix up the database, replacing non-existent values with NULL.
>
> As I say, I haven't tested it *AT ALL*. If someone wants to send me a
> suitable candidate test database to run it on, I'll happily do so.
>
> I apologise profusely for the appalling hack that this is, but I figured
> it was possibly quicker than identifying each REFERENCES manually.
>
> Dave.
>

Re: [Core-lan-org-devel] jumbo edits, cvsdiff -u

[Dave C. <da...@cr...>]

On Sat, 2002-07-06 at 17:35, Dennis Fleurbaaij wrote:
> The point is that the data you now have is full of 0's and the database
> won't allow you to insert them as they refer to non-existant tasks (0 is not
> a possible task, SQL starts couting at 1). So as I've said before we need a
> script to take all the 0's and convert them into NULL's.

I hasten to add this is not a good example of my coding, but anyway.

Attached is a very quick, highly untested perl hack which ought to read
in create_database.sql, spot the REFERENCES (ACtually the trigger
statements), parse them according to my weak knowledge of what these
are, and then - hopefully - generate reasonable SQL statements which
should fix up the database, replacing non-existent values with NULL.

As I say, I haven't tested it *AT ALL*. If someone wants to send me a
suitable candidate test database to run it on, I'll happily do so.

I apologise profusely for the appalling hack that this is, but I figured
it was possibly quicker than identifying each REFERENCES manually.

Dave.

Re: [Core-lan-org-devel] summary page

[Dennis F. <de...@co...>]

Hi Marshall,

I've checked the code and it looks pretty neat. The summary page is exactly
what was missing. 2 things on code-style though:

when using if-statements please use:
if( ) {
}
else {
}
instead of
if
else

And a second tip: When coding in php set php's errorlevel to E_ALL instead
of not showing notes. This way you catch more bugs and unintended
'features'.

Thanks,
Dennis

----- Original Message -----
From: "Marshall Rose" <mr...@db...>
To: <cor...@li...>
Sent: Sunday, July 07, 2002 12:48 AM
Subject: [Core-lan-org-devel] summary page


> hi. attached is a diff and a new file. i haven't commited these to CVS for
two reasons:
>
> first, i'm not sure if the new functionalty is consistent with the
core-lan-org Way.
>
> second, it was written using the old database scheme ("0" instead of
"NULL")
>
> here's how to install it:
>
> 1. put the file, task_summary_list.php in the tasks/ directory.
> 2. apply the patch (which adds a link to the "Main menu" box).
>
> what this update does is add a "summary page" that can be sorted on
deadline, status, owner, user/task-group, and task name. the default display
is a hierarchical project/task tree. if you click on one of the columns
(e.g., "Deadline") then you get a flat list sorted by that column.
>
> folks here find it pretty useful, because they can see everything that's
due in the next couple of days "in a glance".
>
> enjoy!
>
> /mtr
>
> ps: i didn't want to tie-up too much screen real-esate by showing both
usergroup and taskgroup columns. so, there's one column called "group" that
you click on to toggle between showing/sorting-by the usergroup or
taskgroup.
>

Re: [Core-lan-org-devel] task groups and user groups, part deux

[Marshall R. <mr...@db...>]

> So it's more of an mix-and-match stratgy then to use the taskgroups for
> further grouping above usegroups. It's just a handy way of giving people
> access. Taskgroups are more a cosmetial function (a nice way to sort tasks)
> then a real strategy.

hi. that makes perfect sense. thanks!

/mtr

[Core-lan-org-devel] summary page

[Marshall R. <mr...@db...>]

hi. attached is a diff and a new file. i haven't commited these to CVS for two reasons:

first, i'm not sure if the new functionalty is consistent with the core-lan-org Way.

second, it was written using the old database scheme ("0" instead of "NULL")

here's how to install it:

1. put the file, task_summary_list.php in the tasks/ directory.
2. apply the patch (which adds a link to the "Main menu" box).

what this update does is add a "summary page" that can be sorted on deadline, status, owner, user/task-group, and task name. the default display is a hierarchical project/task tree. if you click on one of the columns (e.g., "Deadline") then you get a flat list sorted by that column.

folks here find it pretty useful, because they can see everything that's due in the next couple of days "in a glance".

enjoy!

/mtr

ps: i didn't want to tie-up too much screen real-esate by showing both usergroup and taskgroup columns. so, there's one column called "group" that you click on to toggle between showing/sorting-by the usergroup or taskgroup.

[Core-lan-org-devel] minor commit

[Marshall R. <mr...@db...>]

hi. i just commited a very small number of patches to clean-up a few things:

1. do not allow a task to be re-parented to itself!
2. when sending out an email to the owner of a changed task, make sure that the owner 
3. i figured out some better html for the site-specific image
4. minor english language usage: "too late" should be "overdue" and "publicly" should be "publically"

the last change is somewhat gratuitous, but someone working here has a degree in english...

/mtr

Re: [Core-lan-org-devel] jumbo edits, cvsdiff -u

[Marshall R. <mr...@db...>]

> Hi Marshall,
> 
> You need to upgrade. Coreapm used the value 0 to indictate a filed was not
> set. This was handy at the time I wrote it. Nowadays I use NULL as it offers
> the posilibility do more complex things with the database.
> 
> The point is that the data you now have is full of 0's and the database
> won't allow you to insert them as they refer to non-existant tasks (0 is not
> a possible task, SQL starts couting at 1). So as I've said before we need a
> script to take all the 0's and convert them into NULL's.

right. good point... pgsql isn't my strong-point, but i'll take a look at writing such a script... if someone beats me to it, great!

/mtr

[Core-lan-org-devel] Bo Lorentsons hacks

[Dennis F. <de...@co...>]

Well,

It's all in there after 10 straight hours of coding today :)

Beware that the release is FAR from stable and ever further from mature. =
So please take the code to the limits and question everything it does. =
As far as I could see there is just one fatal bug that I know of right =
now and that is that recursive deletes won't work. They need to be =
deleted in reversed order for the database to agree.

And there probably are lots of complex problems as we now have deadline =
and estimated hours. These 2 can work in parrallel but I can image =
situations where the projects owners can go mad because of one of the 2 =
not cooperating.

Hope you enjoy another couple of k of php lines :)

Greetings and good night,
Dennis Fleurbaaij



Met vriendelijke groet,
=20
Dennis Fleurbaaij
Voorzitter stichting CORE
----------------------------
Tel : +31 (0) 6 54 21 53 65
Mail: de...@co...
www : http://www.core-lan.nl
Adres: Marco-pololaan 22
4562 AC Hulst

[Core-lan-org-devel] Mega-patch

[Dennis F. <de...@co...>]

Hello,

Bo Lorentson send me > 1200 lines of code. That I cannot insert into =
current CVS so i'm hand-inserting all code and I'll give a yell once =
it's in there. This provides:
- todo lists
- task esimates
- lots and lots and lots of fixes and other code.
- RSI ( to me that is ;) ).

In anycase this is really a Good Thing (tm). Except for the session =
system that i'm pulling out. I don't like php's session system and =
that's it.=20

Thanks,
Dennis

Re: [Core-lan-org-devel] jumbo edits, cvsdiff -u

[Dennis F. <de...@co...>]

Hi Marshall,

You need to upgrade. Coreapm used the value 0 to indictate a filed was not
set. This was handy at the time I wrote it. Nowadays I use NULL as it offers
the posilibility do more complex things with the database.

The point is that the data you now have is full of 0's and the database
won't allow you to insert them as they refer to non-existant tasks (0 is not
a possible task, SQL starts couting at 1). So as I've said before we need a
script to take all the 0's and convert them into NULL's.

Greetings,
Dennis

----- Original Message -----
From: "Marshall Rose" <mr...@db...>
To: "Dennis Fleurbaaij" <de...@co...>
Sent: Saturday, July 06, 2002 6:27 PM
Subject: Re: [Core-lan-org-devel] jumbo edits, cvsdiff -u


> > Hi Marshall,
> >
> > Well just 6 chuncks that didn't work out is pretty good for diffing and
> > patching different CVS versions :-)
> >
> > The code is complete again and I'm testing it.
>
> solid.
>
> so, what the story with the "new" database you mentioned on the dev list?
is it possible to run the current cvs stuff with the database i was using
yesterday or do i need to upgrade it?
>
> thanks,
>
> /mtr
>

Re: [Core-lan-org-devel] task groups and user groups, part deux

[Dennis F. <de...@co...>]

I'm happy to announce the Marshall's code in the cvs. There where a few
small issues that popped up (missing quotes, different versions) but it's
in.

The database design has also undergone massive changes as we now use
- keys (ahum :P )
- indexes
- references

This improves speed and security a great deal and was something that had to
be done. There is however a problem as the old database uses 0 for nothing
and the new uses NULL. We need to write a script to hande this and to help
users migrate databases.

In anycase the current cvs version is bound to be broken, but please test it
and give me your ideas/code/tips/hints on how to fix the things that will
come up.

If anyone feels up to it please write a conversion script that will go from
the old design to the new design for the database so that we can import real
live databases and use them instead.

Thanks,
Dennis

Re: [Core-lan-org-devel] task groups and user groups, part deux

[Dennis F. <de...@co...>]

Hi Marshall,

I've designed it for use on our lan-party organisation as you can read in
the install files. We have 3 specific groups. (Well 4 if you count the
site-admins in)

- organisation
- webdev
- crew

Some tasks must be shared between org and webdev, some only webdev and crew
gets to see the least amount of tasks. So we use groups to hide tasks for
just a single group. Example:
- financials should only be accessible by the organisation
- web and database passwords should only be accessible by the webdev

So it's more of an mix-and-match stratgy then to use the taskgroups for
further grouping above usegroups. It's just a handy way of giving people
access. Taskgroups are more a cosmetial function (a nice way to sort tasks)
then a real strategy.

Greets,
Dennis





----- Original Message -----
From: "Marshall Rose" <mr...@db...>
To: <cor...@li...>
Sent: Friday, July 05, 2002 7:43 PM
Subject: [Core-lan-org-devel] task groups and user groups, part deux


> so, i think i understand how the code treats task groups and user groups,
so let me ask another question:
>
> what strategy do administrators use for allocating the different kind of
groups?
>
> for example, say i have a company with four groups: administration,
development, operations, and sales. do folks create a user group for each
one of these, and then create multiple task groups for each category (e.g.,
development -> db, www, sec, and so on).
>
> i realize that the administrator can utilize whatever works best for them,
so i'm asking what strategies are people using.
>
> thanks,
>
> /mtr
>
>
> -------------------------------------------------------
> This sf.net email is sponsored by:ThinkGeek
> Bringing you mounds of caffeinated joy.
> http://thinkgeek.com/sf
> _______________________________________________
> Core-lan-org-devel mailing list
> Cor...@li...
> https://lists.sourceforge.net/lists/listinfo/core-lan-org-devel
>

[Core-lan-org-devel] task groups and user groups, part deux

[Marshall R. <mr...@db...>]

so, i think i understand how the code treats task groups and user groups, so let me ask another question:

what strategy do administrators use for allocating the different kind of groups?

for example, say i have a company with four groups: administration, development, operations, and sales. do folks create a user group for each one of these, and then create multiple task groups for each category (e.g., development -> db, www, sec, and so on).

i realize that the administrator can utilize whatever works best for them, so i'm asking what strategies are people using.

thanks,

/mtr

Re: [Core-lan-org-devel] jumbo edits, cvsdiff -u

[Marshall R. <mr...@db...>]

> Ehrm... weirdness. So the current CVS was broken ?!?

yes, i'm afraid so. i grabbed the cvs from sf.net, put it in a directory under htdocs/, edited config.php, and then kaboom!

easy to fix though, given all the great diagnostics in the package...


> >well, there ought to be a way of having it work in both. what that is, i 
> don't know. the changes were pretty broken for 7.1.2
> 
> Time to implement some generic function there. I'll look into it this weekend.

solid.


> >> > 4. the default checked behavior for task edits is configurable, viz.,
> >> >    $CHECKED_DEFAULT. choices are either "" (the default) or "CHECKED".
> >>
> >> Why do we need that ?
> >
> >you may not need it. in my case, i want CHECKED to be the default so email 
> gets sent unless the user specific unchecks it...
> 
> 
> Nah I meant in the config file. But it's okay, leave it there.

for changes to the UI, my philosophy is to keep the default behavior and enable things that i like via a config option. that way, you (and everyone else) doesn't see any change unless they want tooo...

> >you bet. hey, is there a mailing list for cvs updates? i didn't see one on 
> the sourceforge site.
> 
> No there isn't CVS is VERY LOW traffic here :-). If you want you can have 
> access as you seem to have written a very substantial amount of code for this 
> project. Just give me an email and your sf username.

sf username = mrose
email = mr...@us...  (or mro...@db...)

> >> As core-lan-org is becoming mature and stable now I'm looking forward to
> >> coreapm.sourceforge.net if anyone who reads this is interested in creating 
> a
> >> task-manager there you can check it out of cvs and also grab module_pm.
> >> Tha'll give you a gantt-chart-o-matic and the management tools needed to
> >> support it.
> >>
> >> I think that will be the way to go. Please tell me what you guys think of
> >> it.
> >
> >that would be very cool.
> 
> Can you d/l it, give it a run and tell me what you think of it. It's still 
> alpha code so you'll get a run for your money trying to get it to work.

i've got a copy and will look at it this weekend!

thanks!

/mtr

RE: [Core-lan-org-devel] jumbo edits, cvsdiff -u

[dfleurbaaij <dfl...@ze...>]

Hi,

>===== Original Message From Marshall Rose <mr...@db...> =====
>> Hi,
>>
>> Looks impressive Marshall. Is this a diff against current CVS ? See my
>> comments on it below.
>
>yes, it's a diff against the current CVS.

Whee, that'll save a lot of work.

>> Um <shame>. But actually PHP would fix the problem unnoted by using
>> auto-delimiters.
>
>i agree that the "AS" changes are gratuituous. the malformed SQL query caused 
the script to bomb though...

Ehrm... weirdness. So the current CVS was broken ?!?


>well, there ought to be a way of having it work in both. what that is, i 
don't know. the changes were pretty broken for 7.1.2

Time to implement some generic function there. I'll look into it this weekend.


>> > 4. the default checked behavior for task edits is configurable, viz.,
>> >    $CHECKED_DEFAULT. choices are either "" (the default) or "CHECKED".
>>
>> Why do we need that ?
>
>you may not need it. in my case, i want CHECKED to be the default so email 
gets sent unless the user specific unchecks it...


Nah I meant in the config file. But it's okay, leave it there.


>> > 7. when creating/editing a usergroup, you can now set the membership
>> >    (indicate which users are in the group).
>>
>> Wasn't this allready in CVS ?
>
>the only thing in CVS was the "show" part of this, when you viewed the 
usergroups, you saw what the membership was. the "create" and "edit" parts 
weren't in cvs...

Ah k.

>> Well marshall it seems that you've put a LOAD of effort in this. Thak you
>> very much for the code and we'll try to implement it asap.
>
>you bet. hey, is there a mailing list for cvs updates? i didn't see one on 
the sourceforge site.

No there isn't CVS is VERY LOW traffic here :-). If you want you can have 
access as you seem to have written a very substantial amount of code for this 
project. Just give me an email and your sf username.

>> As core-lan-org is becoming mature and stable now I'm looking forward to
>> coreapm.sourceforge.net if anyone who reads this is interested in creating 
a
>> task-manager there you can check it out of cvs and also grab module_pm.
>> Tha'll give you a gantt-chart-o-matic and the management tools needed to
>> support it.
>>
>> I think that will be the way to go. Please tell me what you guys think of
>> it.
>
>that would be very cool.

Can you d/l it, give it a run and tell me what you think of it. It's still 
alpha code so you'll get a run for your money trying to get it to work.

Greets,
Dennis

Re: [Core-lan-org-devel] jumbo edits, cvsdiff -u

[Marshall R. <mr...@db...>]

> Hi,
> 
> Looks impressive Marshall. Is this a diff against current CVS ? See my
> comments on it below.

yes, it's a diff against the current CVS.


> ----- Original Message -----
> From: "Marshall Rose" <mr...@db...>
> To: <cor...@li...>
> Sent: Friday, July 05, 2002 1:20 AM
> Subject: [Core-lan-org-devel] jumbo edits, cvsdiff -u
> 
> 
> > 1. in includes/security.php, there was a malformed SQL query (missing a
> >    closing-paren). yikes! i also took the liberty of changing
> >    "as" to "AS" to be consistent with the upcase of the other SQL
> >    keywords in the query.
> 
> Um <shame>. But actually PHP would fix the problem unnoted by using
> auto-delimiters.

i agree that the "AS" changes are gratuituous. the malformed SQL query caused the script to bomb though...

> >
> > 2. in includes/time.php, a previous edit tried to use alpha months
> >    instead of numeric months. there are two problems with this, first,
> >    postgres uses numeric months (at least as of 7.1.2); and, second, the
> >    code that sets the "SELECTED" bit stopped working.
> 
> True this is done to let it work in postgres 7.2.1.

well, there ought to be a way of having it work in both. what that is, i don't know. the changes were pretty broken for 7.1.2


> 
> > functional changes
> > 2. timeout is now configurable, viz., $TIMEOUT_SECS and
> >    $TIMEOUT_TEXT. the default remains unchanged (one of my users got bit
> >    by the 1 hour thing, so i'm running it at 8 hours...)
> 
> Okay. Note to your user that he has to work harder though ;)

i agree.


> > 4. the default checked behavior for task edits is configurable, viz.,
> >    $CHECKED_DEFAULT. choices are either "" (the default) or "CHECKED".
> 
> Why do we need that ?

you may not need it. in my case, i want CHECKED to be the default so email gets sent unless the user specific unchecks it...


> > 7. when creating/editing a usergroup, you can now set the membership
> >    (indicate which users are in the group).
> 
> Wasn't this allready in CVS ?

the only thing in CVS was the "show" part of this, when you viewed the usergroups, you saw what the membership was. the "create" and "edit" parts weren't in cvs...

 
> > editorial changes
> >
> > 1. there were a couple of edit forms where the submit button was
> >    labelled as "Edit ..." instead of "Submit". since this appears on a
> >    page where you're already editing, some of my users found it
> >    confusing.  so, i changed the label to "Submit".
> >
> > 2. while looking through the code for any other mismatched parens in SQL
> >    queries, i took the liberty of making the spacing of parens
> >    consistent in a couple of queries.
> >
> > 3. when looking at a user, if there aren't any files owned by the user,
> >    it would say " Bytes", now it says "0 Bytes".
> 
> True.
> 
> Well marshall it seems that you've put a LOAD of effort in this. Thak you
> very much for the code and we'll try to implement it asap.

you bet. hey, is there a mailing list for cvs updates? i didn't see one on the sourceforge site.


> As core-lan-org is becoming mature and stable now I'm looking forward to
> coreapm.sourceforge.net if anyone who reads this is interested in creating a
> task-manager there you can check it out of cvs and also grab module_pm.
> Tha'll give you a gantt-chart-o-matic and the management tools needed to
> support it.
> 
> I think that will be the way to go. Please tell me what you guys think of
> it.

that would be very cool.

/mtr

Re: [Core-lan-org-devel] jumbo edits, cvsdiff -u

[Marshall R. <mr...@db...>]

> Hi,
> 
> It's so simple you'll hate yourself for it :-D

yes, i didn't realize i was inside a function there...

/mtr

Re: [Core-lan-org-devel] jumbo edits, cvsdiff -u

[Dennis F. <de...@co...>]

Hi,

Looks impressive Marshall. Is this a diff against current CVS ? See my
comments on it below.

----- Original Message -----
From: "Marshall Rose" <mr...@db...>
To: <cor...@li...>
Sent: Friday, July 05, 2002 1:20 AM
Subject: [Core-lan-org-devel] jumbo edits, cvsdiff -u


> 1. in includes/security.php, there was a malformed SQL query (missing a
>    closing-paren). yikes! i also took the liberty of changing
>    "as" to "AS" to be consistent with the upcase of the other SQL
>    keywords in the query.

Um <shame>. But actually PHP would fix the problem unnoted by using
auto-delimiters.

>
> 2. in includes/time.php, a previous edit tried to use alpha months
>    instead of numeric months. there are two problems with this, first,
>    postgres uses numeric months (at least as of 7.1.2); and, second, the
>    code that sets the "SELECTED" bit stopped working.

True this is done to let it work in postgres 7.2.1.

> functional changes
>
> 1. if checked, updating a task sends email to the users in the "user
>    group" associated with the task. if there are no users in that group
>    (e.g., $usergroup=0), then it goes to $EMAIL_MAILINGLIST; however, if
>    that variable is empty, then it goes to the email address associated
>    with each user in the system.

Sounds good.

> 2. timeout is now configurable, viz., $TIMEOUT_SECS and
>    $TIMEOUT_TEXT. the default remains unchanged (one of my users got bit
>    by the 1 hour thing, so i'm running it at 8 hours...)

Okay. Note to your user that he has to work harder though ;)

> 3. the ordering of projects on the homepage is configurable,
>    viz., $PROJECT_ORDERED_BY. choices are either by "taskname" or
>    "deadline" or a permutation, e.g., "deadline,taskname".

k.

> 4. the default checked behavior for task edits is configurable, viz.,
>    $CHECKED_DEFAULT. choices are either "" (the default) or "CHECKED".

Why do we need that ?

> 5. when editing a task, you can now re-parent it.

Good!

> 6. when looking at a task that you own, there's a new link "I finished
>    it!" which does what you'd think.

Hehe, nice touch to keep in the loose text style.

> 7. when creating/editing a usergroup, you can now set the membership
>    (indicate which users are in the group).

Wasn't this allready in CVS ?

> editorial changes
>
> 1. there were a couple of edit forms where the submit button was
>    labelled as "Edit ..." instead of "Submit". since this appears on a
>    page where you're already editing, some of my users found it
>    confusing.  so, i changed the label to "Submit".
>
> 2. while looking through the code for any other mismatched parens in SQL
>    queries, i took the liberty of making the spacing of parens
>    consistent in a couple of queries.
>
> 3. when looking at a user, if there aren't any files owned by the user,
>    it would say " Bytes", now it says "0 Bytes".

True.

Well marshall it seems that you've put a LOAD of effort in this. Thak you
very much for the code and we'll try to implement it asap.

As core-lan-org is becoming mature and stable now I'm looking forward to
coreapm.sourceforge.net if anyone who reads this is interested in creating a
task-manager there you can check it out of cvs and also grab module_pm.
Tha'll give you a gantt-chart-o-matic and the management tools needed to
support it.

I think that will be the way to go. Please tell me what you guys think of
it.

Thank you,
Dennis

Re: [Core-lan-org-devel] jumbo edits, cvsdiff -u

[Dennis F. <de...@co...>]

Hi,

It's so simple you'll hate yourself for it :-D

1) scoop. If you do:

$bla = "hello";
function a() {
  echo $bla;
}

will be empty. You will need to do:

$bla = "hello";
function a() {
  global $bla;
  echo $bla;
}

And it'll work.

2) Or you can do

define( "bla", "hello" );
function a() {
  //note the missing $
  echo bla;
}

Good luck.

Dennis Fleurbaaij


----- Original Message ----- 
From: "Marshall Rose" <mr...@db...>
To: <cor...@li...>
Sent: Friday, July 05, 2002 1:25 AM
Subject: Re: [Core-lan-org-devel] jumbo edits, cvsdiff -u


> one other thing, but it's a bit of a mystery.
>     
> i added a configuration option, $SITE_IMGSRC, that, if non-empty, is
> supposed to contain a URI pointing to an image to put up at the top of
> the page. if you look at what i added to includes/screen.php, you'll see
> how it gets used, i.e.,
>    
> +  if( $SITE_IMGSRC != "" ) {
> +    echo "<TR valign=\"top\"><TD";
> +    if( $no_menu == 0 )
> +      echo " width=\"175\"></TD><TD";
> +    else
> +      echo " colspan=\"2\"";
> +    echo " align=\"center\"><IMG src=\"";  
> +    echo $SITE_IMGSRC;
> +    echo "\"></TD></TR>\n";
> +  }
> +
> 
> now, here's the mystery, no matter what value i put into config.php for
> $SITE_IMGSRC, the value in screen.php is always "".
>     
> after staring at the code for an hour, i'm convinced that config.php is
> always include'd before screen.php, so this just makes no sense.
>     
> any ideas?
>     
> thanks,
> 
> /mtr
>    
> 
> 
> -------------------------------------------------------
> This sf.net email is sponsored by:ThinkGeek
> Caffeinated soap. No kidding.
> http://thinkgeek.com/sf
> _______________________________________________
> Core-lan-org-devel mailing list
> Cor...@li...
> https://lists.sourceforge.net/lists/listinfo/core-lan-org-devel
> 

Re: [Core-lan-org-devel] jumbo edits, cvsdiff -u

[Marshall R. <mr...@db...>]

one other thing, but it's a bit of a mystery.
    
i added a configuration option, $SITE_IMGSRC, that, if non-empty, is
supposed to contain a URI pointing to an image to put up at the top of
the page. if you look at what i added to includes/screen.php, you'll see
how it gets used, i.e.,
   
+  if( $SITE_IMGSRC != "" ) {
+    echo "<TR valign=\"top\"><TD";
+    if( $no_menu == 0 )
+      echo " width=\"175\"></TD><TD";
+    else
+      echo " colspan=\"2\"";
+    echo " align=\"center\"><IMG src=\"";  
+    echo $SITE_IMGSRC;
+    echo "\"></TD></TR>\n";
+  }
+

now, here's the mystery, no matter what value i put into config.php for
$SITE_IMGSRC, the value in screen.php is always "".
    
after staring at the code for an hour, i'm convinced that config.php is
always include'd before screen.php, so this just makes no sense.
    
any ideas?
    
thanks,

/mtr
   

[Core-lan-org-devel] jumbo edits, cvsdiff -u

[Marshall R. <mr...@db...>]

ok, here we go:

bug fixes
    
1. in includes/security.php, there was a malformed SQL query (missing a
   closing-paren). yikes! i also took the liberty of changing
   "as" to "AS" to be consistent with the upcase of the other SQL
   keywords in the query.

2. in includes/time.php, a previous edit tried to use alpha months
   instead of numeric months. there are two problems with this, first,
   postgres uses numeric months (at least as of 7.1.2); and, second, the
   code that sets the "SELECTED" bit stopped working.


functional changes
    
1. if checked, updating a task sends email to the users in the "user
   group" associated with the task. if there are no users in that group
   (e.g., $usergroup=0), then it goes to $EMAIL_MAILINGLIST; however, if
   that variable is empty, then it goes to the email address associated
   with each user in the system.
    
2. timeout is now configurable, viz., $TIMEOUT_SECS and
   $TIMEOUT_TEXT. the default remains unchanged (one of my users got bit
   by the 1 hour thing, so i'm running it at 8 hours...)
    
3. the ordering of projects on the homepage is configurable,
   viz., $PROJECT_ORDERED_BY. choices are either by "taskname" or
   "deadline" or a permutation, e.g., "deadline,taskname".
    
4. the default checked behavior for task edits is configurable, viz.,
   $CHECKED_DEFAULT. choices are either "" (the default) or "CHECKED".
    
5. when editing a task, you can now re-parent it.
    
6. when looking at a task that you own, there's a new link "I finished
   it!" which does what you'd think.
    
7. when creating/editing a usergroup, you can now set the membership
   (indicate which users are in the group).
    
    
editorial changes
    
1. there were a couple of edit forms where the submit button was
   labelled as "Edit ..." instead of "Submit". since this appears on a
   page where you're already editing, some of my users found it
   confusing.  so, i changed the label to "Submit".

2. while looking through the code for any other mismatched parens in SQL
   queries, i took the liberty of making the spacing of parens
   consistent in a couple of queries.
    
3. when looking at a user, if there aren't any files owned by the user,
   it would say " Bytes", now it says "0 Bytes".
    
enjoy!
    
/mtr

Re: [Core-lan-org-devel] hello? are the maintainers reading this list?

[Marshall R. <mr...@db...>]

> Hello guys,
> 
> Welcome Marshall, it's a honour to have you here.

thanks!
 
> Um, good point. As I've never needed this I've also never thought about it
> very much. It really makes sense but I think that mailing all the group
> members would be preferred above maintaining loads of mailinglists. Any
> comment on this would be very welcome!

it's pretty trivial to add. see my next note.


> > 2. there are only two "major" things missing that i'd really like (and may
> get around to implementing unless you guys say they're bad ideas):
> >
> > 2a. the ability to "re-parent" a task. sometimes when i'm adding a project
> and its subtasks, i get the hierarchy wrong, and i'd really like to be able
> to change the parentid (including setting it to zero to make it a top-level
> task).
> 
> True. This is a 'good thing' (tm) and I will code it if you can't find the
> time.

easy to add. i'll take care of it...

> > 2b. when i'm managing usergroups, i'd really like to be able to see (and
> perhaps edit) which users are in that usergroup. ideally there could be a
> multi-choice drop-down window in the editform for a usergroup.
> 
> It's there, in CVS just waiting for you :) Atleast I think :/. I've been
> coding so much that I've lost track. And if it's not I pretty sure have
> another solution as the question was presented to about 2 weeks ago.

actually, i think it's "half there" right now. the half that's there is the part when you "show" a usergroup, you see the membership. the part that isn't is when you "create" or "edit" a usergroup, being able to select who goes in...

easy to add though.

/mtr

Fw: [Core-lan-org-devel] hello? are the maintainers reading thislist?

[Dennis F. <de...@co...>]

----- Original Message -----
From: "Dennis Fleurbaaij" <de...@co...>
To: "Dave Cridland" <da...@cr...>
Sent: Thursday, July 04, 2002 7:20 AM
Subject: Re: [Core-lan-org-devel] hello? are the maintainers reading
thislist?


> Hi Dave,
>
> Sure sounds good. If you can code this we atleast have a set of options.
>
> 1) Mailman
> 2) Direct email
> 3) qmail's mailinglist software ?
>
> So that would be very cool. We can implement that in every module.
>
> Dennis
>
>
> ----- Original Message -----
> From: "Dave Cridland" <da...@cr...>
> To: "Dennis Fleurbaaij" <de...@co...>
> Cc: <cor...@li...>
> Sent: Wednesday, July 03, 2002 11:39 PM
> Subject: Re: [Core-lan-org-devel] hello? are the maintainers reading
> thislist?
>
>
> > On Wed, 2002-07-03 at 22:00, Dennis Fleurbaaij wrote:
> > > > the sort of "obvious" thing to me was that folks in the usergroup
get
> mail
> > > when you changes get made and the "send to mailing list" box is
checked,
> but
> > > there is only one mailing list, the global one.
> > > >
> > > > comments?
> > >
> > > Um, good point. As I've never needed this I've also never thought
about
> it
> > > very much. It really makes sense but I think that mailing all the
group
> > > members would be preferred above maintaining loads of mailinglists.
Any
> > > comment on this would be very welcome!
> >
> > Ah... I might have some PHP code knocking about that'll control a
> > mailman setup, if you're lucky. Let me have a scout about.
> >
> > Quick scout about, and no code ready, but I think I can give you a
> > working set of functions to do it.
> >
> > The only gotcha is changing the aliases in the system MTA. I could put
> > together a setuid perl script to do that, though the world seems divided
> > on whether that's safe. I think they're safe enough, everyone else
> > disagrees. A lesser gotcha is figuring out what MTA is actually in use
> > on the system - lesser because that's install-time and we can really
> > take our time on that.
> >
> > The member addition and removal is very easy, though. (Famous last
> > words).
> >
> > I'll knock a PHP includable together. Dennis, you'd want functional
> > interface, right?
> >
> > I'm thinking:
> >
> > function mailman_create_list( $listname, $admin_user_email_address,
> > $management_key = 'something random' );
> >
> > // Creates the list, invents a random key if one hasn't been supplied.
> > The key's used for remote management, but we bypass it all the time
> > anyway.
> >
> > function mailman_remove_list( $listname );
> >
> > // Removes the list.
> >
> > function mailman_list_add_user( $listname, $email, $quiet = true );
> >
> > // Adds $email to list. $email could be either a single email address
> > (string) or an array of them. If $quiet, we suppress the welcome message
> > you normally get on joining.
> >
> > function mailman_list_remove_user( $listname, $email );
> >
> > // Drops the user(s) from the list.
> >
> > I can knock that up easily enough in a day.
> >
> > Dave.
> >
> >
>

Re: [Core-lan-org-devel] hello? are the maintainers reading this list?

[Dave C. <da...@cr...>]

On Wed, 2002-07-03 at 22:00, Dennis Fleurbaaij wrote:
> > the sort of "obvious" thing to me was that folks in the usergroup get mail
> when you changes get made and the "send to mailing list" box is checked, but
> there is only one mailing list, the global one.
> >
> > comments?
> 
> Um, good point. As I've never needed this I've also never thought about it
> very much. It really makes sense but I think that mailing all the group
> members would be preferred above maintaining loads of mailinglists. Any
> comment on this would be very welcome!

Ah... I might have some PHP code knocking about that'll control a
mailman setup, if you're lucky. Let me have a scout about.

Quick scout about, and no code ready, but I think I can give you a
working set of functions to do it.
	
The only gotcha is changing the aliases in the system MTA. I could put
together a setuid perl script to do that, though the world seems divided
on whether that's safe. I think they're safe enough, everyone else
disagrees. A lesser gotcha is figuring out what MTA is actually in use
on the system - lesser because that's install-time and we can really
take our time on that.

The member addition and removal is very easy, though. (Famous last
words).

I'll knock a PHP includable together. Dennis, you'd want functional
interface, right?

I'm thinking:

function mailman_create_list( $listname, $admin_user_email_address,
$management_key = 'something random' );

// Creates the list, invents a random key if one hasn't been supplied.
The key's used for remote management, but we bypass it all the time
anyway.

function mailman_remove_list( $listname );

// Removes the list.

function mailman_list_add_user( $listname, $email, $quiet = true );

// Adds $email to list. $email could be either a single email address
(string) or an array of them. If $quiet, we suppress the welcome message
you normally get on joining.

function mailman_list_remove_user( $listname, $email );

// Drops the user(s) from the list.

I can knock that up easily enough in a day.

Dave.

Re: [Core-lan-org-devel] hello? are the maintainers reading this list?

[Dennis F. <de...@co...>]

Hello guys,

Welcome Marshall, it's a honour to have you here.

----- Original Message -----
From: "Marshall Rose" <mr...@db...>
To: <cor...@li...>
Cc: <da...@cr...>
Sent: Wednesday, July 03, 2002 5:53 PM
Subject: Re: [Core-lan-org-devel] hello? are the maintainers reading this
list?


> > Yes, Dennis and the others do read this. I am technically a maintainer,
> > too, although I've never actually done a commit. :-)
>
> solid. i really like this package. it's found the sweet spot between
simplicity and power.
>
> before i send a summary of minor changes along with a "diff -u" later this
week, let me ask two questions.
>
> 1. i'm not quite sure i get the whole "usergroup" thing. i understand the
part about being able to put users in different groups. what i can't quite
figure out is what good this does since most of the code looks for either
$admin=1 or pg_numrows(...owner=$uid).

Well you can add a task to a group this is very handy of you want
administration to access administration tasks and to have sales do sales
tasks. Pretty basically it's what we need and therefore it's here. We use it
for seperating the organisation and the 'normal' users. Most likely somebody
will find it usefull.

> afaik, the only thing that being in a usergroup does is let you see tasks
in that group (unless the globalaccess column is true). is there anything
else here?

See above.
>
> the sort of "obvious" thing to me was that folks in the usergroup get mail
when you changes get made and the "send to mailing list" box is checked, but
there is only one mailing list, the global one.
>
> comments?

Um, good point. As I've never needed this I've also never thought about it
very much. It really makes sense but I think that mailing all the group
members would be preferred above maintaining loads of mailinglists. Any
comment on this would be very welcome!

> 2. there are only two "major" things missing that i'd really like (and may
get around to implementing unless you guys say they're bad ideas):
>
> 2a. the ability to "re-parent" a task. sometimes when i'm adding a project
and its subtasks, i get the hierarchy wrong, and i'd really like to be able
to change the parentid (including setting it to zero to make it a top-level
task).

True. This is a 'good thing' (tm) and I will code it if you can't find the
time.

> 2b. when i'm managing usergroups, i'd really like to be able to see (and
perhaps edit) which users are in that usergroup. ideally there could be a
multi-choice drop-down window in the editform for a usergroup.

It's there, in CVS just waiting for you :) Atleast I think :/. I've been
coding so much that I've lost track. And if it's not I pretty sure have
another solution as the question was presented to about 2 weeks ago.

Thanks for listening,
Dennis Fleurbaaij
de...@co...