[Comsuite-svn] SF.net SVN: comsuite: [170] trunk/code/CSMiddleware/src/org/commsuite/ws/ services/M
Brought to you by:
zduniak
|
From: <zd...@us...> - 2006-10-04 01:48:38
|
Revision: 170
http://svn.sourceforge.net/comsuite/?rev=170&view=rev
Author: zduniak
Date: 2006-09-30 14:21:43 -0700 (Sat, 30 Sep 2006)
Log Message:
-----------
Unnecessary casting and exceptions handling removed
Modified Paths:
--------------
trunk/code/CSMiddleware/src/org/commsuite/ws/services/MessagesService.java
Modified: trunk/code/CSMiddleware/src/org/commsuite/ws/services/MessagesService.java
===================================================================
--- trunk/code/CSMiddleware/src/org/commsuite/ws/services/MessagesService.java 2006-09-30 20:04:50 UTC (rev 169)
+++ trunk/code/CSMiddleware/src/org/commsuite/ws/services/MessagesService.java 2006-09-30 21:21:43 UTC (rev 170)
@@ -51,200 +51,179 @@
*/
public class MessagesService {
- private final MessageManager messageManager;
+ private final MessageManager messageManager;
- private final JMSMessageManager jmsManager;
+ private final JMSMessageManager jmsManager;
- private static final Logger logger = Logger.getLogger(MessagesService.class);
-
- private static MessagesService instance;
-
- public MessagesService() {
- messageManager = SpringMiddlewareContext.getMessageManager();
- jmsManager = SpringMiddlewareContext.getJMSManager();
- }
-
- public static MessagesService getMessagesService() {
- if (null == instance) {
- instance = new MessagesService();
- }
- return instance;
- }
-
- public int getMessagesSize(SearchMessageModel wsMessage) throws WebServiceException {
- try {
- final MessageManager msgManager = (MessageManager) SpringMiddlewareContext
- .getMessageManager();
- if (null == wsMessage) {
- return msgManager.getMessages().size();
- } else {
- return msgManager.getSelectedMessages(wsMessage).size();
- }
- } catch(Throwable t) {
- logger.fatal("error in getMessagesSize method", t);
- throw new WebServiceException(t);
- }
- }
-
- public Collection<WSMessage> getMessagesSubset(int begin, int end) throws WebServiceException {
- try {
- final MessageManager msgManager = (MessageManager) SpringMiddlewareContext
- .getMessageManager();
- final List<Message> mes = (List<Message>)msgManager.getMessages();
- final Collection<WSMessage> result = new FastTable<WSMessage>();
+ private static final Logger logger = Logger
+ .getLogger(MessagesService.class);
- if (begin > end) throw new IllegalArgumentException("Begin index should be lower than end");
- if (begin < 0 || end >= mes.size()) throw new IndexOutOfBoundsException(
- "Index is out of bounds: begin:["+ begin+ "]end:["+ end+"]size:["+ mes.size()+"]");
-
- for (int i = begin; i <= end; i++) {
- result.add((WSMessage) mes.get(i));
- }
- return result;
- } catch (Throwable t) {
- logger.fatal("error in getMessagesSubset method", t);
- throw new WebServiceException(t);
- }
- }
+ private static MessagesService instance;
- public Collection<WSMessage> getAllMessages() throws WebServiceException {
- try {
- final MessageManager msgManager = (MessageManager) SpringMiddlewareContext
- .getMessageManager();
- logger
- .debug("1. THIS CODE IS NEVER RUNNING - this mean that the problem is not in Hibernate mapping");
- final Collection<Message> mes = msgManager.getMessages();
- final Collection<WSMessage> result = new FastTable<WSMessage>();
- for (final Message message : mes) {
- result.add((WSMessage) message);
- }
- logger
- .debug("2. THIS CODE IS ALSO NEVER RUNNING - this mean that the problem is not in Hibernate mapping");
- logger.debug("3. msgs: " + mes);
- return result;
- } catch (Throwable t) {
- logger.fatal("error in getAllMessages method", t);
- throw new WebServiceException(t);
- }
- }
-
- public Collection<WSMessage> getSelectedMessagesSubset(SearchMessageModel wsMessage, int begin, int end) throws WebServiceException {
- try {
- final MessageManager msgManager = (MessageManager) SpringMiddlewareContext
- .getMessageManager();
- List<Message> messages = (List<Message>)msgManager.getSelectedMessages(wsMessage);
+ public MessagesService() {
+ messageManager = SpringMiddlewareContext.getMessageManager();
+ jmsManager = SpringMiddlewareContext.getJMSManager();
+ }
- if (begin > end) throw new IllegalArgumentException("Begin index should be lower than end");
- if (begin < 0 || end >= messages.size()) throw new IndexOutOfBoundsException(
- "Index is out of bounds: begin:["+ begin+ "]end:["+ end+"]size:["+ messages.size()+"]");
-
- Collection<WSMessage> result = new FastTable<WSMessage>();
- for (int i = begin; i <= end; i++) {
- result.add((WSMessage)messages.get(i));
- }
- return result;
- } catch (Throwable t) {
- logger.fatal("error in getSelectedMessages method", t);
- throw new WebServiceException(t);
- }
- }
-
- public Collection<WSMessage> getSelectedMessages(SearchMessageModel wsMessage) throws WebServiceException {
- try {
- final MessageManager msgManager = (MessageManager) SpringMiddlewareContext
- .getMessageManager();
- Collection<Message> messages = msgManager.getSelectedMessages(wsMessage);
- Collection<WSMessage> result = new FastTable<WSMessage>();
- for (Message message : messages) {
- result.add((WSMessage)message);
- }
- return result;
- } catch (Throwable t) {
- logger.fatal("error in getSelectedMessages method", t);
- throw new WebServiceException(t);
- }
- }
+ public static MessagesService getMessagesService() {
+ if (null == instance) {
+ instance = new MessagesService();
+ }
+ return instance;
+ }
- public WSContents getContentsById(String id) throws WebServiceException {
- try {
- final ContentsManager contentsManager = (ContentsManager) SpringMiddlewareContext
- .getContentsManager();
- return (WSContents) contentsManager.getContents(id);
- } catch (Throwable t) {
- logger.fatal("error in getContentsById method", t);
- throw new WebServiceException(t);
- }
- }
+ public int getMessagesSize(SearchMessageModel wsMessage)
+ throws WebServiceException {
+ final MessageManager msgManager = SpringMiddlewareContext
+ .getMessageManager();
+ if (null == wsMessage) {
+ return msgManager.getMessages().size();
+ } else {
+ return msgManager.getSelectedMessages(wsMessage).size();
+ }
+ }
- public Collection<WSSentContent> getSentContentsByMessage(String id) throws WebServiceException {
- try {
- final SentContentManager sentContentManager = (SentContentManager) SpringMiddlewareContext
- .getSentContentManager();
- final List<SentContent> sentContents = sentContentManager.getSentContentsByMessage(id);
- final List<WSSentContent> result = new FastTable<WSSentContent>();
- for (final SentContent content : sentContents) {
- result.add((WSSentContent) content);
- }
- return result;
- } catch (Throwable t) {
- logger.fatal("error in getSentContentsByMessage method", t);
- throw new WebServiceException(t);
- }
- }
+ public Collection<WSMessage> getMessagesSubset(int begin, int end)
+ throws WebServiceException, IllegalArgumentException,
+ IndexOutOfBoundsException {
+ final MessageManager msgManager = SpringMiddlewareContext
+ .getMessageManager();
+ final List<Message> mes = (List<Message>) msgManager.getMessages();
+ final Collection<WSMessage> result = new FastTable<WSMessage>();
- /**
- * @param id
- * @return
- * @throws WebServiceException
- */
- public Collection<WSContents> getContentsBySentContent(String id) throws WebServiceException {
- try {
- final ContentsManager contentsManager = (ContentsManager) SpringMiddlewareContext
- .getContentsManager();
- final List<Contents> contents = contentsManager.getContentsBySentContent(id);
- final List<WSContents> result = new FastTable<WSContents>();
- for (final Contents content : contents) {
- result.add((WSContents) content);
- }
- return result;
- } catch (Throwable t) {
- logger.fatal("error in getSentContentsByMessage method", t);
- throw new WebServiceException(t);
- }
- }
+ if (begin > end)
+ throw new IllegalArgumentException(
+ "Begin index should be lower than end");
+ if (begin < 0 || end >= mes.size())
+ throw new IndexOutOfBoundsException(
+ "Index is out of bounds: begin:[" + begin + "]end:[" + end
+ + "]size:[" + mes.size() + "]");
- public WSMessage getMessageById(String id) throws WebServiceException {
- try {
- final MessageManager msgManager = (MessageManager) SpringMiddlewareContext
- .getMessageManager();
- return msgManager.getMessage(id);
- } catch (Throwable t) {
- logger.fatal("error in getSelectedMessages method", t);
- throw new WebServiceException(t);
- }
- }
+ for (int i = begin; i <= end; i++) {
+ result.add(mes.get(i));
+ }
+ return result;
+ }
- public void resubmitMessageWithId(String messageId) throws WebServiceException {
- try {
- final Message msg = messageManager.getMessage(messageId);
- if (null == msg) {
- throw new WebServiceException("Could not find message with id: " + messageId);
- }
+ public Collection<WSMessage> getAllMessages() throws WebServiceException {
+ final MessageManager msgManager = SpringMiddlewareContext
+ .getMessageManager();
+ logger
+ .debug("1. THIS CODE IS NEVER RUNNING - this mean that the problem is not in Hibernate mapping");
+ final Collection<Message> mes = msgManager.getMessages();
+ final Collection<WSMessage> result = new FastTable<WSMessage>();
+ for (final Message message : mes) {
+ result.add(message);
+ }
+ logger
+ .debug("2. THIS CODE IS ALSO NEVER RUNNING - this mean that the problem is not in Hibernate mapping");
+ logger.debug("3. msgs: " + mes);
+ return result;
+ }
- if (Direction.INBOUND == msg.getDirection()) {
- jmsManager.sendMessage(SpringMiddlewareBeansConstants.M_SAP_IN_QUEUE_NAME, msg);
- logger.debug("Resubmitted inbound message: " + messageId);
- } else if (Direction.OUTBOUND == msg.getDirection()) {
- jmsManager.sendMessage(SpringMiddlewareBeansConstants.M_OUT_ROUTER_QUEUE_NAME, msg);
- logger.debug("Resubmitted outbound message: " + messageId);
- } else {
- throw new WebServiceException("Unsupproted message direction for message with id: "
- + messageId);
- }
- } catch (Throwable t) {
- logger.fatal("Exception while resubmitting message with id: " + messageId, t);
- throw new WebServiceException(t);
- }
- }
+ public Collection<WSMessage> getSelectedMessagesSubset(
+ SearchMessageModel wsMessage, int begin, int end)
+ throws WebServiceException, IllegalArgumentException,
+ IndexOutOfBoundsException {
+ final MessageManager msgManager = SpringMiddlewareContext
+ .getMessageManager();
+ List<Message> messages = (List<Message>) msgManager
+ .getSelectedMessages(wsMessage);
+ if (begin > end)
+ throw new IllegalArgumentException(
+ "Begin index should be lower than end");
+ if (begin < 0 || end >= messages.size())
+ throw new IndexOutOfBoundsException(
+ "Index is out of bounds: begin:[" + begin + "]end:[" + end
+ + "]size:[" + messages.size() + "]");
+
+ Collection<WSMessage> result = new FastTable<WSMessage>();
+ for (int i = begin; i <= end; i++) {
+ result.add(messages.get(i));
+ }
+ return result;
+ }
+
+ public Collection<WSMessage> getSelectedMessages(
+ SearchMessageModel wsMessage) throws WebServiceException {
+ final MessageManager msgManager = SpringMiddlewareContext
+ .getMessageManager();
+ Collection<Message> messages = msgManager
+ .getSelectedMessages(wsMessage);
+ Collection<WSMessage> result = new FastTable<WSMessage>();
+ for (Message message : messages) {
+ result.add(message);
+ }
+ return result;
+ }
+
+ public WSContents getContentsById(String id) throws WebServiceException {
+ final ContentsManager contentsManager = SpringMiddlewareContext
+ .getContentsManager();
+ return contentsManager.getContents(id);
+ }
+
+ public Collection<WSSentContent> getSentContentsByMessage(String id)
+ throws WebServiceException {
+ final SentContentManager sentContentManager = SpringMiddlewareContext
+ .getSentContentManager();
+ final List<SentContent> sentContents = sentContentManager
+ .getSentContentsByMessage(id);
+ final List<WSSentContent> result = new FastTable<WSSentContent>();
+ for (final SentContent content : sentContents) {
+ result.add(content);
+ }
+ return result;
+ }
+
+ /**
+ * @param id
+ * @return
+ * @throws WebServiceException
+ */
+ public Collection<WSContents> getContentsBySentContent(String id)
+ throws WebServiceException {
+ final ContentsManager contentsManager = SpringMiddlewareContext
+ .getContentsManager();
+ final List<Contents> contents = contentsManager
+ .getContentsBySentContent(id);
+ final List<WSContents> result = new FastTable<WSContents>();
+ for (final Contents content : contents) {
+ result.add(content);
+ }
+ return result;
+ }
+
+ public WSMessage getMessageById(String id) throws WebServiceException {
+ final MessageManager msgManager = SpringMiddlewareContext
+ .getMessageManager();
+ return msgManager.getMessage(id);
+ }
+
+ public void resubmitMessageWithId(String messageId)
+ throws WebServiceException {
+ final Message msg = messageManager.getMessage(messageId);
+ if (null == msg) {
+ throw new WebServiceException("Could not find message with id: "
+ + messageId);
+ }
+
+ if (Direction.INBOUND == msg.getDirection()) {
+ jmsManager.sendMessage(
+ SpringMiddlewareBeansConstants.M_SAP_IN_QUEUE_NAME, msg);
+ logger.debug("Resubmitted inbound message: " + messageId);
+ } else if (Direction.OUTBOUND == msg.getDirection()) {
+ jmsManager
+ .sendMessage(
+ SpringMiddlewareBeansConstants.M_OUT_ROUTER_QUEUE_NAME,
+ msg);
+ logger.debug("Resubmitted outbound message: " + messageId);
+ } else {
+ throw new WebServiceException(
+ "Unsupproted message direction for message with id: "
+ + messageId);
+ }
+ }
+
}
This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.
|