[Comsuite-svn] SF.net SVN: comsuite: [186] trunk/code/CSMiddleware/src/org/commsuite/sap

[<zd...@us...>]

Revision: 186
          http://svn.sourceforge.net/comsuite/?rev=186&view=rev
Author:   zduniak
Date:     2006-10-02 09:53:42 -0700 (Mon, 02 Oct 2006)

Log Message:
-----------
Code cleanup

Modified Paths:
--------------
    trunk/code/CSMiddleware/src/org/commsuite/sap/JCoFunctionTranslator.java
    trunk/code/CSMiddleware/src/org/commsuite/sap/SAPCommManager.java

Modified: trunk/code/CSMiddleware/src/org/commsuite/sap/JCoFunctionTranslator.java
===================================================================
--- trunk/code/CSMiddleware/src/org/commsuite/sap/JCoFunctionTranslator.java	2006-10-02 16:49:49 UTC (rev 185)
+++ trunk/code/CSMiddleware/src/org/commsuite/sap/JCoFunctionTranslator.java	2006-10-02 16:53:42 UTC (rev 186)
@@ -24,7 +24,6 @@
 import java.io.ByteArrayOutputStream;
 import java.io.IOException;
 import java.io.UnsupportedEncodingException;
-import java.util.Arrays;
 import java.util.Calendar;
 import java.util.Date;
 import java.util.List;
@@ -76,6 +75,9 @@
 
 	private final static int TYPE_CHAR = 4;
 
+	/**
+	 * TODO: JavaDoc
+	 */
 	public static JCO.Function getJCOFunctionFromNotification(
 			Notification notification, IRepository repository) {
 		final JCO.Function f = repository.getFunctionTemplate(
@@ -835,28 +837,28 @@
 		return result.toArray(new Message[result.size()]);
 	}
 
+	/**
+	 * TODO: JavaDoc
+	 */
 	private static byte[] convertBytes(final byte[] data, String fromCharset,
 			String toCharset) {
-		
-		// hack
-//		if ("UnicodeLittle".equalsIgnoreCase(fromCharset)) {
-//			fromCharset = "UTF-8";
-//		}
-		// end of hack
-		
 		try {
 			final String tmp = new String(data, fromCharset);
 			if (data.length > 0 && tmp.length() == 0) {
+				logger.warn("Charsets: from '" + fromCharset + "' produced empty string");
 				return data;
 			}
 			return tmp.getBytes(toCharset);
 		} catch (UnsupportedEncodingException e) {
-			logger.warn("Charsets: '" + fromCharset + "', '" + toCharset
+			logger.warn("Charsets: from: '" + fromCharset + "' to '" + toCharset
 					+ "' not supported", e);
 			return data;
 		}
 	}
 
+	/**
+	 * TODO: JavaDoc
+	 */
 	private static Object getOptionalVal(String name, int type,
 			com.sap.mw.jco.JCO.Record rec) {
 		Object val = null;

Modified: trunk/code/CSMiddleware/src/org/commsuite/sap/SAPCommManager.java
===================================================================
--- trunk/code/CSMiddleware/src/org/commsuite/sap/SAPCommManager.java	2006-10-02 16:49:49 UTC (rev 185)
+++ trunk/code/CSMiddleware/src/org/commsuite/sap/SAPCommManager.java	2006-10-02 16:53:42 UTC (rev 186)
@@ -74,6 +74,9 @@
         return Collections.unmodifiableMap(this.sapComms);
     }
 
+    /**
+	 * TODO: JavaDoc
+	 */
     public SAPCommManager() {
         super();
         sapComms = new FastMap<String, ISAPComm>();
@@ -91,6 +94,9 @@
         this.sapComms = sapComms;
     }
 
+    /**
+	 * TODO: JavaDoc
+	 */
     public void sendMessageToDefault(Message message) {
         logger.debug("Sending message to default SAP servers");
 
@@ -113,6 +119,9 @@
         }
     }
 
+    /**
+	 * TODO: JavaDoc
+	 */
     public void init() {
         logger.debug("Running init() method in SAPCommManager (size: " + sapComms.size() + ")");
 
@@ -140,6 +149,9 @@
         }
     }
 
+    /**
+	 * TODO: JavaDoc
+	 */
     private void initJCOTracePath() {
         final String jcoTracePath = getClass().getResource("/").getPath() + ".." + File.separator
                 + ".." + File.separator + ".." + File.separator + ".." + File.separator + "logs"
@@ -151,6 +163,9 @@
 
     }
 
+    /**
+	 * TODO: JavaDoc
+	 */
     public void destroy() {
         logger.info("Destroying SAPCommManager");
         for (final ISAPComm sapComm : sapComms.values()) {
@@ -159,6 +174,9 @@
         logger.info("SAPCommManager destroyed");
     }
 
+    /**
+	 * TODO: JavaDoc
+	 */
     // TODO: should this method be sensitive on active field??
     public void setSapInstances(Collection<SAPInstanceDef> sapInstances) {
         // TODO: init sapComms collection with values from DB
@@ -186,6 +204,9 @@
         }
     }
 
+    /**
+	 * TODO: JavaDoc
+	 */
     // TODO: should this method be sensitive on active field??
     public void setSapInstance(SAPInstanceDef instance) {
     	if (!isEnabled()) {
@@ -199,20 +220,32 @@
         sapComms.put(sapComm.getName(), sapComm);
     }
 
+    /**
+	 * TODO: JavaDoc
+	 */
     public void setNotificationsManager(INotificationsManager notificationsManager) {
         this.notificationsManager = notificationsManager;
     }
 
+    /**
+	 * TODO: JavaDoc
+	 */
     public boolean isEnabled() {
         return enabled;
     }
 
+    /**
+	 * TODO: JavaDoc
+	 */
     /* package scope */void checkExistenceOfSAPInstance(String instanceName) {
         if (!sapComms.containsKey(instanceName)) {
             throw new SAPInstanceException("Instance: " + instanceName + " does not exist.");
         }
     }
 
+    /**
+	 * TODO: JavaDoc
+	 */
     public void startInstance(String instanceName) {
         logger.info("Starting instance: " + instanceName);
         checkExistenceOfSAPInstance(instanceName);
@@ -226,6 +259,9 @@
         }
     }
 
+    /**
+	 * TODO: JavaDoc
+	 */
     public void stopInstance(String instanceName) {
         logger.info("Stopping instance: " + instanceName);
         checkExistenceOfSAPInstance(instanceName);
@@ -234,6 +270,9 @@
         logger.info("Instance stopped: " + instanceName);
     }
 
+    /**
+	 * TODO: JavaDoc
+	 */
     public void destroyInstance(String instanceName) {
         logger.info("Destroying instance: " + instanceName);
         checkExistenceOfSAPInstance(instanceName);
@@ -244,10 +283,16 @@
         logger.info("Instance destroyed: " + instanceName);
     }
 
+    /**
+	 * TODO: JavaDoc
+	 */
     public ISAPComm getSAPCommByName(String name) {
         return sapComms.get(name);
     }
 
+    /**
+	 * TODO: JavaDoc
+	 */
 	public boolean isSapServerWorking(String name) {
 		ISAPComm SappCommByName = getSAPCommByName(name);
 		return (null != SappCommByName && null != SappCommByName.getServer());


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.