[Comsuite-svn] SF.net SVN: comsuite: [184] trunk/code/CSCommon/src/org/commsuite/aop/ SystemArchitecture.java

[<zd...@us...>]

Revision: 184
          http://svn.sourceforge.net/comsuite/?rev=184&view=rev
Author:   zduniak
Date:     2006-10-02 08:18:41 -0700 (Mon, 02 Oct 2006)

Log Message:
-----------
SystemArchitecture.java performance slightly improved (mainly due to improvements in strings concatenation mechanism)

Modified Paths:
--------------
    trunk/code/CSCommon/src/org/commsuite/aop/SystemArchitecture.java

Modified: trunk/code/CSCommon/src/org/commsuite/aop/SystemArchitecture.java
===================================================================
--- trunk/code/CSCommon/src/org/commsuite/aop/SystemArchitecture.java	2006-10-02 15:03:17 UTC (rev 183)
+++ trunk/code/CSCommon/src/org/commsuite/aop/SystemArchitecture.java	2006-10-02 15:18:41 UTC (rev 184)
@@ -36,14 +36,14 @@
 			.getLogger(SystemArchitecture.class);
 
 	/**
-	 *  TODO: JavaDoc
+	 * TODO: JavaDoc
 	 */
 	@Pointcut("execution(* org.commsuite..*(..))")
 	public void dataAccessOperation() {
 	}
 
 	/**
-	 *  TODO: JavaDoc
+	 * TODO: JavaDoc
 	 */
 	@Around("dataAccessOperation()")
 	public Object doDataAccessOperation(ProceedingJoinPoint pjp)
@@ -63,17 +63,20 @@
 			// pass - do not bother if we can not get line number
 		}
 
-		String parameters = "";
+		final StringBuilder parameters = new StringBuilder();
 
 		if (null != pjp.getArgs()) {
+			// TODO: consider using only one method invocation:
+			// Arrays.toString(pjp.getArgs())
+			// instead of below loop:
 			for (int i = 0; i < pjp.getArgs().length; i++) {
 				if (i != 0) {
-					parameters += ", ";
+					parameters.append(", ");
 				}
 				try {
-					parameters += pjp.getArgs()[i];
+					parameters.append(pjp.getArgs()[i]);
 				} catch (Exception e) {
-					parameters += "???";
+					parameters.append("???");
 					// don't cate if we can NOT log some parameter
 				}
 			}
@@ -81,15 +84,15 @@
 
 		Object result = null;
 
-		logger.debug(pjp.getSignature() + " " + lineNumber + " (" + parameters
-				+ ") START");
+		logger.debug(pjp.getSignature() + " " + lineNumber + " ("
+				+ parameters.toString() + ") START");
 		try {
 			result = pjp.proceed();
 		} catch (Throwable e) {
 			logger.debug(pjp.getSignature().toString(), e);
 			throw e;
 		}
-		
+
 		logger.debug(pjp.getSignature() + " " + result);
 		return result;
 	}


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.