Update of /cvsroot/commonjava/commonjava-projects/commonjava-datasrc/src/java/org/commonjava/datasrc/sql/config
In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv8549/src/java/org/commonjava/datasrc/sql/config
Modified Files:
PoolConnectionInfo.java
Log Message:
added unit test for connection pool by itself, using hsqldb.
Isolated the ConnectionPool to allow for single-pool direct
instantiations, instead of always having to work through the
manager...also improved the user/password logic for
connection instantiation.
Index: PoolConnectionInfo.java
===================================================================
RCS file: /cvsroot/commonjava/commonjava-projects/commonjava-datasrc/src/java/org/commonjava/datasrc/sql/config/PoolConnectionInfo.java,v
retrieving revision 1.1
retrieving revision 1.2
diff -u -d -r1.1 -r1.2
--- PoolConnectionInfo.java 20 Jan 2004 04:42:41 -0000 1.1
+++ PoolConnectionInfo.java 29 Jan 2004 03:54:31 -0000 1.2
@@ -16,6 +16,9 @@
import java.sql.SQLException;
import java.util.Properties;
+import org.commonjava.lang.Verifiable;
+import org.commonjava.util.Strings;
+
/**
* Contains database connection information attributes.
*
@@ -25,10 +28,12 @@
* @author James Lewis
* @version 1.1
*/
-public class PoolConnectionInfo
+public class PoolConnectionInfo implements Verifiable
{
public static final int DEFAULT_MAX_SIZE = 10;
public static final int DEFAULT_MIN_SIZE = 1;
+ public static final String USER_PROPERTY = "user";
+ public static final String PASSWORD_PROPERTY = "password";
private String name;
private String driverName;
@@ -235,4 +240,11 @@
public void setUser(String user) {
this.user = user;
}
+
+ /* (non-Javadoc)
+ * @see org.commonjava.lang.Verifiable#verifyValid()
+ */
+ public boolean verifyValid() {
+ return !Strings.empty(name) && !Strings.empty(driverName) && !Strings.empty(url);
+ }
}
\ No newline at end of file
|
