#128 access to bookmarks in fullscreen mode

open
nobody
5
2009-07-29
2009-07-29
Anonymous
No

you can add and edit bookmarks in fullscreen mode, because there's hotkey
but you can't open any bookmark in this mode :(
comix rocks, greets!

Discussion

  • Nobody/Anonymous

    I upgraded comix from version 3, and I miss this as well.

    Also, to open another file, I have to disable fullscreen mode to reach File -> Open. In versions before 4.x that could be done in fullscreen mode, because the File menu was also in he right-click context menu.

    IMHO there should be a way to access every menu from the context menu, just like the 3.x versions. That way there's nothing that can't be done in fullscreen mode.

     
  • Nobody/Anonymous

    Here's a patch to make the right-click popup menu show pretty much the same items as the old v3 popup menu.
    This fixes the issue for me.

    --- ui.py 2009-01-25 17:55:54.000000000 +0100
    +++ ui.py 2009-08-15 10:06:49.000000000 +0200
    @@ -61,12 +61,16 @@ class MainUI(gtk.UIManager):
    None, None, window.flip_vertically),
    ('menu_zoom', 'comix-zoom', _('Manual _Zoom')),
    ('menu_recent', None, _('Open _recent')),
    + ('menu_recent_popup', gtk.STOCK_DND_MULTIPLE, _('Open _recent')),
    ('menu_bookmarks', None, _('_Bookmarks')),
    + ('menu_bookmarks_popup', 'comix-add-bookmark', _('_Bookmarks')),
    ('menu_toolbars', None, _('T_oolbars')),
    ('menu_edit', None, _('_Edit')),
    ('menu_file', None, _('_File')),
    ('menu_view', None, _('_View')),
    + ('menu_view_popup', 'comix-image', _('_View')),
    ('menu_go', None, _('_Go')),
    + ('menu_go_popup', gtk.STOCK_GO_FORWARD, _('_Go')),
    ('menu_help', None, _('_Help')),
    ('menu_transform', 'comix-transform', _('_Transform')),
    ('expander', None, None, None, None, None)])
    @@ -229,18 +233,29 @@ class MainUI(gtk.UIManager):
    </menubar>

    <popup name="Popup">
    - <menuitem action="next_page" />
    - <menuitem action="previous_page" />
    - <separator />
    - <menuitem action="fullscreen" />
    - <menuitem action="double_page" />
    - <menuitem action="manga_mode" />
    - <separator />
    - <menuitem action="best_fit_mode" />
    - <menuitem action="fit_width_mode" />
    - <menuitem action="fit_height_mode" />
    - <menuitem action="fit_manual_mode" />
    + <menu action="menu_go_popup">
    + <menuitem action="next_page" />
    + <menuitem action="previous_page" />
    + <menuitem action="first_page" />
    + <menuitem action="last_page" />
    + <separator />
    + <menuitem action="slideshow" />
    + </menu>
    <separator />
    + <menu action="menu_view_popup">
    + <menuitem action="fullscreen" />
    + <menuitem action="double_page" />
    + <menuitem action="manga_mode" />
    + <separator />
    + <menuitem action="best_fit_mode" />
    + <menuitem action="fit_width_mode" />
    + <menuitem action="fit_height_mode" />
    + <menuitem action="fit_manual_mode" />
    + <separator />
    + <menuitem action="enhance_image" />
    + <separator />
    + <menuitem action="lens" />
    + </menu>
    <menu action="menu_transform">
    <menuitem action="rotate_90" />
    <menuitem action="rotate_270" />
    @@ -251,15 +266,31 @@ class MainUI(gtk.UIManager):
    <separator />
    <menuitem action="keep_transformation" />
    </menu>
    - <menu action="menu_toolbars">
    - <menuitem action="menubar" />
    - <menuitem action="toolbar" />
    - <menuitem action="statusbar" />
    - <menuitem action="scrollbar" />
    - <menuitem action="thumbnails" />
    - <separator />
    - <menuitem action="hide all" />
    + <menu action="menu_zoom">
    + <menuitem action="zoom_in" />
    + <menuitem action="zoom_out" />
    + <menuitem action="zoom_original" />
    + </menu>
    + <menu action="menu_bookmarks_popup">
    + </menu>
    + <separator />
    + <menuitem action="properties" />
    + <menuitem action="comments" />
    + <menuitem action="preferences" />
    + <menuitem action="thumbnail_maintenance" />
    + <separator />
    + <menuitem action="edit_archive" />
    + <separator />
    + <menu action="menu_recent_popup">
    </menu>
    + <separator />
    + <menuitem action="open" />
    + <menuitem action="library" />
    + <separator />
    + <menuitem action="about" />
    + <separator />
    + <menuitem action="close" />
    + <menuitem action="quit" />
    </popup>
    </ui>
    """
    @@ -271,10 +302,18 @@ class MainUI(gtk.UIManager):
    self.get_widget('/Menu/menu_bookmarks').set_submenu(self.bookmarks)
    self.get_widget('/Menu/menu_bookmarks').show()

    + self.bookmarksPopup = bookmark.BookmarksMenu(self, window)
    + self.get_widget('/Popup/menu_bookmarks_popup').set_submenu(self.bookmarksPopup)
    + self.get_widget('/Popup/menu_bookmarks_popup').show()
    +
    self.recent = recent.RecentFilesMenu(self, window)
    self.get_widget('/Menu/menu_file/menu_recent').set_submenu(self.recent)
    self.get_widget('/Menu/menu_file/menu_recent').show()

    + self.recentPopup = recent.RecentFilesMenu(self, window)
    + self.get_widget('/Popup/menu_recent_popup').set_submenu(self.recentPopup)
    + self.get_widget('/Popup/menu_recent_popup').show()
    +
    window.add_accel_group(self.get_accel_group())

    # Is there no built-in way to do this?

     
  • Nephiel

    Nephiel - 2009-08-15

    Posting the patch in plain text didn't work, and it seems that I can't attach files, so here's a mediafire link to download it:

    http://www.mediafire.com/download.php?ekwznkyjfkm

     

Get latest updates about Open Source Projects, Conferences and News.

Sign up for the SourceForge newsletter:





No, thanks