[coLinux-devel] [ colinux-Bugs-2013501 ] The configuration file format is fragile

[SourceForge.net <no...@so...>]

Bugs item #2013501, was opened at 2008-07-08 15:36
Message generated for change (Comment added) made by henryn
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=622063&aid=2013501&group_id=98788

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: v0.7.x (release)
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Adrien Beau (abeau)
Assigned to: Henry N. (henryn)
Summary: The configuration file format is fragile

Initial Comment:
While experimenting with cofs, I made the following mistake:

# --- config start ---

# There is no need to bother creating an ISO-9660 image
# for the installation CD-ROM, we can directly point to
# the files downloaded from slackware.at thanks to cofs.
cofs0= C:\Linux\archive\slackware-12.1\www.slackware.at\data\slackware-12.1
#cofs1=D:\
#cofs2=D:\temp

# --- config end ---

The mistake is the space left after the equal sign in the cofs0 line.

coLinux parses this config file as if "cofs0=" was on a line by itself, and then independantly parses C:\Linux\... (being an unknown entity, it is passed as-is to the Linux kernel command line).

The cofs path being empty, is considered a path relative to the configuration file location, so we end up with cofs0 directly pointing to the configuration directory. (A somewhat dangerous configuration I would say, since it also often contains the filesystem images.)

Maybe the parser should be improved so that it ignores the whitespace characters right before and after the first equal sign in the configuration file lines? At least a warning should be added to colinux-daemon.txt.

----------------------------------------------------------------------

Comment By: Henry N. (henryn)
Date: 2008-09-12 00:15

Message:
Fixed in SVN revision 1120.


----------------------------------------------------------------------

Comment By: Henry N. (henryn)
Date: 2008-07-09 22:11

Message:
Logged In: YES 
user_id=579204
Originator: NO

Hello Adrien.

many thanks for your bug reports. We will fix it next.

Bebbo, the function GetPrivateProfileString is not usable here. The
command parser should not depend on Windows platform. We have also coLinux
for Linux and a (very long) plan was more platforms. But the second makes
more priority: All not parsed arguments must be forward to Linux kernel
command line, for example a simple "ro" or "root=/dev/...".

Henry

----------------------------------------------------------------------

Comment By: Stefan Franke (bebbo)
Date: 2008-07-08 16:32

Message:
Logged In: YES 
user_id=406985
Originator: NO

why use an own parser? Simply use the GetPrivateProfileString functio.

=> http://msdn.microsoft.com/en-us/library/ms724353.aspx

Bebbo

----------------------------------------------------------------------

Comment By: Adrien Beau (abeau)
Date: 2008-07-08 16:23

Message:
Logged In: YES 
user_id=787269
Originator: YES

My cofs0 line was broken in two when I posted the bug report. Like I
described, in the config file, I had cofs0= and the C:\Linux path on the
same line, separated by a space.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=622063&aid=2013501&group_id=98788