colinux-devel

[coLinux-devel] linux kernel; array size missing in `data'

[Ian L. <Ian...@mq...>]

Hi Dan,

  See below, using the colinux-20040131 patch, I am getting a kernel
compile error, regarding the variable "data" in cooperative.h  ("putcs"
structure within the co_console_message_t structure).

  I have decided that if you haven't seen this in your compiles, then it
may be compiler related - this is my compiler version;

    [root@host]# gcc --version
    2.96

  Has anyone else seen this issue?  If not, which compiler version
are you using?

  Alternatively, if this is supposed to be a single char (put-char-screen?)
then how about redefining data[] as data[2]?




COMPILE ERROR;

gcc -D__KERNEL__ -I/usr/src/linux-2.4.24/include -Wall -Wstrict-prototypes -Wno-trigraphs -
O2 -fno-strict-aliasing -fno-common -fomit-frame-pointer -pipe -mpreferred-stack-
boundary=2 -march=i586   -DKBUILD_BASENAME=main -c -o init/main.o init/main.c
In file included from /usr/src/linux-2.4.24/include/linux/cooperative.h:15,
                 from /usr/src/linux-2.4.24/include/asm/io.h:5,
                 from /usr/src/linux-2.4.24/include/linux/blkdev.h:11,
                 from /usr/src/linux-2.4.24/include/linux/blk.h:4,
                 from init/main.c:25:
/usr/src/linux-2.4.24/include/asm/cooperative.h:73: array size missing in `params'
In file included from /usr/src/linux-2.4.24/include/asm/io.h:5,
                 from /usr/src/linux-2.4.24/include/linux/blkdev.h:11,
                 from /usr/src/linux-2.4.24/include/linux/blk.h:4,
                 from init/main.c:25:
/usr/src/linux-2.4.24/include/linux/cooperative.h:103: array size missing in `data'
make: *** [init/main.o] Error 1



INCLUDE FILE

typedef struct {
        unsigned long size;
        co_operation_console_t type;
        union {
                struct {
                        long t;      /* Start of scroll region (row) */
                        long b;      /* End of scroll region (row) */
                        long dir;    /* End of scroll region (row) */
                        long lines;  /* Number of lines to scroll */
                } scroll;
                struct {
                        long x;
                        long y;
                        long count;
                        char data[];        <-- line 103
                } putcs;
                struct {
                        long x;
                        long y;
                        unsigned short charattr;
                } putc;
                co_cursor_pos_t cursor;
        };
} co_console_message_t;


--
Ian Latter
Internet and Networking Security Officer
Macquarie University

 Meet me at the Australian Unix and open systems
   User Group (AUUG) Security Symposium; 2004
  http://www.auug.org.au/events/2004/security/

Re: [coLinux-devel] linux kernel; array size missing in `data'

[Dan A. <da...@gm...>]

On Sun, Feb 01, 2004 at 09:35:48AM +1000, Ian Latter wrote:
> Hi Dan,
> 
>   See below, using the colinux-20040131 patch, I am getting a kernel
> compile error, regarding the variable "data" in cooperative.h  ("putcs"
> structure within the co_console_message_t structure).
> 
>   I have decided that if you haven't seen this in your compiles, then it
> may be compiler related - this is my compiler version;
> 
>     [root@host]# gcc --version
>     2.96
> 
>   Has anyone else seen this issue?  If not, which compiler version
> are you using?

Please use gcc version 3.

[07:35 pts/5,callisto ~]% gcc -v
Reading specs from /usr/lib/gcc-lib/i486-linux/3.3.3/specs
Configured with: ../src/configure -v --enable-languages=c,c++,java,f77,pascal,objc,ada,treelang --prefix=/usr 
--mandir=/usr/share/man --infodir=/usr/share/info --with-gxx-include-dir=/usr/include/c++/3.3 --enable-shared 
--with-system-zlib --enable-nls --without-included-gettext --enable-__cxa_atexit --enable-clocale=gnu 
--enable-debug --enable-java-gc=boehm --enable-java-awt=xlib --enable-objc-gc i486-linux
Thread model: posix
gcc version 3.3.3 20040125 (prerelease) (Debian)

>   Alternatively, if this is supposed to be a single char (put-char-screen?)
> then how about redefining data[] as data[2]?

You can define it as data[0] and it may fix the problem for your compiler.

-- 
Dan Aloni
da...@gm...