From: Pieter v. Z. <pv...@us...> - 2005-08-10 08:32:36
|
Update of /cvsroot/coefficient/coefficient/src/za/org/coefficient/modules/user In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv12136/src/za/org/coefficient/modules/user Modified Files: UserAdmin.java Log Message: added a comment and FIXME. Maybe we can improve this in later versions. Index: UserAdmin.java =================================================================== RCS file: /cvsroot/coefficient/coefficient/src/za/org/coefficient/modules/user/UserAdmin.java,v retrieving revision 1.10 retrieving revision 1.11 diff -C2 -d -r1.10 -r1.11 *** UserAdmin.java 25 May 2005 13:32:33 -0000 1.10 --- UserAdmin.java 10 Aug 2005 08:32:27 -0000 1.11 *************** *** 413,416 **** --- 413,417 ---- public CoefficientContext saveUser(CoefficientContext ctx) throws HibernateException { CoefficientUser user = null; + //FIXME: Seems we set this somewhere else otherwise we default to -1. Try to find better solution to this. Long id = ctx.getParameterAsLong("id", -1); long confId = -1; *************** *** 464,468 **** } } ! if (id.longValue() > 0) { ctx.setSessionAttribute(Constants.USER_SESSION_STRING, user); --- 465,469 ---- } } ! //FIXME: Why do we have this here if it is never true?!!! We don't know the id of the current user object?! if (id.longValue() > 0) { ctx.setSessionAttribute(Constants.USER_SESSION_STRING, user); |