Re: [Codestriker-user] Perforce pending changelist with new and editedfiles

[Harris, J. <Je...@ai...>]

We had the same issue where I work.  We ended up writing a wrapper
script which looked for new and deleted files and generated output in
the diff which made the output look like the file was added or deleted.
For added files, the from file was <none>, a "@@ -0,0 +1,<len> @@" diff
header, and all of the lines were prefixed with a "+".  Similar output
for deleted files.

Jeff

-----Original Message-----
From: cod...@li...
[mailto:cod...@li...] On Behalf Of
Brian Harnish
Sent: Friday, September 21, 2007 10:36 AM
To: cod...@li...
Subject: [Codestriker-user] Perforce pending changelist with new and
editedfiles


We are currently evaluating different code review tools at my company,
and I just installed codestriker and am in the process reviewing it.

The documentation tells me to upload a file that was the output of the
perforce diff. The diff doesn't include the lines of the new file. I
have seen that even though the diff doesn't contain lines of the
deleted file codestriker knows it was deleted and can display the
lines, but in the pending changelist the new file has not been added
to the RCS yet.

Can I create 1 topic for review of both edited and new files (and
how)? I know I can upload the new files separately, but that creates a
different topic.

 - Brian

------------------------------------------------------------------------
-
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2005.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
Codestriker-user mailing list
Cod...@li...
https://lists.sourceforge.net/lists/listinfo/codestriker-user