Re: [Codestriker-user] maximum length of reviewers list

[David S. <si...@us...>]

Hi Giuseppe,

We might as well make this a very big number, such as 1024, so we don't 
ever hit this limit in practice.  The database schema is certainly not a 
limiting factor here, and the UI won't change in appearance either.

I'll commit your change into CVS, with a value of 1024.  Thanks for the 
report.  I'll also update the create topic page as well.

Cheers,
David

Giuseppe Scelsi wrote:
> Hi all,
> 
> One of my reviewers lists has hit the maximum length accepted in CS
> 1.9.2 alpha 5.  Both the "add topic" "add comment" dialogs don't allow
> more than 150 characters and that fits roughly 5 email addresses.  It
> was easy enough to work around this limitation by modifying two files as
> per attached patch, however this might be something that could warrant
> the use of a configuration variable rather than being controlled by
> hardcoded magic number.
> 
> Cheers,
> 
> Giuseppe
> 
> 
> 
> ------------------------------------------------------------------------
> 
> --- ./html/codestriker.js_ORIG	2006-06-15 15:18:09.970165824 +1000
> +++ ./html/codestriker.js	2006-06-15 15:18:20.274599312 +1000
> @@ -217,7 +217,7 @@
>              '(add other reviewers)</a></font> </td>' +
>              '<td>' +
>  	    '<input type="text" name="comment_cc" size="25" ' +
> -                    'maxlength="150"></td>\n' +
> +                    'maxlength="300"></td>\n' +
>              '<td><input type="submit" name="submit" value="Submit"></td>' +
>              '</tr></table></form></body></html>\n';
> 
> --- ./template/en/default/viewtopicproperties.html.tmpl_ORIG	2006-06-15 15:42:55.703300056 +1000
> +++ ./template/en/default/viewtopicproperties.html.tmpl	2006-06-15 15:26:17.001125864 +1000
> @@ -95,7 +95,7 @@
>    <td>Reviewers:</td>
>    <td>
>      <input type="text" name="reviewers" value="[% reviewers | html_entity %]"
> -           size="50" maxlength="150"
> +           size="50" maxlength="300"
>    	   [%# Check to see if the topic is open or not #%]
>  	   [% IF antispam_email || topic_readonly != 0 %]readonly[% END %] />
>    </td>
> 
> 
> ------------------------------------------------------------------------
> 
> _______________________________________________
> Codestriker-user mailing list
> Cod...@li...
> https://lists.sourceforge.net/lists/listinfo/codestriker-user