Re: [Codestriker-user] Sorted list of files in a topic.

[Jason R. <jre...@ya...>]

Hi,

How about it just sorts it all of the time given that the order that svn returns the files really
does not have any meaning.

Thanks
Jason

--- David Sitsky <si...@us...> wrote:

> Hi Vlad,
> 
> > I'm creating topics directly from Subversion. One problem I've noticed
> > immediately
> > is that file list in a topic is not sorted by filename. Instead, files
> > are listed in some
> > semi-sorted order defined by Subversion. I couldn't find any
> > configuration options
> > that would trigger file sorting. Did I miss something?
> 
> The order the files are presented is the same as that in the text 
> uploaded into Codestriker, or the order obtained from the SCM, in your 
> case, Subversion.  So no, you didn't miss anything.
> 
> > Patching the code to sort by filename was rather trivial: in
> > lib\Codestriker\FileParser\Parser.pm,
> > insert just before the first return:
> > 
> >     # Sort the diff chunks by filename, then old linenumber
> >     @diffs = sort { $a->{filename} cmp $b->{filename} ||
> > $a->{old_linenumber} <=> $b->{old_linenumber} } @diffs;
> >  
> > Would it make sense to make this a configurable feature?
> 
> I can imagine this could be useful for large reviews.  Rather than 
> making this a configurable feature (codestriker.conf is also quite large 
> and complex), it might be useful to have a link instead on the view 
> topic page above the list of files, for example:
> 
> Download topic text | ... | Tab width ... | Sort by filename
> 
> Clicking on the sort by filename link will set a CGI parameter, which 
> will then execute code similar to what you have, but this would be in 
> ViewTopic.pm over the list of delta objects.  That way, a reviewer can 
> choose at runtime which way they'd prefer to see the list of files 
> presented.
> 
> What do you think?
> 
> Cheers,
> David
> 
> 
> 
> -------------------------------------------------------
> All the advantages of Linux Managed Hosting--Without the Cost and Risk!
> Fully trained technicians. The highest number of Red Hat certifications in
> the hosting industry. Fanatical Support. Click to learn more
> http://sel.as-us.falkag.net/sel?cmd=lnk&kid=107521&bid=248729&dat=121642
> _______________________________________________
> Codestriker-user mailing list
> Cod...@li...
> https://lists.sourceforge.net/lists/listinfo/codestriker-user
> 


__________________________________________________
Do You Yahoo!?
Tired of spam?  Yahoo! Mail has the best spam protection around 
http://mail.yahoo.com