Re: [Codestriker-user] Sorted list of files in a topic.

[David S. <si...@us...>]

Hi Vlad,

> I'm creating topics directly from Subversion. One problem I've noticed
> immediately
> is that file list in a topic is not sorted by filename. Instead, files
> are listed in some
> semi-sorted order defined by Subversion. I couldn't find any
> configuration options
> that would trigger file sorting. Did I miss something?

The order the files are presented is the same as that in the text 
uploaded into Codestriker, or the order obtained from the SCM, in your 
case, Subversion.  So no, you didn't miss anything.

> Patching the code to sort by filename was rather trivial: in
> lib\Codestriker\FileParser\Parser.pm,
> insert just before the first return:
> 
>     # Sort the diff chunks by filename, then old linenumber
>     @diffs = sort { $a->{filename} cmp $b->{filename} ||
> $a->{old_linenumber} <=> $b->{old_linenumber} } @diffs;
>  
> Would it make sense to make this a configurable feature?

I can imagine this could be useful for large reviews.  Rather than 
making this a configurable feature (codestriker.conf is also quite large 
and complex), it might be useful to have a link instead on the view 
topic page above the list of files, for example:

Download topic text | ... | Tab width ... | Sort by filename

Clicking on the sort by filename link will set a CGI parameter, which 
will then execute code similar to what you have, but this would be in 
ViewTopic.pm over the list of delta objects.  That way, a reviewer can 
choose at runtime which way they'd prefer to see the list of files 
presented.

What do you think?

Cheers,
David