Re: [Codestriker-user] Need help finding where to change table headers
Brought to you by:
sits
|
From: Jason R. <jre...@ya...> - 2006-03-07 19:56:36
|
Hi, I believe that the code in question is in lib/codestriker/html/Render.pm. Because of the complexity of the diff rendering it is not controlled by a template. It should be easy to deal with this. If you make it generic, please consider sending David a patch. Thanks Jason. --- Jay Dickon Glanville <dic...@gm...> wrote: > Hello all. > > We're testing out CodeStriker and finding it useful. However, there > are one or two minor UI issues that we'd like to modify. The major > one is how the tables are laid out when viewing a topic. > > You see, the problem is that our file path names can be rather long > (over 120 characters). As the filename is part of the HTML table > showing the diffs in the topics, these long names can cause the table > to get completely out of proportion. Have a look at the table below: > > +--------------------------------------+---------+ > | /really/really/really/long/file/name | top | > +--+--------------------------------+--+---------+ > |09| code code code |09| mod code| > |10| code code code |10| mod code| > |11| code code code |11| mod code| > +--+--------------------------------+--+---------+ > > (I don't know if this will look right on your email reader, but if you > view it in mono-spaced font, it should be alright). > > What's happening is that the diffs table is split into 4 columns: > source line number and text, target line number and text. The > filename is told to span the first three columns. This causes the > third and forth columns to be pushed off the screen. > > If I could find the place in CodeStriker that generates the HTML for > the diff tables, then I'd like to make some minor modifications: > either push the filename outside of the table (on top, probably), or > to have the filename span 4 columns. > > Which module is responsible for generating the diff tables? Is there > a particular method I should be looking at? > > Thanks > > JDG > > > -- > Jay Dickon Glanville > > > ------------------------------------------------------- > This SF.Net email is sponsored by xPML, a groundbreaking scripting language > that extends applications into web and mobile media. Attend the live webcast > and join the prime developer group breaking into this new coding territory! > http://sel.as-us.falkag.net/sel?cmd=lnk&kid0944&bid$1720&dat1642 > _______________________________________________ > Codestriker-user mailing list > Cod...@li... > https://lists.sourceforge.net/lists/listinfo/codestriker-user > __________________________________________________ Do You Yahoo!? Tired of spam? Yahoo! Mail has the best spam protection around http://mail.yahoo.com |