[Codestriker-user] code reviewing new files
Brought to you by:
sits
Menu
▾
▴
[Codestriker-user] code reviewing new files
|
From: Tom F. <Tom...@de...> - 2005-07-08 16:21:40
|
Let me first start by saying that codestriker is an awesome tool. Many thanks to David and anyone else who has contributed to making it some helpful. This tool has been very effective to enable the tracking of changes to existing files (i.e. 1 version already in source control), especially given it's integration with p4 and bugzilla (both of which we use). One thing that I have not been able to figure out is: how can I include "new" files (i.e. file only exists on client, and have run p4 add) into the code review process? I have a little script that the users run on a p4 changelist, which produces the diffs (between the client and the depot), but the output of this does not include any information about new files. When performing a code review, reviewers will need to be able to see all of the code in order to adequately understand the logic. I'm hoping that I am missing something easy here, so I just wanted to check with you. Thanks again for the help. Tom Tom Fenstermacher | Senior Director, Engineering DemandTec, Inc. | 1 Circle Star Way, Suite 200 | San Carlos, CA 94070 tel | +1.650.226.4628 cell | +1.650.814.4062 fax | +1.650.556.1190=0D www.demandtec.com <html> <body> <span style= =3D"font-size:8.0pt;font-family:Arial">------------------------------------= ---------------------------------------------------------------------------= ------------------------------</span> <span style=3D"font-size:8.0pt;font-family:Arial">DEMANDTEC EMAIL= NOTICE:</span> <p><span style=3D"font-size:8.0pt;font-family:Arial">NOTICE: This email= transmission and all attached files contain information intended for the= designated individual or entity to whom it is addressed and may contain= information that is proprietary, privileged and/or exempt from disclosure= under applicable law. If you are not the intended recipient or an= employee or agent responsible for delivering this message to the intended= recipient, you are hereby notified that any dissemination, distribution,= copying, or other use of this email or its attachments is strictly= prohibited. If you have received this email in error, please notify the= sender immediately by replying to this message and please delete the= original message without making any copies.</span> <p><span style=3D"font-size:8.0pt;font-family:Arial">WARNING: Computer= viruses can be transmitted via email. The recipient should check this= email and any attachments for the presence of viruses. Although we have= taken reasonable precautions to ensure that this email and all attachments= are free from viruses, we accept no liability for any loss or damage= arising from the use of this email or its attachments.</span> </body> </html> |
