RE: [Codestriker-user] Feature request

[Kelly F. H. <kf...@mq...>]

> -----Original Message-----
> From: David Sitsky [mailto:si...@us...]
> Sent: Tuesday, February 10, 2004 4:24 PM
> To: Kelly F. Hickel; Matthew Hailstone; codestriker-
> us...@li...
> Subject: Re: [Codestriker-user] Feature request
>=20
>=20
> > > The basic message is unreviewed code should never be committed to
a
> > > "public" branch that other developers are using.
> >
> > David,
> > 	While I (in theory) agree with your last statement, we do have
> > multiple developers working on projects (not always, but often), and
so,
> > they do share a branch.  They are fully authorized to beat each
other
> > with a wet noodle if one of them breaks the other's code (;>), but
it
> > does happen.  We do the reviews at the end, and sometimes the
reviews
> > cause changes, so we need to review it again, requiring a new
> > codestriker topic, instead of just updating the existing one.
>=20
> Ok, but in terms of reviewing code going into the main branch, you are
> happy to review it as an ordinary diff file?
>=20
> What Matthew is proposing is to create a diff file that contains
separate
> sections for each developer.

Ahh, I missed that.  No, what I want (which of course, translates to
"the right thing" ;>) is to see all the chages on the branch rolled into
one review screen.  Ideally, each time I visited it, it would refresh to
the latest set of changes on the branch.

>=20
> --
> Cheers,
> David

See ya!
-Kelly