RE: [Codestriker-user] Feature request

[Matthew H. <mat...@wa...>]

> Ok, but in terms of reviewing code going into the main=20
> branch, you are=20
> happy to review it as an ordinary diff file?
>=20

Correct. Doing a diff on a modified file, producing the unified diff
output and redirecting that output to a file, then uploading that file
to a topic in Codestriker should accomplish this.

> What Matthew is proposing is to create a diff file that=20
> contains separate=20
> sections for each developer.
>=20

Your comment about a "diff file that contains separate sections for each
developer" concerns me though.

Basically, the only changes that I see that Codestriker would have to
make is how it parses the uploaded diff file.

Currently each developer needs to:
- Create a diff file
- Create a Codestriker topic (upload their own diff file)

This would remain the same with my scenario. The only difference would
be that the diff file uploaded in our scenario would contain multiple
entries of the same file with different revision diffs.

Index: append.test
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
RCS file: /cvsrep/test/append.test,v
retrieving revision 1.1
diff -u -r1.1 append.test
--- append.test	6 Feb 2004 23:01:29 -0000	1.1
+++ append.test	6 Feb 2004 23:02:32 -0000
@@ -1,7 +1,7 @@
 #This is a test
 test =3D 0
 #To see how to append
-append =3D 0
+append =3D 1
 #Differential information from different revisions
 diffs =3D 0
 #Into one diff file
Index: append.test
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
RCS file: /cvsrep/test/append.test,v
retrieving revision 1.3
diff -u -r1.3 append.test
--- append.test	6 Feb 2004 23:04:49 -0000	1.3
+++ append.test	6 Feb 2004 23:06:27 -0000
@@ -5,4 +5,4 @@
 #Differential information from different revisions
 diffs =3D 1
 #Into one diff file
-file =3D 0
+file =3D 1

When the diff file is uploaded currently, the 1.3 diff is put under the
1.1 listing of the "append.test" file.

I am suggesting that when the diff file is uploaded and parsed, that 2
listings are created for the "append.test" file (one for each occurrence
in the diff file which will be different revision diffs).

Each developer would still have to create their own diff file and create
their own Codestriker topic.

BTW, this has been a good exercise for me to evaluate myself in how well
I'm communicating the problem.
I hope I'm making more sense and not nonsense.

Thanks! :)
Matthew=20
 =20
*************************************=20
This e-mail may contain privileged or confidential material intended for =
the named recipient only.=20
If you are not the named recipient, delete this message and all =
attachments.=20
Unauthorized reviewing, copying, printing, disclosing, or otherwise =
using information in this e-mail is prohibited.=20
We reserve the right to monitor e-mail sent through our network. =20
*************************************=20