RE: [Codestriker-user] Feature request

[Matthew H. <mat...@wa...>]

David,

I understand your suggestion. I agree with you that on the whole, code
should be reviewed before committed. Unfortunately, I am still faced
with the problem because other managers do not agree with that
philosophy in all cases. Most of the time that will be the case, but
because our processes are more time driven than event driven I'm coming
up towards a brick wall with the scenario I described earlier. I am
really excited about incorporating CodeStriker into our process, and
except for this problem, everything is really going well. :)

Here are the diff files that would be created in my scenario and my
proposal:

- Developer 1's diff file (developer1.diff) should look like the
following:

Index: append.test
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
RCS file: /cvsrep/test/append.test,v
retrieving revision 1.1
diff -u -r1.1 append.test
--- append.test	6 Feb 2004 23:01:29 -0000	1.1
+++ append.test	6 Feb 2004 23:02:32 -0000
@@ -1,7 +1,7 @@
 #This is a test
 test =3D 0
 #To see how to append
-append =3D 0
+append =3D 1
 #Differential information from different revisions
 diffs =3D 0
 #Into one diff file
Index: append.test
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
RCS file: /cvsrep/test/append.test,v
retrieving revision 1.3
diff -u -r1.3 append.test
--- append.test	6 Feb 2004 23:04:49 -0000	1.3
+++ append.test	6 Feb 2004 23:06:27 -0000
@@ -5,4 +5,4 @@
 #Differential information from different revisions
 diffs =3D 1
 #Into one diff file
-file =3D 0
+file =3D 1

- Developer 2's diff file (developer2.diff) should look like the
following:

Index: append.test
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
RCS file: /cvsrep/test/append.test,v
retrieving revision 1.2
diff -u -r1.2 append.test
--- append.test	6 Feb 2004 23:03:27 -0000	1.2
+++ append.test	6 Feb 2004 23:03:53 -0000
@@ -3,6 +3,6 @@
 #To see how to append
 append =3D 1
 #Differential information from different revisions
-diffs =3D 0
+diffs =3D 1
 #Into one diff file
 file =3D 0
Index: append.test
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
RCS file: /cvsrep/test/append.test,v
retrieving revision 1.4
diff -u -r1.4 append.test
--- append.test	6 Feb 2004 23:05:27 -0000	1.4
+++ append.test	6 Feb 2004 23:05:34 -0000
@@ -1,5 +1,5 @@
 #This is a test
-test =3D 0
+test =3D 1
 #To see how to append
 append =3D 1
 #Differential information from different revisions

- Now that both tasks have been completed, both developers would like to
have each of their individual work reviewed.

- Each developer creates a separate CodeStriker topic, and
uploads/attaches their respective diff files.

<Problem:> When a topic is created, only a single file entry is created
for the "Contents:" list which is associated with the first encounter of
the filename in the uploaded diff file. (i.e. Index: append.test)
Subsequent entries of the same file are not associated with their
respective revisions. All subsequent diff entries for an identified file
entry is associated with the revision of the first encountered file
entry. The "Parallel" and "non-Parallel?" views feature is also broken
from this kind of diff file structure.

<Possible Solution:>When parsing the uploaded diff file, create a new
entry in the "Contents:" list for each file entry encountered in the
diff file. This should also preserve revisioning and maintain the
current "Parallel" and non-"Parallel" view functionality.




If you try these kind of diff files, do you see the same problems
happening?



Thanks, :)

Matthew=20
 =20
*************************************=20
This e-mail may contain privileged or confidential material intended for =
the named recipient only.=20
If you are not the named recipient, delete this message and all =
attachments.=20
Unauthorized reviewing, copying, printing, disclosing, or otherwise =
using information in this e-mail is prohibited.=20
We reserve the right to monitor e-mail sent through our network. =20
*************************************=20