RE: [Codestriker-user] Feature request

[Kelly F. H. <kf...@mq...>]

> -----Original Message-----
> From: David Sitsky [mailto:si...@us...]
> Sent: Tuesday, February 10, 2004 4:16 AM
> To: Matthew Hailstone; cod...@li...
> Subject: Re: [Codestriker-user] Feature request
>=20
> > - Now that both tasks have been completed, both developers would
like to
> > have each of their individual work reviewed.
>=20
> This is the problem.  Codestriker is designed to be a "pre-commit"
step.
>=20
> The usual scenario with development teams is that unreviewed code is
_not_
> allowed to be committed into the CVS repository.  Once code has been
> reviewed, then the developer is free to commit it in.
>=20
> The motivation for this is that a bad commit can impact the whole
> development
> team, resulting in potentially a lot of wasted time for bad commits.


Hi David,
	Just FYI, we don't do development this way, nor does any
development organization that I've been a part of for the last 20 years.
We do projects in branches, have the branches reviewed, do unit test,
THEN merge it to the main line of development.  We want our developers
to be able to do a commit at any time (and urge them to do it at least
daily) to prevent mishaps due to power outages, drive failure, etc.
This has paid off more than once!  The other issue arises when you're
working on a change that affects several different platforms (aix,
solaris and windows for instance), you need to be able to commit, so
that you can check the code out on the other machines to do unit
testing.

-Kelly

>=20
> In your scenario, there should be no commits by developer 1 or 2.
Once
> they
> have finished their "work", then they produce a "cvs diff" which is
then
> reviewed in Codestriker.
>=20
> There is no problem with both reviewers doing this in parallel - CVS
is
> designed to handle this merges and so forth.
>=20
> The challenge is to define sensible units of work, which aren't too
large
> to
> review, but software teams become very experienced at doing this very
> quickly.
>=20
> Cheers,
> David
>=20
>=20
> -------------------------------------------------------
> The SF.Net email is sponsored by EclipseCon 2004
> Premiere Conference on Open Tools Development and Integration
> See the breadth of Eclipse activity. February 3-5 in Anaheim, CA.
> http://www.eclipsecon.org/osdn
> _______________________________________________
> Codestriker-user mailing list
> Cod...@li...
> https://lists.sourceforge.net/lists/listinfo/codestriker-user