Re: [Codestriker-user] Break into horizontal scrolling panes ?

[Dean A. <dea...@pa...>]

I managed to solve item (3) on my own. If the old or new source line is empty (has an empty line number), I apply an un-linked "0" w/ white color so its invisible. That forces the table row layout to the fixed font size wo/ displaying anything. Fixed version attached.

Again, its not pretty, but does get the job done. This is starting to look acceptable to my users; item (1) should be simple...item (2) is a bit more difficult.

Dean Arnold
ParAccel, Inc.

-----Original Message-----
From: Dean Arnold 
Sent: Thursday, October 07, 2010 5:58 PM
To: 'David Sitsky'
Cc: cod...@li...
Subject: RE: [Codestriker-user] Break into horizontal scrolling panes ?

I've managed to make progress (see attachment). Its not a pretty hack, but its getting close to what I'm after. Fwiw, I've only tested w/ FF and chrome so far. As stated before, I don't know that this will ever work w/ IE (at least, not wo/ major JS hackery...and since I avoid the blue E like plague, I call "not it")

Other gotchas:

1. It probably won't work as is w/ "view all files"; that can probably be fixed by a bit more JS (A separate set of panes for each file, and installing each set of pane's ID's into the scrollbar handler) 2. The sizing of the panes is static; I need to JS up the window dimensions and adjust accordingly 3. Empty lines in one pane are smaller height than non-empty lines in the other pane, which causes gradual misalignment between the panes. I'm guessing a CSS adjustment is needed to get adjacent rows in left and right tables to always be the same height.

Any ideas how to deal w/ item (3) ? Maybe empty lines need a class definition to match ?

Dean Arnold
ParAccel, Inc.

-----Original Message-----
From: David Sitsky [mailto:dav...@gm...]
Sent: Monday, September 27, 2010 11:04 PM
To: Dean Arnold
Cc: cod...@li...
Subject: Re: [Codestriker-user] Break into horizontal scrolling panes ?

> However, I'm not certain where to make the incision to inject this into the templates. Its going to add a div around the tables used for the old/new sources, and adds a bit of JS.

Have a look at viewdeltas.html.tmpl, which goes through all the deltas and creates the tables.

> Question: will the delta view always pad the shorter file to the same # of lines as the longer ? This hack seems to handle different file sizes OK, but to be usable both panes have to have vertical scrollbars; whereas if both are the same length, then the vertical scroll can be hidden on the left (or the right) pane.

They should be the same height - blank lines are inserted.

Cheers,
David