[Codestriker-commits] CVS update: codestriker CHANGELOG

[<si...@us...>]

  User: sits    
  Date: 06/06/08 20:20:03

  Modified:    lib/Codestriker/Model Comment.pm
               .        CHANGELOG
  Log:
  * Defining new entries in $comment_state_metrics in codestriker.conf
    could not be used for existing topics.  This has now been fixed.
  
  
  
  Index: Comment.pm
  ===================================================================
  RCS file: /cvsroot/codestriker/codestriker/lib/Codestriker/Model/Comment.pm,v
  retrieving revision 1.22
  retrieving revision 1.23
  diff -u -r1.22 -r1.23
  --- Comment.pm	26 May 2006 05:42:49 -0000	1.22
  +++ Comment.pm	9 Jun 2006 03:20:02 -0000	1.23
  @@ -412,12 +412,7 @@
   			     'modified_ts = ? ' .
   			     'WHERE id = ?');
   
  -    my $update_metrics =
  -	$dbh->prepare_cached('UPDATE commentstatemetric SET value = ? ' .
  -			     'WHERE id = ? AND name = ?');
  -
  -    my $success = defined $select_comments && defined $update_comments
  -	&& defined $update_metrics;
  +    my $success = defined $select_comments && defined $update_comments;
       my $rc = $Codestriker::OK;
   
       # Retrieve the current comment data.
  @@ -443,15 +438,17 @@
   	$rc = $Codestriker::STALE_VERSION;
       }
   
  -    # Now update the version number for ocmmentstate, and the metric
  -    # record itself.
  +    # Now update the version number for commentstate.
       $self->{version} = $self->{version} + 1;
       $self->{metrics}->{$metric_name} = $metric_value;
       $self->{modified_ts} = Codestriker->format_timestamp($timestamp);
       $success &&= $update_comments->execute($self->{version},
   					   $timestamp,
   					   $id);
  -    $success &&= $update_metrics->execute($metric_value, $id, $metric_name);
  +
  +    # Now update the commentstatemetric row for this metric.
  +    my $metrics = [ { name => $metric_name, value => $metric_value } ];
  +    update_comment_metrics($id, $metrics, $dbh);
       
       Codestriker::DB::DBI->release_connection($dbh, $success);
       
  
  
  
  
  
  Index: CHANGELOG
  ===================================================================
  RCS file: /cvsroot/codestriker/codestriker/CHANGELOG,v
  retrieving revision 1.188
  retrieving revision 1.189
  diff -u -r1.188 -r1.189
  --- CHANGELOG	7 Jun 2006 00:00:57 -0000	1.188
  +++ CHANGELOG	9 Jun 2006 03:20:03 -0000	1.189
  @@ -66,6 +66,9 @@
     case insensitive to account for the different casing returned by the
     Window clients: Cygwin and CvsNT.
   
  +* Defining new entries in $comment_state_metrics in codestriker.conf
  +  could not be used for existing topics.  This has now been fixed.
  +
   Version 1.9.1
   
   * Correct problem introduced in 1.9.0 release where the email address