[Codestriker-commits] CVS update: codestriker/template/en/default editcomment.html.tmpl

[<si...@us...>]

  Created Codestriker topic at:
  http://codestriker.sourceforge.net/cgi-bin/codestriker.pl?topic=3167705&action=view

  User: sits    
  Date: 05/01/23 13:05:46

  Modified:    .        CHANGELOG
               lib      Codestriker.pm
               lib/Codestriker/Action EditComment.pm
               template/en/default editcomment.html.tmpl
  Log:
  * Added a "add other reviewers" link next to the Cc: field in the "add
    comment" screen.  This allows the comment author to easily Cc all
    the other reviewers of the topic, for important comments that needs
    to be sent to all reviewers.
  
  
  
  Index: CHANGELOG
  ===================================================================
  RCS file: /cvsroot/codestriker/codestriker/CHANGELOG,v
  retrieving revision 1.158
  retrieving revision 1.159
  diff -u -r1.158 -r1.159
  --- CHANGELOG	21 Dec 2004 23:02:51 -0000	1.158
  +++ CHANGELOG	23 Jan 2005 21:05:25 -0000	1.159
  @@ -14,6 +14,11 @@
   * Added RSS support, so that the topic list screen now has an
     equivalent RSS view.  From Jason Remillard.
   
  +* Added a "add other reviewers" link next to the Cc: field in the "add
  +  comment" screen.  This allows the comment author to easily Cc all
  +  the other reviewers of the topic, for important comments that needs
  +  to be sent to all reviewers.
  +
   Version 1.8.5
   
   * Complete support for VSS repositories.  Topics linked to a VSS
  
  
  
  
  
  Index: Codestriker.pm
  ===================================================================
  RCS file: /cvsroot/codestriker/codestriker/lib/Codestriker.pm,v
  retrieving revision 1.68
  retrieving revision 1.69
  diff -u -r1.68 -r1.69
  --- Codestriker.pm	21 Dec 2004 23:02:54 -0000	1.68
  +++ Codestriker.pm	23 Jan 2005 21:05:28 -0000	1.69
  @@ -27,7 +27,7 @@
   	      );
   
   # Version of Codestriker.
  -$Codestriker::VERSION = "1.8.5";
  +$Codestriker::VERSION = "1.8.6";
   
   # Default title to display on each Codestriker screen.
   $Codestriker::title = "Codestriker $Codestriker::VERSION";
  
  
  
  
  
  Index: EditComment.pm
  ===================================================================
  RCS file: /cvsroot/codestriker/codestriker/lib/Codestriker/Action/EditComment.pm,v
  retrieving revision 1.10
  retrieving revision 1.11
  diff -u -r1.10 -r1.11
  --- EditComment.pm	17 Aug 2004 22:28:46 -0000	1.10
  +++ EditComment.pm	23 Jan 2005 21:05:28 -0000	1.11
  @@ -141,6 +141,12 @@
       $vars->{'fn'} = $fn;
       $vars->{'new'} = $new;
   
  +    # Add the "other" reviewers, which is all the reviewers without the
  +    # address set in $email.
  +    my @reviewers = split ', ', $topic->{reviewers};
  +    @reviewers = grep !/^$email$/, @reviewers;
  +    $vars->{'reviewers'} = \@reviewers;
  +
       # Display the output via the template.
       my $template = Codestriker::Http::Template->new("editcomment");
       $template->process($vars);
  
  
  
  
  
  Index: editcomment.html.tmpl
  ===================================================================
  RCS file: /cvsroot/codestriker/codestriker/template/en/default/editcomment.html.tmpl,v
  retrieving revision 1.13
  retrieving revision 1.14
  diff -u -r1.13 -r1.14
  --- editcomment.html.tmpl	24 Nov 2004 11:18:09 -0000	1.13
  +++ editcomment.html.tmpl	23 Jan 2005 21:05:29 -0000	1.14
  @@ -91,7 +91,17 @@
     return true;
   }
   
  -</SCRIPT>
  +// Called when the "add other reviewers" link is pressed, which adds all
  +// reviewers to the Cc: field.
  +function add_other_reviewers() {
  +  [% FOREACH reviewer = reviewers %]
  +    if (document.add_comment.comment_cc.value != '') {
  +        document.add_comment.comment_cc.value += ', ';
  +    }
  +    document.add_comment.comment_cc.value += "[% reviewer %]";
  +  [% END %]
  +}
  +</Script>
   
   [%# Screen for the add comment form. #%]
   
  @@ -181,7 +191,7 @@
     <TD></TD>
    </TR>
    <TR>
  -  <TD>Cc: </TD>
  +  <TD>Cc: <FONT SIZE="-1"><A HREF="javascript:add_other_reviewers();">(add other reviewers)</A></FONT> </TD>
     <TD>
        <INPUT TYPE="text" NAME="comment_cc" SIZE=50 MAXLENGTH=150>
     </TD>