[Codestriker-commits] CVS update: codestriker codestriker.conf CHANGELOG

[<si...@us...>]

  User: sits    
  Date: 08/09/08 03:40:31

  Modified:    lib/Codestriker/Http Method.pm Dispatcher.pm
               .        codestriker.conf CHANGELOG
  Log:
  Support older-style deployments here no admin users exist.
  
  
  
  Index: Method.pm
  ===================================================================
  RCS file: /cvsroot/codestriker/codestriker/lib/Codestriker/Http/Method.pm,v
  retrieving revision 1.8
  retrieving revision 1.9
  diff -u -r1.8 -r1.9
  --- Method.pm	8 Sep 2008 10:19:51 -0000	1.8
  +++ Method.pm	8 Sep 2008 10:40:30 -0000	1.9
  @@ -46,9 +46,11 @@
       return undef;
   }
   
  -# Indicates that this method requires authentication.
  +# Indicates that this method requires authentication.  If an admin
  +# user has been specified in codestriker.conf, then assume
  +# authentication is required.
   sub requires_authentication {
  -    return 1;
  +    return defined $Codestriker::admin_users;
   }
   
   # Indicates that this method can only be executed by an admin.
  
  
  
  
  
  Index: Dispatcher.pm
  ===================================================================
  RCS file: /cvsroot/codestriker/codestriker/lib/Codestriker/Http/Dispatcher.pm,v
  retrieving revision 1.15
  retrieving revision 1.16
  diff -u -r1.15 -r1.16
  --- Dispatcher.pm	8 Sep 2008 10:19:51 -0000	1.15
  +++ Dispatcher.pm	8 Sep 2008 10:40:30 -0000	1.16
  @@ -150,7 +150,8 @@
       }
   
       # Check if the method requires admin priviledges.
  -    if ($found_method->requires_admin() && !$user->{admin}) {
  +    if (defined $Codestriker::admin_users &&
  +        $found_method->requires_admin() && !$user->{admin}) {
           $http_output->error("This function requires admin access.");
           return;
       }
  
  
  
  
  
  Index: codestriker.conf
  ===================================================================
  RCS file: /cvsroot/codestriker/codestriker/codestriker.conf,v
  retrieving revision 1.106
  retrieving revision 1.107
  diff -u -r1.106 -r1.107
  --- codestriker.conf	6 Sep 2008 11:33:06 -0000	1.106
  +++ codestriker.conf	8 Sep 2008 10:40:30 -0000	1.107
  @@ -35,12 +35,12 @@
   
   # Email addresses of admin users for this installation.  Admin users
   # have unrestricted access to the system.  Non-admin users will not
  -# be able to create/edit/delete projects.  If no admin user is defined
  -# then no login system will be used, and all users will be effectively
  -# admin users.
  -$admin_users = [ 'dav...@gm...' ];
  +# be able to create/edit/delete projects or download the full
  +# system metric reports.  If this remains commented out, then no
  +# authentication will be required, and users have full access to the
  +# system.
  +#$admin_users = [ 'dav...@gm...' ];
   #$admin_users = [ 'dav...@gm...', 'si...@us...' ];
  -#$admin_users = [];
   
   # Location of the mailing host.  This is used when sending out codestriker
   # comments.
  @@ -109,10 +109,6 @@
   #$codestriker_css = 'codestriker.css';
   #$codestriker_css = 'codestriker-alternative.css';
   
  -# Indicate what style URLs to support.  The default is CGI-style URLs.  Set
  -# this value to 0 for "nicer" URLs. 
  -#$cgi_style = 1; 
  -
   # Valid repositories which may be selected at the create topic screen.
   # The order shown here is the order presented in the option list.  Most
   # deployments will only require a single repository to be specified.
  
  
  
  
  
  Index: CHANGELOG
  ===================================================================
  RCS file: /cvsroot/codestriker/codestriker/CHANGELOG,v
  retrieving revision 1.265
  retrieving revision 1.266
  diff -u -r1.265 -r1.266
  --- CHANGELOG	2 Sep 2008 06:33:57 -0000	1.265
  +++ CHANGELOG	8 Sep 2008 10:40:30 -0000	1.266
  @@ -3,6 +3,12 @@
   
   Version 1.9.7
   
  +* Introduced basic user authentication / authorisation into the
  +  system.  If the $admin_users configuration variable is specified
  +  in codestriker.conf, this contains a list of "admin" users.
  +  If defined, admin users are the only ones who can
  +  create/edit/delete projects.
  +	
   * Created another Subversion post-commit script which is an extension
     of the standard commit-email.pl script which ships with Subversion.
     The email sent also includes an additional line, which is the URL to