[Codestriker-commits] CVS update: codestriker/lib/Codestriker/Http/Method CreateTopicMethod.pm Upd
Brought to you by:
sits
Menu
▾
▴
[Codestriker-commits] CVS update: codestriker/lib/Codestriker/Http/Method CreateTopicMethod.pm UpdateTopicMetricsMethod.pm CreateCommentMethod.pm UpdateTopicPropertiesMethod.pm ViewTopicFileMethod.pm
User: sits
Date: 08/08/31 05:30:16
Modified: t/Http/Method update-topic-metrics.t view-topic-text.t
add-topic.t view-topic-properties.t
update-project.t list-topics.t add-comment.t
edit-project.t view-topic-comments.t
update-comment-metrics.t update-topic-states.t
view-topic-metrics.t update-topic-properties.t
view-topic-file.t create-topic.t
download-topic-text.t create-comment.t
lib/Codestriker/Http/Method CreateTopicMethod.pm
UpdateTopicMetricsMethod.pm CreateCommentMethod.pm
UpdateTopicPropertiesMethod.pm
ViewTopicFileMethod.pm
Log:
Updated unit tests to be working again under new URL scheme.
Index: update-topic-metrics.t
===================================================================
RCS file: /cvsroot/codestriker/codestriker/t/Http/Method/update-topic-metrics.t,v
retrieving revision 1.1
retrieving revision 1.2
diff -u -r1.1 -r1.2
--- update-topic-metrics.t 29 Aug 2008 10:49:01 -0000 1.1
+++ update-topic-metrics.t 31 Aug 2008 12:30:05 -0000 1.2
@@ -18,7 +18,7 @@
my $url_nice = Codestriker::Http::Method::UpdateTopicMetricsMethod->new($mock_query, 0);
is($url_cgi->url(topicid => 1234, projectid => 10),
- $mock_query->url() . '?action=submit_edit_topic_metrics&topic=1234',
+ $mock_query->url() . '?action=edit_topic_metrics',
"Update topic metrics URL CGI syntax");
is($url_nice->url(topicid => 1234, projectid => 10),
@@ -28,13 +28,14 @@
# Check that the parameters extracted correctly.
my $mock_http_input = Test::MockObject->new();
$mock_http_input->{query} = $mock_query;
+$mock_http_input->mock('extract_cgi_parameters', sub { return undef; });
$mock_query->mock('path_info',
sub {
- return $mock_query->url() . '/project/10/topic/1234/metrics/update';
+ return '/project/10/topic/1234/metrics/update';
});
$mock_query->mock('param', sub { return undef; });
$url_nice->extract_parameters($mock_http_input);
is ($mock_http_input->{projectid}, "10", "project nice URL parameter extraction");
-is ($mock_http_input->{topicid}, "1234", "topicid nice URL parameter extraction");
+is ($mock_http_input->{topic}, "1234", "topicid nice URL parameter extraction");
\ No newline at end of file
Index: view-topic-text.t
===================================================================
RCS file: /cvsroot/codestriker/codestriker/t/Http/Method/view-topic-text.t,v
retrieving revision 1.2
retrieving revision 1.3
diff -u -r1.2 -r1.3
--- view-topic-text.t 27 Aug 2008 08:43:10 -0000 1.2
+++ view-topic-text.t 31 Aug 2008 12:30:05 -0000 1.3
@@ -46,13 +46,12 @@
# Check that the parameters extracted correctly.
my $mock_http_input = Test::MockObject->new();
$mock_http_input->{query} = $mock_query;
+$mock_http_input->mock('extract_cgi_parameters', sub { return undef; });
$mock_query->mock('path_info',
- sub {
- return $mock_query->url() . '/project/10/topic/1234/text#2|3|1';
- });
+ sub { '/project/10/topic/1234/text#2|3|1'; });
$mock_query->mock('param', sub { return undef; });
$url_nice->extract_parameters($mock_http_input);
is ($mock_http_input->{projectid}, "10", "project nice URL parameter extraction");
-is ($mock_http_input->{topicid}, "1234", "topicid nice URL parameter extraction");
+is ($mock_http_input->{topic}, "1234", "topicid nice URL parameter extraction");
\ No newline at end of file
Index: add-topic.t
===================================================================
RCS file: /cvsroot/codestriker/codestriker/t/Http/Method/add-topic.t,v
retrieving revision 1.1
retrieving revision 1.2
diff -u -r1.1 -r1.2
--- add-topic.t 11 Aug 2008 22:32:38 -0000 1.1
+++ add-topic.t 31 Aug 2008 12:30:05 -0000 1.2
@@ -28,9 +28,10 @@
# Check that the parameters extracted correctly.
my $mock_http_input = Test::MockObject->new();
$mock_http_input->{query} = $mock_query;
+$mock_http_input->mock('extract_cgi_parameters', sub { return undef; });
$mock_query->mock('path_info',
sub {
- return $mock_query->url() . '/project/10/topics/add';
+ return '/project/10/topics/add';
});
$mock_query->mock('param', sub { return undef; });
$url_nice->extract_parameters($mock_http_input);
Index: view-topic-properties.t
===================================================================
RCS file: /cvsroot/codestriker/codestriker/t/Http/Method/view-topic-properties.t,v
retrieving revision 1.2
retrieving revision 1.3
diff -u -r1.2 -r1.3
--- view-topic-properties.t 18 Aug 2008 11:19:59 -0000 1.2
+++ view-topic-properties.t 31 Aug 2008 12:30:05 -0000 1.3
@@ -28,13 +28,14 @@
# Check that the parameters extracted correctly.
my $mock_http_input = Test::MockObject->new();
$mock_http_input->{query} = $mock_query;
+$mock_http_input->mock('extract_cgi_parameters', sub { return undef; });
$mock_query->mock('path_info',
sub {
- return $mock_query->url() . '/project/10/topic/1234/properties/view';
+ return '/project/10/topic/1234/properties/view';
});
$mock_query->mock('param', sub { return undef; });
$url_nice->extract_parameters($mock_http_input);
is ($mock_http_input->{projectid}, "10", "project nice URL parameter extraction");
-is ($mock_http_input->{topicid}, "1234", "topicid nice URL parameter extraction");
+is ($mock_http_input->{topic}, "1234", "topicid nice URL parameter extraction");
\ No newline at end of file
Index: update-project.t
===================================================================
RCS file: /cvsroot/codestriker/codestriker/t/Http/Method/update-project.t,v
retrieving revision 1.1
retrieving revision 1.2
diff -u -r1.1 -r1.2
--- update-project.t 27 Aug 2008 08:43:10 -0000 1.1
+++ update-project.t 31 Aug 2008 12:30:05 -0000 1.2
@@ -25,9 +25,10 @@
# Check that the parameters extracted correctly.
my $mock_http_input = Test::MockObject->new();
$mock_http_input->{query} = $mock_query;
+$mock_http_input->mock('extract_cgi_parameters', sub { return undef; });
$mock_query->mock('path_info',
sub {
- return $mock_query->url() . '/admin/project/45/update';
+ return '/admin/project/45/update';
});
$mock_query->mock('param', sub { return undef; });
$url_nice->extract_parameters($mock_http_input);
Index: list-topics.t
===================================================================
RCS file: /cvsroot/codestriker/codestriker/t/Http/Method/list-topics.t,v
retrieving revision 1.1
retrieving revision 1.2
diff -u -r1.1 -r1.2
--- list-topics.t 10 Aug 2008 12:18:42 -0000 1.1
+++ list-topics.t 31 Aug 2008 12:30:05 -0000 1.2
@@ -60,9 +60,10 @@
# Check that the parameters extracted correctly.
my $mock_http_input = Test::MockObject->new();
$mock_http_input->{query} = $mock_query;
+$mock_http_input->mock('extract_cgi_parameters', sub { return undef; });
$mock_query->mock('path_info',
sub {
- return $mock_query->url() . '/topics/list/author/sits/reviewer/engineering' .
+ return '/topics/list/author/sits/reviewer/engineering' .
'/bugid/10%2C20/title/Example%20title/comment/Critical%20Error' .
'/state/0/project/10%2C30';
});
Index: add-comment.t
===================================================================
RCS file: /cvsroot/codestriker/codestriker/t/Http/Method/add-comment.t,v
retrieving revision 1.2
retrieving revision 1.3
diff -u -r1.2 -r1.3
--- add-comment.t 18 Aug 2008 11:11:36 -0000 1.2
+++ add-comment.t 31 Aug 2008 12:30:05 -0000 1.3
@@ -30,14 +30,15 @@
# Check that the parameters extracted correctly.
my $mock_http_input = Test::MockObject->new();
$mock_http_input->{query} = $mock_query;
+$mock_http_input->mock('extract_cgi_parameters', sub { return undef; });
$mock_query->mock('path_info',
sub {
- return $mock_query->url() . '/project/10/topic/1234/comment/3|55|0/add';
+ return '/project/10/topic/1234/comment/3|55|0/add';
});
$mock_query->mock('param', sub { return undef; });
$url_nice->extract_parameters($mock_http_input);
is ($mock_http_input->{projectid}, "10", "projectid nice URL parameter extraction");
-is ($mock_http_input->{topicid}, "1234", "topicid nice URL parameter extraction");
+is ($mock_http_input->{topic}, "1234", "topicid nice URL parameter extraction");
is ($mock_http_input->{fn}, "3", "fn nice URL parameter extraction");
is ($mock_http_input->{line}, "55", "line nice URL parameter extraction");
is ($mock_http_input->{new}, "0", "new nice URL parameter extraction");
Index: edit-project.t
===================================================================
RCS file: /cvsroot/codestriker/codestriker/t/Http/Method/edit-project.t,v
retrieving revision 1.2
retrieving revision 1.3
diff -u -r1.2 -r1.3
--- edit-project.t 27 Aug 2008 08:43:10 -0000 1.2
+++ edit-project.t 31 Aug 2008 12:30:05 -0000 1.3
@@ -25,9 +25,10 @@
# Check that the parameters extracted correctly.
my $mock_http_input = Test::MockObject->new();
$mock_http_input->{query} = $mock_query;
+$mock_http_input->mock('extract_cgi_parameters', sub { return undef; });
$mock_query->mock('path_info',
sub {
- return $mock_query->url() . '/admin/project/45/edit';
+ return '/admin/project/45/edit';
});
$mock_query->mock('param', sub { return undef; });
$url_nice->extract_parameters($mock_http_input);
Index: view-topic-comments.t
===================================================================
RCS file: /cvsroot/codestriker/codestriker/t/Http/Method/view-topic-comments.t,v
retrieving revision 1.2
retrieving revision 1.3
diff -u -r1.2 -r1.3
--- view-topic-comments.t 31 Aug 2008 11:45:02 -0000 1.2
+++ view-topic-comments.t 31 Aug 2008 12:30:05 -0000 1.3
@@ -28,13 +28,14 @@
# Check that the parameters extracted correctly.
my $mock_http_input = Test::MockObject->new();
$mock_http_input->{query} = $mock_query;
+$mock_http_input->mock('extract_cgi_parameters', sub { return undef; });
$mock_query->mock('path_info',
sub {
- return $mock_query->url() . '/project/10/topic/1234/comments/list';
+ return '/project/10/topic/1234/comments/list';
});
$mock_query->mock('param', sub { return undef; });
$url_nice->extract_parameters($mock_http_input);
is ($mock_http_input->{projectid}, "10", "projectid nice URL parameter extraction");
-is ($mock_http_input->{topicid}, "1234", "topicid nice URL parameter extraction");
+is ($mock_http_input->{topic}, "1234", "topicid nice URL parameter extraction");
\ No newline at end of file
Index: update-comment-metrics.t
===================================================================
RCS file: /cvsroot/codestriker/codestriker/t/Http/Method/update-comment-metrics.t,v
retrieving revision 1.1
retrieving revision 1.2
diff -u -r1.1 -r1.2
--- update-comment-metrics.t 31 Aug 2008 11:45:02 -0000 1.1
+++ update-comment-metrics.t 31 Aug 2008 12:30:05 -0000 1.2
@@ -28,13 +28,14 @@
# Check that the parameters extracted correctly.
my $mock_http_input = Test::MockObject->new();
$mock_http_input->{query} = $mock_query;
+$mock_http_input->mock('extract_cgi_parameters', sub { return undef; });
$mock_query->mock('path_info',
sub {
- return $mock_query->url() . '/project/10/topic/1234/comments/update';
+ return '/project/10/topic/1234/comments/update';
});
$mock_query->mock('param', sub { return undef; });
$url_nice->extract_parameters($mock_http_input);
is ($mock_http_input->{projectid}, "10", "project nice URL parameter extraction");
-is ($mock_http_input->{topicid}, "1234", "topicid nice URL parameter extraction");
+is ($mock_http_input->{topic}, "1234", "topicid nice URL parameter extraction");
\ No newline at end of file
Index: update-topic-states.t
===================================================================
RCS file: /cvsroot/codestriker/codestriker/t/Http/Method/update-topic-states.t,v
retrieving revision 1.1
retrieving revision 1.2
diff -u -r1.1 -r1.2
--- update-topic-states.t 18 Aug 2008 22:11:06 -0000 1.1
+++ update-topic-states.t 31 Aug 2008 12:30:05 -0000 1.2
@@ -28,9 +28,10 @@
# Check that the parameters extracted correctly.
my $mock_http_input = Test::MockObject->new();
$mock_http_input->{query} = $mock_query;
+$mock_http_input->mock('extract_cgi_parameters', sub { return undef; });
$mock_query->mock('path_info',
sub {
- return $mock_query->url() . '/project/10/topic/update';
+ return '/project/10/topic/update';
});
$mock_query->mock('param', sub { return undef; });
$url_nice->extract_parameters($mock_http_input);
Index: view-topic-metrics.t
===================================================================
RCS file: /cvsroot/codestriker/codestriker/t/Http/Method/view-topic-metrics.t,v
retrieving revision 1.2
retrieving revision 1.3
diff -u -r1.2 -r1.3
--- view-topic-metrics.t 31 Aug 2008 11:45:02 -0000 1.2
+++ view-topic-metrics.t 31 Aug 2008 12:30:05 -0000 1.3
@@ -28,13 +28,14 @@
# Check that the parameters extracted correctly.
my $mock_http_input = Test::MockObject->new();
$mock_http_input->{query} = $mock_query;
+$mock_http_input->mock('extract_cgi_parameters', sub { return undef; });
$mock_query->mock('path_info',
sub {
- return $mock_query->url() . '/project/10/topic/1234/metrics/view';
+ return '/project/10/topic/1234/metrics/view';
});
$mock_query->mock('param', sub { return undef; });
$url_nice->extract_parameters($mock_http_input);
is ($mock_http_input->{projectid}, "10", "project nice URL parameter extraction");
-is ($mock_http_input->{topicid}, "1234", "topicid nice URL parameter extraction");
+is ($mock_http_input->{topic}, "1234", "topicid nice URL parameter extraction");
\ No newline at end of file
Index: update-topic-properties.t
===================================================================
RCS file: /cvsroot/codestriker/codestriker/t/Http/Method/update-topic-properties.t,v
retrieving revision 1.1
retrieving revision 1.2
diff -u -r1.1 -r1.2
--- update-topic-properties.t 18 Aug 2008 11:19:59 -0000 1.1
+++ update-topic-properties.t 31 Aug 2008 12:30:05 -0000 1.2
@@ -18,7 +18,7 @@
my $url_nice = Codestriker::Http::Method::UpdateTopicPropertiesMethod->new($mock_query, 0);
is($url_cgi->url(topicid => 1234, projectid => 10),
- $mock_query->url() . '?action=submit_edit_topic_properties&topic=1234',
+ $mock_query->url() . '?action=submit_edit_topic_properties',
"Update topic properties URL CGI syntax");
is($url_nice->url(topicid => 1234, projectid => 10),
@@ -28,13 +28,14 @@
# Check that the parameters extracted correctly.
my $mock_http_input = Test::MockObject->new();
$mock_http_input->{query} = $mock_query;
+$mock_http_input->mock('extract_cgi_parameters', sub { return undef; });
$mock_query->mock('path_info',
sub {
- return $mock_query->url() . '/project/10/topic/1234/properties/update';
+ return '/project/10/topic/1234/properties/update';
});
$mock_query->mock('param', sub { return undef; });
$url_nice->extract_parameters($mock_http_input);
is ($mock_http_input->{projectid}, "10", "project nice URL parameter extraction");
-is ($mock_http_input->{topicid}, "1234", "topicid nice URL parameter extraction");
+is ($mock_http_input->{topic}, "1234", "topicid nice URL parameter extraction");
\ No newline at end of file
Index: view-topic-file.t
===================================================================
RCS file: /cvsroot/codestriker/codestriker/t/Http/Method/view-topic-file.t,v
retrieving revision 1.1
retrieving revision 1.2
diff -u -r1.1 -r1.2
--- view-topic-file.t 10 Aug 2008 12:18:42 -0000 1.1
+++ view-topic-file.t 31 Aug 2008 12:30:05 -0000 1.2
@@ -30,14 +30,15 @@
# Check that the parameters extracted correctly.
my $mock_http_input = Test::MockObject->new();
$mock_http_input->{query} = $mock_query;
+$mock_http_input->mock('extract_cgi_parameters', sub { return undef; });
$mock_query->mock('path_info',
sub {
- return $mock_query->url() . '/project/10/topic/1234/file/3#3|55|0';
+ return '/project/10/topic/1234/file/3#3|55|0';
});
$mock_query->mock('param', sub { return undef; });
$url_nice->extract_parameters($mock_http_input);
is ($mock_http_input->{projectid}, "10", "projectid nice URL parameter extraction");
-is ($mock_http_input->{topicid}, "1234", "topicid nice URL parameter extraction");
+is ($mock_http_input->{topic}, "1234", "topicid nice URL parameter extraction");
is ($mock_http_input->{fn}, "3", "fn nice URL parameter extraction");
\ No newline at end of file
Index: create-topic.t
===================================================================
RCS file: /cvsroot/codestriker/codestriker/t/Http/Method/create-topic.t,v
retrieving revision 1.1
retrieving revision 1.2
diff -u -r1.1 -r1.2
--- create-topic.t 10 Aug 2008 12:18:42 -0000 1.1
+++ create-topic.t 31 Aug 2008 12:30:05 -0000 1.2
@@ -36,9 +36,10 @@
# Check that the parameters extracted correctly.
my $mock_http_input = Test::MockObject->new();
$mock_http_input->{query} = $mock_query;
+$mock_http_input->mock('extract_cgi_parameters', sub { return undef; });
$mock_query->mock('path_info',
sub {
- return $mock_query->url() . '/topics/create/obsoletes/45';
+ return '/topics/create/obsoletes/45';
});
$mock_query->mock('param', sub { return undef; });
$url_nice->extract_parameters($mock_http_input);
Index: download-topic-text.t
===================================================================
RCS file: /cvsroot/codestriker/codestriker/t/Http/Method/download-topic-text.t,v
retrieving revision 1.1
retrieving revision 1.2
diff -u -r1.1 -r1.2
--- download-topic-text.t 26 Aug 2008 22:18:51 -0000 1.1
+++ download-topic-text.t 31 Aug 2008 12:30:05 -0000 1.2
@@ -28,11 +28,12 @@
# Check that the parameters extracted correctly.
my $mock_http_input = Test::MockObject->new();
$mock_http_input->{query} = $mock_query;
+$mock_http_input->mock('extract_cgi_parameters', sub { return undef; });
$mock_query->mock('path_info',
sub {
- return $mock_query->url() . '/project/10/topic/1234/download';
+ return '/project/10/topic/1234/download';
});
$mock_query->mock('param', sub { return undef; });
$url_nice->extract_parameters($mock_http_input);
is ($mock_http_input->{projectid}, "10", "project nice URL parameter extraction");
-is ($mock_http_input->{topicid}, "1234", "topicid nice URL parameter extraction");
+is ($mock_http_input->{topic}, "1234", "topicid nice URL parameter extraction");
Index: create-comment.t
===================================================================
RCS file: /cvsroot/codestriker/codestriker/t/Http/Method/create-comment.t,v
retrieving revision 1.1
retrieving revision 1.2
diff -u -r1.1 -r1.2
--- create-comment.t 18 Aug 2008 11:11:36 -0000 1.1
+++ create-comment.t 31 Aug 2008 12:30:05 -0000 1.2
@@ -19,7 +19,7 @@
is($url_cgi->url(filenumber => 3, line => 55, new => 0, topicid => 1234,
projectid => 10, context => 3),
- $mock_query->url() . '?action=edit&fn=3&line=55&new=0&topic=1234&context=3',
+ $mock_query->url() . '?action=edit&topic=1234&fn=3&line=55&new=0&context=3',
"Create comment URL CGI syntax");
is($url_nice->url(filenumber => 3, line => 55, new => 0, topicid => 1234,
@@ -30,14 +30,15 @@
# Check that the parameters extracted correctly.
my $mock_http_input = Test::MockObject->new();
$mock_http_input->{query} = $mock_query;
+$mock_http_input->mock('extract_cgi_parameters', sub { return undef; });
$mock_query->mock('path_info',
sub {
- return $mock_query->url() . '/project/10/topic/1234/comment/3|55|0/create/context/3';
+ return '/project/10/topic/1234/comment/3|55|0/create/context/3';
});
$mock_query->mock('param', sub { return undef; });
$url_nice->extract_parameters($mock_http_input);
is ($mock_http_input->{projectid}, "10", "projectid nice URL parameter extraction");
-is ($mock_http_input->{topicid}, "1234", "topicid nice URL parameter extraction");
+is ($mock_http_input->{topic}, "1234", "topicid nice URL parameter extraction");
is ($mock_http_input->{fn}, "3", "fn nice URL parameter extraction");
is ($mock_http_input->{line}, "55", "line nice URL parameter extraction");
is ($mock_http_input->{new}, "0", "new nice URL parameter extraction");
Index: CreateTopicMethod.pm
===================================================================
RCS file: /cvsroot/codestriker/codestriker/lib/Codestriker/Http/Method/CreateTopicMethod.pm,v
retrieving revision 1.2
retrieving revision 1.3
diff -u -r1.2 -r1.3
--- CreateTopicMethod.pm 29 Aug 2008 10:48:57 -0000 1.2
+++ CreateTopicMethod.pm 31 Aug 2008 12:30:07 -0000 1.3
@@ -32,7 +32,6 @@
my $action = $http_input->{query}->param('action');
my $path_info = $http_input->{query}->path_info();
- print STDERR "Check path: $path_info\n";
if ($self->{cgi_style} && defined $action && $action eq "create") {
$http_input->extract_cgi_parameters();
return 1;
Index: UpdateTopicMetricsMethod.pm
===================================================================
RCS file: /cvsroot/codestriker/codestriker/lib/Codestriker/Http/Method/UpdateTopicMetricsMethod.pm,v
retrieving revision 1.2
retrieving revision 1.3
diff -u -r1.2 -r1.3
--- UpdateTopicMetricsMethod.pm 31 Aug 2008 11:45:03 -0000 1.2
+++ UpdateTopicMetricsMethod.pm 31 Aug 2008 12:30:07 -0000 1.3
@@ -20,7 +20,7 @@
my ($self, %args) = @_;
if ($self->{cgi_style}) {
- return $self->{url_prefix} . "?action=edit_topic_metrics&topic=$args{topicid}";
+ return $self->{url_prefix} . "?action=edit_topic_metrics";
} else {
confess "Parameter topicid missing" unless defined $args{topicid};
confess "Parameter projectid missing" unless defined $args{projectid};
@@ -38,7 +38,7 @@
return 1;
} elsif ($path_info =~ m{^/project/\d+/topic/\d+/metrics/update}) {
$self->_extract_nice_parameters($http_input,
- project => 'projectid', topic => 'topicid');
+ project => 'projectid', topic => 'topic');
return 1;
} else {
return 0;
Index: CreateCommentMethod.pm
===================================================================
RCS file: /cvsroot/codestriker/codestriker/lib/Codestriker/Http/Method/CreateCommentMethod.pm,v
retrieving revision 1.3
retrieving revision 1.4
diff -u -r1.3 -r1.4
--- CreateCommentMethod.pm 29 Aug 2008 10:48:57 -0000 1.3
+++ CreateCommentMethod.pm 31 Aug 2008 12:30:07 -0000 1.4
@@ -23,7 +23,7 @@
if ($self->{cgi_style}) {
return $self->{url_prefix} . "?action=edit&topic=$args{topicid}" .
- (defined $args{filenumber} && $args{filenumber} ne "" . "&fn=$args{filenumber}&line=$args{line}&new=$args{new}") .
+ (defined $args{filenumber} && $args{filenumber} ne "" ? "&fn=$args{filenumber}&line=$args{line}&new=$args{new}" : "") .
(defined $args{anchor} ? "&a=$args{anchor}" : "") .
(defined $args{context} ? "&context=$args{context}" : "");
} else {
Index: UpdateTopicPropertiesMethod.pm
===================================================================
RCS file: /cvsroot/codestriker/codestriker/lib/Codestriker/Http/Method/UpdateTopicPropertiesMethod.pm,v
retrieving revision 1.2
retrieving revision 1.3
diff -u -r1.2 -r1.3
--- UpdateTopicPropertiesMethod.pm 29 Aug 2008 10:48:57 -0000 1.2
+++ UpdateTopicPropertiesMethod.pm 31 Aug 2008 12:30:07 -0000 1.3
@@ -20,7 +20,7 @@
my ($self, %args) = @_;
if ($self->{cgi_style}) {
- return $self->{url_prefix} . "?action=submit_edit_topic_properties&topic=$args{topicid}";
+ return $self->{url_prefix} . "?action=submit_edit_topic_properties";
} else {
confess "Parameter topicid missing" unless defined $args{topicid};
confess "Parameter projectid missing" unless defined $args{projectid};
@@ -38,7 +38,7 @@
return 1;
} elsif ($path_info =~ m{^/project/\d+/topic/\d+/properties}) {
$self->_extract_nice_parameters($http_input,
- project => 'projectid', topic => 'topicid');
+ project => 'projectid', topic => 'topic');
return 1;
} else {
return 0;
Index: ViewTopicFileMethod.pm
===================================================================
RCS file: /cvsroot/codestriker/codestriker/lib/Codestriker/Http/Method/ViewTopicFileMethod.pm,v
retrieving revision 1.2
retrieving revision 1.3
diff -u -r1.2 -r1.3
--- ViewTopicFileMethod.pm 29 Aug 2008 10:48:58 -0000 1.2
+++ ViewTopicFileMethod.pm 31 Aug 2008 12:30:15 -0000 1.3
@@ -43,7 +43,7 @@
return 1;
} elsif ($path_info =~ m{^/project/\d+/topic/\d+/file/\d+}) {
$self->_extract_nice_parameters($http_input,
- project => 'projectid', topic => 'topicid',
+ project => 'projectid', topic => 'topic',
file => 'fn');
return 1;
} else {
|
