[Codestriker-commits] CVS update: codestriker/lib/Codestriker/Http UrlBuilder.pm

[<si...@us...>]

  User: sits    
  Date: 08/08/05 18:58:00

  Modified:    lib/Codestriker/Http UrlBuilder.pm
  Log:
  Keep the URLs shorter for default parameters which aren't defined.
  
  
  
  Index: UrlBuilder.pm
  ===================================================================
  RCS file: /cvsroot/codestriker/codestriker/lib/Codestriker/Http/UrlBuilder.pm,v
  retrieving revision 1.33
  retrieving revision 1.34
  diff -u -r1.33 -r1.34
  --- UrlBuilder.pm	5 Aug 2008 10:35:34 -0000	1.33
  +++ UrlBuilder.pm	6 Aug 2008 01:58:00 -0000	1.34
  @@ -22,15 +22,6 @@
       my $self = {};
       $self->{query} = $query;
       
  -    # Determine default settings.
  -    $self->{default_topic_create_mode} =
  -        defined $Codestriker::default_topic_create_mode ?
  -        $Codestriker::default_topic_create_mode : $Codestriker::COLOURED_MODE; 
  -
  -    $self->{default_file_to_view} =
  -        defined $Codestriker::default_file_to_view ?
  -        $Codestriker::default_file_to_view : -1; 
  -
       # Determine what prefix is required when using relative URLs.
       # Unfortunately, Netcsape 4.x does things differently to everyone
       # else.
  @@ -67,8 +58,8 @@
   	        "?topic=$args{topicid}&action=view" .
   	        (defined $args{updated} ? "&updated=$args{updated}" : "") .
   			(defined $args{tabwidth} ? "&tabwidth=$args{tabwidth}" : "") .
  -			"&mode=" . (defined $args{mode} ? $args{mode} : $self->{default_topic_create_mode}) .
  -			"&fview=" . (defined $args{fview} ? $args{fview} : $self->{default_file_to_view}) .
  +			(defined $args{mode} ? "&mode=$args{mode}" : "") .
  +			(defined $args{fview} ? "&fview=$args{fview}" : "") .
   			(defined $args{email} ? "&email=$args{email}" : "") .
   			(defined $args{filenumber} ? "#" . "$args{filenumber}|$args{line}|$args{new}" : "");
   }