codestriker-user

[Codestriker-user] Codestriker 1.9.2-alpha-9 incorrectly calculates module and files path

[Vladimir S. <vsi...@gm...>]

Hi,

Let's say I have branches/vvs/feature_4 branch that I've finished and
would like to get a review. I submit it for the review via CodeStriker
1.9.2 alpha-9.
Let's say also that I've modified a file Defs.mk in build subdir.

But reviewers will see the following file names:
branches/vvs/build/Defs.mk (please note that feature_4 part is MISSING!)

I tracked down the problem to Subversion.pm file, line 146:
       if ($line =~ /^svn: URL '.*' refers to a directory/) {

The problem here is that at least with my Subversion 1.3.2 the output
from svn cat command is DIFFIRENT:
svn: warning: URL 'blah-blah-blah' refers to a directory

Please note an extra token - warning:

It seems that CodeStriker should be more flexible and should handle
both outputs, from older Subversion and from newer Subversions: with
"warning:" and without it.

I can confirm that after I modify the line to be like this:
       if ($line =~ /^svn: (warning:)? URL '.*' refers to a directory/) {

The problem is gone.

I'm hoping this would end up in final 1.9.2.

Thank you for the great tool,
 --Vladimir

P.S. I wonder what non-English users of subversion would get from svn
cat, if their svn is localized.... :) Codestriker uses hardcoded
English...

Re: [Codestriker-user] Codestriker 1.9.2-alpha-9 incorrectly calculates module and files path

[David S. <si...@us...>]

Hi Vladimir,

Many thanks for your report.

 > [...]
> I tracked down the problem to Subversion.pm file, line 146:
>        if ($line =~ /^svn: URL '.*' refers to a directory/) {
> 
> The problem here is that at least with my Subversion 1.3.2 the output
> from svn cat command is DIFFIRENT:
> svn: warning: URL 'blah-blah-blah' refers to a directory
 > [...]

Thanks - I can certaintly change the regexp as you have indicated.

> P.S. I wonder what non-English users of subversion would get from svn
> cat, if their svn is localized.... :) Codestriker uses hardcoded
> English...

Agreed - it would be much better to perhaps use the error code returned 
by the svn process, so that this will also work for localised svn 
installations.

Does subversion return a unique error code number when this situation 
occurs?

I'm not a subversion user yet, so I can't easily check this out..

Cheers,
David

Re: [Codestriker-user] Codestriker 1.9.2-alpha-9 incorrectly calculates module and files path

[David S. <si...@us...>]

> I can confirm that after I modify the line to be like this:
>        if ($line =~ /^svn: (warning:)? URL '.*' refers to a directory/) {
> 
> The problem is gone.

I have made this a bit more general for now - but have committed in your 
fix.

if ($line =~ /^svn:.*URL '.*' refers to a directory/) {

Perhaps after 1.9.2 is released, we can do this properly using error 
return codes instead, but the above fix will be in for 1.9.2.

I'd be keen to see if there is a unique error code for this situation.

Cheers,
David