codestriker-user

[Codestriker-user] filetype exclusions in topic creation

[Clendenan, D. <dav...@po...>]

I've added the option to exclude files from review topics,
based on extension.

Pretty simply done - I walk the list as it's built in 
Parser->parse, and if it matches an entry in 
@exclude_file_types I drop it.

There is one flaw that I know of - if the only files in
the topic are dropped by this, the topic is created empty. 
It wasn't clear to me where to fix this, but it hasn't come
up yet in practice, so I didn't chase it down very hard :)

If someone has suggestions on where to fix this, please 
let me know.

thanks


Dave

Re: [Codestriker-user] filetype exclusions in topic creation

[Clendenan, D. <dav...@po...>]

On Thu, Oct 28, 2004 at 03:35:12PM -0700, Clendenan, Dave wrote:
> I've added the option to exclude files from review topics,
> based on extension.
>

I found a bug in my original implementation, due to flawed usage of $+
in the Parser.pm changes.

New diff attached (2-line change near the end)

Dave