Thread: [Codestriker-commits] CVS update: codestriker CHANGELOG (Page 2)
Brought to you by:
sits
From: <si...@us...> - 2008-08-12 09:20:23
|
User: sits Date: 08/08/12 02:20:22 Modified: bin install.pl . CHANGELOG Log: * Updated install.pl so that it can be executed from any directory, not just bin. Index: install.pl =================================================================== RCS file: /cvsroot/codestriker/codestriker/bin/install.pl,v retrieving revision 1.19 retrieving revision 1.20 diff -u -r1.19 -r1.20 --- install.pl 10 Jul 2008 10:43:55 -0000 1.19 +++ install.pl 12 Aug 2008 09:20:22 -0000 1.20 @@ -22,7 +22,19 @@ use strict; use Config; -use lib '../lib'; + +# Determine the location of the Codestriker bin directory. This will +# work even if the script was not executed in the bin directory. +my $bin_directory; +BEGIN { + use File::Spec::Functions qw(rel2abs); + use File::Basename qw(dirname); + my $path = rel2abs($0); + $bin_directory = dirname($path); +} +use lib $bin_directory . "/../lib"; + +chdir $bin_directory; require 5.008_0; Index: CHANGELOG =================================================================== RCS file: /cvsroot/codestriker/codestriker/CHANGELOG,v retrieving revision 1.258 retrieving revision 1.259 diff -u -r1.258 -r1.259 --- CHANGELOG 11 Aug 2008 03:58:11 -0000 1.258 +++ CHANGELOG 12 Aug 2008 09:20:22 -0000 1.259 @@ -7,6 +7,9 @@ of the standard commit-email.pl script which ships with Subversion. The email sent also includes an additional line, which is the URL to the auto-created topic. + +* Updated install.pl so that it can be executed from any directory, not + just bin. Version 1.9.6 |
From: <si...@us...> - 2008-08-27 09:51:49
|
User: sits Date: 08/08/27 02:51:45 Modified: doc codestriker.sgml . CHANGELOG Log: * Updated install.pl to support a separate Apache virtual host per Codestriker project as suggested by dm...@us.... Manual has been updated with the appropriate instructions. Index: codestriker.sgml =================================================================== RCS file: /cvsroot/codestriker/codestriker/doc/codestriker.sgml,v retrieving revision 1.70 retrieving revision 1.71 diff -u -r1.70 -r1.71 --- codestriker.sgml 11 Aug 2008 03:58:11 -0000 1.70 +++ codestriker.sgml 27 Aug 2008 09:51:44 -0000 1.71 @@ -1331,6 +1331,41 @@ not enable this mode. </para> </sect2> + + <sect2> + <title>Virtual Host per Project Configuration</title> + <para> + It is possible to create a separate virtual host / database per + Codestriker project using the following steps: + <itemizedlist> + <listitem> + <para>Copy the distribution files to a common location across configs. + For example, <filename>/usr/local/codestriker</filename>.</para> + </listitem> + <listitem> + <para>Create a unique directory for each virtual host configured in Apache. + For example, <filename>/usr/local/apache2/htdocs/CONFIG1/codestriker</filename>.</para> + </listitem> + <listitem> + <para>Create a <filename>codestriker.conf</filename> file in the virtual host directory.</para> + </listitem> + <listitem> + <para>Create a <filename>cgi-bin</filename> sub-directory in the virtual host directory.</para> + </listitem> + <listitem> + <para>Create symbolic links from common to config specific directory. For + example, <command>ln -s /usr/local/codestriker/* /usr/local/apache2/htdocs/CONFIG1/codestriker</command></para> + </listitem> + <listitem> + <para>Run install script in the virtual host directory. For example, <command>./bin/install.pl</command></para> + </listitem> + </itemizedlist> + </para> + <para> + Updates just require updating the single source install and running <command>./bin/install.pl</command> + for each virtual host directory. + </para> + </sect2> </sect1> <sect1 id="IIS-configuration"> Index: CHANGELOG =================================================================== RCS file: /cvsroot/codestriker/codestriker/CHANGELOG,v retrieving revision 1.261 retrieving revision 1.262 diff -u -r1.261 -r1.262 --- CHANGELOG 19 Aug 2008 10:50:15 -0000 1.261 +++ CHANGELOG 27 Aug 2008 09:51:45 -0000 1.262 @@ -19,7 +19,11 @@ state can be set. By default, this is set to "Open", however in situations where a review has already been performed but needs to be recorded, or a topic is automatically created from a post-commit - script from an SCM, sometimes another initial state is desirable. + script from an SCM, sometimes another initial state is desirable. + +* Updated install.pl to support a separate Apache virtual host per + Codestriker project as suggested by dm...@us.... + Manual has been updated with the appropriate instructions. Version 1.9.6 |
From: <si...@us...> - 2008-08-31 12:02:14
|
User: sits Date: 08/08/31 05:02:12 Modified: html codestriker.js template/en/default search.html.tmpl createtopic.html.tmpl . CHANGELOG Log: * Help popup text windows on the create topic and search screens disappear automatically when the cursor is moved off the (?) link. Index: codestriker.js =================================================================== RCS file: /cvsroot/codestriker/codestriker/html/codestriker.js,v retrieving revision 1.17 retrieving revision 1.18 diff -u -r1.17 -r1.18 --- codestriker.js 29 Aug 2008 10:49:00 -0000 1.17 +++ codestriker.js 31 Aug 2008 12:02:12 -0000 1.18 @@ -344,9 +344,7 @@ // window with a close link. function create_window(text) { - var html = '<a href="javascript:hideElt(getElt(\'overDiv\')); void(0);">' + - 'Close</a><p>' + text; - overlib(html, STICKY, DRAGGABLE, ALTCUT, CENTERPOPUP); + overlib(text, DRAGGABLE, ALTCUT, CENTERPOPUP); } // Function for posting to Codestriker using the XMLHttpRequest object. Index: search.html.tmpl =================================================================== RCS file: /cvsroot/codestriker/codestriker/template/en/default/search.html.tmpl,v retrieving revision 1.37 retrieving revision 1.38 diff -u -r1.37 -r1.38 --- search.html.tmpl 31 Aug 2008 11:45:04 -0000 1.37 +++ search.html.tmpl 31 Aug 2008 12:02:12 -0000 1.38 @@ -12,6 +12,7 @@ [%# The author input field #%] <TR> <TD>Author: <FONT SIZE="-2"><a href="javascript:void(0);" +onmouseout="return nd();" onmouseover="return create_window('\ Constrain the search on topic author, which may be wildcarded \ as joe* or joe*company*.')">(?)</a></FONT></TD> @@ -21,6 +22,7 @@ [%# The reviewer input field #%] <TR> <TD>Reviewer: <FONT SIZE="-2"><a href="javascript:void(0);" +onmouseout="return nd();" onmouseover="return create_window('\ Constrain the search on topic reviewer, which may be wildcarded \ as paul* or paul*company*.')">(?)</a></FONT></TD> @@ -30,6 +32,7 @@ [%# The Cc input field #%] <TR> <TD>Cc: <FONT SIZE="-2"><a href="javascript:void(0);" +onmouseout="return nd();" onmouseover="return create_window('\ Constrain the search on topic CC, which may be wildcarded \ as group* or group*company*.')">(?)</a></FONT></TD> @@ -40,6 +43,7 @@ [% IF bugdb_enabled != 0 %] <TR> <TD>Bug ID: <FONT SIZE="-2"><A HREF="javascript:void(0);" +onmouseout="return nd();" onmouseover="return create_window('\ Constrain the search on the topic bugid. This field \ cannot be wildcarded.')">(?)</a></FONT> @@ -51,6 +55,7 @@ [%# The state multi-select #%] <TR> <TD>State: <FONT SIZE="-2"><a href="javascript:void(0);" +onmouseout="return nd();" onmouseover="return create_window('\ Constrain the search on the topic\'s state. Multiple \ fields can be selected here by holding down the control \ @@ -71,6 +76,7 @@ [%# The project multi-select #%] <TR> <TD>Project: <FONT SIZE="-2"><a href="javascript:void(0)" +onmouseout="return nd();" onmouseover="return create_window('\ Constrain the search on topic project membership. \ Multiple fields can be selected here by holding down the \ @@ -91,6 +97,7 @@ [%# The contains text input field and checkbox #%] <TR> <TD>Contains text: <FONT SIZE="-2"><a href="javascript:void(0);" +onmouseout="return nd();" onmouseover="return create_window('\ Constrain the search on text contained in the title, description, \ comment, body and filename topic attributes. Text can be wildcarded.')">(?)</a></FONT></TD> Index: createtopic.html.tmpl =================================================================== RCS file: /cvsroot/codestriker/codestriker/template/en/default/createtopic.html.tmpl,v retrieving revision 1.57 retrieving revision 1.58 diff -u -r1.57 -r1.58 --- createtopic.html.tmpl 29 Aug 2008 10:49:00 -0000 1.57 +++ createtopic.html.tmpl 31 Aug 2008 12:02:12 -0000 1.58 @@ -27,6 +27,7 @@ [%# The topic title input field #%] Topic title: <FONT SIZE="-2"><a href="javascript:void(0);" +onmouseout="return nd();" onmouseover="return create_window('The topic title should be a concise but \ informative summary of the code to be reviewed. The title is used in the \ subject of sent emails, and in the topic list screen.');">(?)</a></FONT> @@ -37,6 +38,7 @@ [%# The topic description input field #%] Topic description: <FONT SIZE="-2"><a href="javascript:void(0);" +onmouseout="return nd();" onmouseover="return create_window('\ The topic description should contain enough information \ for a reviewer to understand broadly what the code change \ @@ -61,6 +63,7 @@ <TR> <TD>Topic text upload: <FONT SIZE="-2"><a href="javascript:void(0);" +onmouseout="return nd();" onmouseover="return create_window('\ The uploaded file contains the actual text of the review. \ Typically, the text is the output of a command such as: \ @@ -86,6 +89,7 @@ <TD> Start tag: <FONT SIZE="-2"><a href="javascript:void(0);" +onmouseout="return nd();" onmouseover="return create_window('\ Rather than uploading the topic text, if the repository \ supports it, the text can be fetched by querying the \ @@ -100,6 +104,7 @@ <INPUT TYPE="text" NAME="start_tag" VALUE="[% start_tag | html_entity %]" SIZE=20 MAXLENGTH=150 /> </TD> <TD>End tag: <FONT SIZE="-2"><a href="javascript:void(0);" +onmouseout="return nd();" onmouseover="return create_window('\ Rather than uploading the topic text, if the repository \ supports it, the text can be fetched by querying the \ @@ -118,6 +123,7 @@ <TD> Module: <FONT SIZE="-2"><A HREF="javascript:void(0);" +onmouseout="return nd();" onmouseover="return create_window('\ This is the path to the file or module relative to the repository \ root that should be inspected. It is ignored if text is uploaded.')">(?)</a></FONT> @@ -132,6 +138,7 @@ [%# The default_to_head input field #%] <TD>Default to HEAD: <FONT SIZE="-2"><a href="javascript:void(0);" +onmouseout="return nd();" onmouseover="return create_window('\ Fall back to HEAD revision if a file does not exist on either tag. \ This will allow diffs between a branch and the HEAD revision, without \ @@ -148,6 +155,7 @@ <TR> <TD>Repository: <FONT SIZE="-2"><A HREF="javascript:void(0);" +onmouseout="return nd();" onmouseover="return create_window('\ The SCM system (eg CVS, Subversion, ClearCase) \ which the topic text was prepared against. If \ @@ -175,6 +183,7 @@ <TR> <TD>Project: <FONT SIZE="-2"><a href="javascript:void(0);" +onmouseout="return nd();" onmouseover="return create_window('\ Topics are associated with a specific project, which can be \ used as filtering criteria in the search screen.')">(?)</a></FONT> @@ -198,6 +207,7 @@ <TR> <TD>Bug IDs: <FONT SIZE="-2"><a href="javascript:void(0)" +onmouseout="return nd();" onmouseover="return create_window('\ Indicates what bug identifiers are addressed by this code change. \ These are space or comma separated identifiers, such as: \ @@ -225,6 +235,7 @@ <TR> <TD>Your email address: <FONT SIZE="-2"><A HREF="javascript:void(0);" +onmouseout="return nd();" onmouseover="return create_window('\ This is your email address. All comments made against a topic \ will be sent to this address. The new topic notification email \ @@ -237,6 +248,7 @@ <TR> <TD>Reviewers: <FONT SIZE="-2"><a href="javascript:void(0);" +onmouseout="return nd();" onmouseover="return create_window('\ This is a comma separated list of email addresses, which are the \ people who need to review this code. When the topic is created, \ @@ -249,6 +261,7 @@ <TR> <TD>Cc: <FONT SIZE="-2"><a href="javascript:void(0);" +onmouseout="return nd();" onmouseover="return create_window('\ This is a comma separated list of email addresses, which are \ not intended to be reviewers, but typically a mailing list \ @@ -275,7 +288,8 @@ retrieving lists of topics from the search page. \ \ This topic can be superceeded by a new topic, by selecting the \ -state \'obsoleted\'')">(?)</A></FONT> +state \'obsoleted\'.');" +onmouseout="return nd();">(?)</A></FONT> </td> <td> [%# Now display the option button for changing the topic state #%] Index: CHANGELOG =================================================================== RCS file: /cvsroot/codestriker/codestriker/CHANGELOG,v retrieving revision 1.263 retrieving revision 1.264 diff -u -r1.263 -r1.264 --- CHANGELOG 29 Aug 2008 11:48:29 -0000 1.263 +++ CHANGELOG 31 Aug 2008 12:02:12 -0000 1.264 @@ -27,7 +27,10 @@ * Updated install.pl to support a separate Apache virtual host per Codestriker project as suggested by dm...@us.... - Manual has been updated with the appropriate instructions. + Manual has been updated with the appropriate instructions. + +* Help popup text windows on the create topic and search screens + disappear automatically when the cursor is moved off the (?) link. Version 1.9.6 |
From: <si...@us...> - 2008-09-02 06:33:59
|
User: sits Date: 08/09/01 23:33:57 Modified: t/FileParser subversion.t lib/Codestriker/FileParser SubversionDiff.pm . CHANGELOG Added: test/testtopictexts svn-PropDiff9.txt Log: * Fixed a bug where Subversion diffs with binary files that contained property changes were not handled correctly. Index: svn-PropDiff9.txt =================================================================== RCS file: svn-PropDiff9.txt diff -N svn-PropDiff9.txt --- /dev/null 1 Jan 1970 00:00:00 -0000 +++ svn-PropDiff9.txt 2 Sep 2008 06:33:56 -0000 1.1 @@ -0,0 +1,26 @@ +Index: product/lib/javamail/mail.jar +=================================================================== +Cannot display: file marked as a binary type. +svn:mime-type = application/octet-stream + +Property changes on: product\lib\javamail\mail.jar +___________________________________________________________________ +Added: svn:mime-type + + application/octet-stream + +Index: buildCleanup.py +=================================================================== +--- buildCleanup.py (revision 7) ++++ buildCleanup.py (revision 9) +@@ -28,11 +28,7 @@ + # GCOMDirectories = ['/usr/local/apache2/htdocs/docs', '/export/home/buildmaster/cruisecontrol/GCOM'] + # EPRODirectories = ['/usr/local/apache2/htdocs/docs', '/export/home/buildmaster/cruisecontrol/EPRODATA'] + +- GCOMDirectories = [ 'testdata/branches/GCOM' ] +- EPRODirectories = [ 'testdata/branches/EPRODATA' ] + +- activeGraingerBuild = database.getActiveBuild("PRD", "gcom") +- activeEPROBuild = database.getActiveBuild("PRD", "eprodata") + + print activeGraingerBuild.getBranchIdentifier() + print activeEPROBuild.getBranchIdentifier() Index: subversion.t =================================================================== RCS file: /cvsroot/codestriker/codestriker/t/FileParser/subversion.t,v retrieving revision 1.2 retrieving revision 1.3 diff -u -r1.2 -r1.3 --- subversion.t 4 Aug 2008 10:33:33 -0000 1.2 +++ subversion.t 2 Sep 2008 06:33:57 -0000 1.3 @@ -2,7 +2,7 @@ use strict; use Fatal qw / open close /; -use Test::More tests => 33; +use Test::More tests => 36; use Test::Differences; use lib '../../lib'; @@ -149,6 +149,33 @@ END_DELTA )); +assert_delta_equals('../../test/testtopictexts/svn-Propdiff9.txt', + make_delta(filename => 'product/lib/javamail/mail.jar', + old_linenumber => -1, + new_linenumber => -1, + revision => '1.0', + text => '', + binary => 1), + make_delta(filename => 'buildCleanup.py', + old_linenumber => '28', + new_linenumber => '28', + revision => '7', + text => <<'END_DELTA', + # GCOMDirectories = ['/usr/local/apache2/htdocs/docs', '/export/home/buildmaster/cruisecontrol/GCOM'] + # EPRODirectories = ['/usr/local/apache2/htdocs/docs', '/export/home/buildmaster/cruisecontrol/EPRODATA'] + +- GCOMDirectories = [ 'testdata/branches/GCOM' ] +- EPRODirectories = [ 'testdata/branches/EPRODATA' ] + +- activeGraingerBuild = database.getActiveBuild("PRD", "gcom") +- activeEPROBuild = database.getActiveBuild("PRD", "eprodata") + + print activeGraingerBuild.getBranchIdentifier() + print activeEPROBuild.getBranchIdentifier() +END_DELTA + )); + + assert_delta_equals('../../test/testtopictexts/svn-look-diff1.txt', make_delta(filename => 't1.txt', old_linenumber => '0', Index: SubversionDiff.pm =================================================================== RCS file: /cvsroot/codestriker/codestriker/lib/Codestriker/FileParser/SubversionDiff.pm,v retrieving revision 1.10 retrieving revision 1.11 diff -u -r1.10 -r1.11 --- SubversionDiff.pm 2 Aug 2008 04:47:40 -0000 1.10 +++ SubversionDiff.pm 2 Sep 2008 06:33:57 -0000 1.11 @@ -86,7 +86,7 @@ # removed, and what revision it is based off. $line = <$fh>; my $count = 0; - while (defined $line && $line !~ /^Index|Added|Modified|Deleted/o) { + while (defined $line && $line !~ /^Index|Added|Modified|Deleted|Property changes on:/o) { $line = <$fh>; $count++; } Index: CHANGELOG =================================================================== RCS file: /cvsroot/codestriker/codestriker/CHANGELOG,v retrieving revision 1.264 retrieving revision 1.265 diff -u -r1.264 -r1.265 --- CHANGELOG 31 Aug 2008 12:02:12 -0000 1.264 +++ CHANGELOG 2 Sep 2008 06:33:57 -0000 1.265 @@ -31,6 +31,9 @@ * Help popup text windows on the create topic and search screens disappear automatically when the cursor is moved off the (?) link. + +* Fixed a bug where Subversion diffs with binary files that contained + property changes were not handled correctly. Version 1.9.6 |
From: <si...@us...> - 2008-09-27 03:42:05
|
User: sits Date: 08/09/26 20:41:50 Modified: template/en/default viewtopiccomments.html.tmpl lib/Codestriker/Action ViewTopicComments.pm . CHANGELOG Log: * Added "Diff" link for each comment on the list comments page so that for those reviews which aren't linked to an SCM, it is still possible to quickly link back to the coloured topic text. Index: viewtopiccomments.html.tmpl =================================================================== RCS file: /cvsroot/codestriker/codestriker/template/en/default/viewtopiccomments.html.tmpl,v retrieving revision 1.32 retrieving revision 1.33 diff -u -r1.32 -r1.33 --- viewtopiccomments.html.tmpl 27 Sep 2008 03:28:56 -0000 1.32 +++ viewtopiccomments.html.tmpl 27 Sep 2008 03:41:49 -0000 1.33 @@ -116,6 +116,7 @@ <TD> [% IF comment.filename != '' %] <A HREF="[% comment.view_file %]">[% comment.filename %][% IF comment.fileline != -1 %]:[% comment.fileline %]</A>[% ELSE %]</A> (File Level)[% END %] + | <A HREF="[% comment.view_diff %]">Diff</A> [% IF allow_repositories != 0 %] | <A HREF="[% comment.view_parallel %]">Parallel</A> [% END %] [% ELSIF comment.fileline == -1 && comment.filenumber == -1 %] Topic Level Index: ViewTopicComments.pm =================================================================== RCS file: /cvsroot/codestriker/codestriker/lib/Codestriker/Action/ViewTopicComments.pm,v retrieving revision 1.22 retrieving revision 1.23 diff -u -r1.22 -r1.23 --- ViewTopicComments.pm 6 Sep 2008 00:31:45 -0000 1.22 +++ ViewTopicComments.pm 27 Sep 2008 03:41:49 -0000 1.23 @@ -98,8 +98,15 @@ filenumber => $comment->{filenumber}, new => $comment->{filenew}, line => $comment->{fileline}, mode => $mode); + my $view_diff_file = + $url_builder->view_url(topicid => $topicid, projectid => $projectid, + fview => $comment->{filenumber}, + filenumber => $comment->{filenumber}, + new => $comment->{filenew}, + line => $comment->{fileline}, mode => $mode); $comment->{view_file} = "javascript: myOpen('$new_file','CVS')"; + $comment->{view_diff} = "javascript: myOpen('$view_diff_file','CVS')"; my $parallel = $new_file; $comment->{view_parallel} = "javascript: myOpen('$parallel','CVS')"; Index: CHANGELOG =================================================================== RCS file: /cvsroot/codestriker/codestriker/CHANGELOG,v retrieving revision 1.269 retrieving revision 1.270 diff -u -r1.269 -r1.270 --- CHANGELOG 25 Sep 2008 09:11:23 -0000 1.269 +++ CHANGELOG 27 Sep 2008 03:41:50 -0000 1.270 @@ -49,7 +49,11 @@ rob...@us.... * ScmBug integration now works correctly when deleted files are - present in a Subversion changeset. + present in a Subversion changeset. + +* Added "Diff" link for each comment on the list comments page so that for + those reviews which aren't linked to an SCM, it is still possible + to quickly link back to the coloured topic text. Version 1.9.6 |