User: sits
Date: 08/08/14 23:30:39
Modified: lib/Codestriker/Model Topic.pm
lib/Codestriker/Http UrlBuilder.pm
lib/Codestriker/Action ListTopics.pm
lib/Codestriker/Http/Method ListTopicsMethod.pm
Log:
Few more minor changes.
Index: Topic.pm
===================================================================
RCS file: /cvsroot/codestriker/codestriker/lib/Codestriker/Model/Topic.pm,v
retrieving revision 1.49
retrieving revision 1.50
diff -u -r1.49 -r1.50
--- Topic.pm 22 Feb 2008 00:56:21 -0000 1.49
+++ Topic.pm 15 Aug 2008 06:30:38 -0000 1.50
@@ -754,7 +754,7 @@
# Build up the project condition.
my $project_part = "";
- if ($sproject ne "") {
+ if (defined $sproject && $sproject ne "") {
$project_part = "topic.projectid IN ($sproject)";
}
Index: UrlBuilder.pm
===================================================================
RCS file: /cvsroot/codestriker/codestriker/lib/Codestriker/Http/UrlBuilder.pm,v
retrieving revision 1.40
retrieving revision 1.41
diff -u -r1.40 -r1.41
--- UrlBuilder.pm 15 Aug 2008 06:10:41 -0000 1.40
+++ UrlBuilder.pm 15 Aug 2008 06:30:39 -0000 1.41
@@ -143,7 +143,6 @@
sub list_topics_url {
my ($self, %args) = @_;
- print STDERR "list sauthor is " . $args{sauthor} . "\n";
$args{action} = "list_topics";
return $self->_list_topics_url(%args);
}
@@ -160,8 +159,6 @@
# Create the URL for listing the topics.
sub _list_topics_url {
my ($self, %args) = @_;
- print STDERR "_list sauthor is " . $args{sauthor} . "\n";
-
return Codestriker::Http::Method::ListTopicsMethod->new($self->{query})->url(%args);
}
Index: ListTopics.pm
===================================================================
RCS file: /cvsroot/codestriker/codestriker/lib/Codestriker/Action/ListTopics.pm,v
retrieving revision 1.35
retrieving revision 1.36
diff -u -r1.35 -r1.36
--- ListTopics.pm 10 Aug 2008 12:18:43 -0000 1.35
+++ ListTopics.pm 15 Aug 2008 06:30:39 -0000 1.36
@@ -62,7 +62,7 @@
# If only a single project id is being searched over, set that id in the
# cookie.
my @project_ids = ();
- if ($sproject ne "") {
+ if (defined $sproject && $sproject ne "") {
@project_ids = split ',', $sproject;
}
my $projectid_cookie = ($#project_ids == 0) ? $project_ids[0] : "";
@@ -297,7 +297,7 @@
# from the cookie as the project search value. This is done to facilate
# integration with other systems, which jump straight to this URL, and
# set the cookie explicitly.
- if ($sproject eq "-1") {
+ if (defined $sproject && $sproject eq "-1") {
$sproject = (defined $projectid) ? $projectid : "";
}
@@ -329,7 +329,7 @@
my @sort_order = split(/,/,$topicsort); # this is always from the cookie.
- if ($topic_sort_change ne "") {
+ if (defined $topic_sort_change && $topic_sort_change ne "") {
if (scalar(@sort_order) > 0) {
# If the user clicked on the same column twice in a row, reverse
Index: ListTopicsMethod.pm
===================================================================
RCS file: /cvsroot/codestriker/codestriker/lib/Codestriker/Http/Method/ListTopicsMethod.pm,v
retrieving revision 1.2
retrieving revision 1.3
diff -u -r1.2 -r1.3
--- ListTopicsMethod.pm 15 Aug 2008 06:10:41 -0000 1.2
+++ ListTopicsMethod.pm 15 Aug 2008 06:30:39 -0000 1.3
@@ -23,8 +23,6 @@
my $sproject = defined $args{sproject} ? CGI::escape(join ',', @{$args{sproject}}) : "";
my $action = defined $args{rss} && $args{rss} ? "list_topics_rss" : "list_topics";
- print STDERR "sauthor is " . $args{sauthor} . "\n";
-
if ($self->{cgi_style}) {
return $self->{url_prefix} . "?action=$action" .
(defined $args{sauthor} && $args{sauthor} ne "" ? "&sauthor=" . CGI::escape($args{sauthor}) : "") .
|
