Thread: [Codestriker-commits] CVS update: codestriker/lib/Codestriker/Action ViewTopic.pm
Brought to you by:
sits
Menu
▾
▴
codestriker-commits
|
From: <si...@us...> - 2007-07-02 09:54:19
|
User: sits
Date: 07/07/02 02:54:12
Modified: . CHANGELOG
lib/Codestriker/Action ViewTopic.pm
Log:
* The topic comments tab count would incorrectly display the number
of comment threads rather than the number of comments, when viewing
the topic text. This has now been fixed.
Index: CHANGELOG
===================================================================
RCS file: /cvsroot/codestriker/codestriker/CHANGELOG,v
retrieving revision 1.208
retrieving revision 1.209
diff -u -r1.208 -r1.209
--- CHANGELOG 29 Jun 2007 12:58:06 -0000 1.208
+++ CHANGELOG 2 Jul 2007 09:54:09 -0000 1.209
@@ -29,6 +29,10 @@
comments screen, as suggested by Nikita V. Borodikhin
<el...@us...> to minimise confusion.
+* The topic comments tab count would incorrectly display the number
+ of comment threads rather than the number of comments, when viewing
+ the topic text. This has now been fixed.
+
Version 1.9.3
* The project list screen now displays for each project, the total
Index: ViewTopic.pm
===================================================================
RCS file: /cvsroot/codestriker/codestriker/lib/Codestriker/Action/ViewTopic.pm,v
retrieving revision 1.51
retrieving revision 1.52
diff -u -r1.51 -r1.52
--- ViewTopic.pm 1 Mar 2005 10:12:49 -0000 1.51
+++ ViewTopic.pm 2 Jul 2007 09:54:12 -0000 1.52
@@ -44,13 +44,11 @@
# many distinct comment lines are there.
my @comments = $topic->read_comments();
my %comment_map = ();
- my $number_comments = 0;
foreach my $comment (@comments) {
my $key = $comment->{filenumber} . "|" . $comment->{fileline} . "|" .
$comment->{filenew};
if (! exists $comment_map{$key}) {
$comment_map{$key} = 1;
- $number_comments++;
}
}
@@ -153,9 +151,6 @@
# Obtain the link to download the actual document text.
$vars->{'download_url'} = $url_builder->download_url($topicid);
- # Indicate how many comments there are.
- $vars->{'number_comments'} = $number_comments;
-
# Fire the template on the topic heading information.
my $template = Codestriker::Http::Template->new("viewtopic");
$template->process($vars);
|
|
From: <si...@us...> - 2008-03-11 09:06:52
|
User: sits
Date: 08/03/11 02:06:50
Modified: lib/Codestriker/Action ViewTopic.pm
Log:
Minor fixes for parallel mode to work again
Index: ViewTopic.pm
===================================================================
RCS file: /cvsroot/codestriker/codestriker/lib/Codestriker/Action/ViewTopic.pm,v
retrieving revision 1.56
retrieving revision 1.57
diff -u -r1.56 -r1.57
--- ViewTopic.pm 10 Mar 2008 23:18:03 -0000 1.56
+++ ViewTopic.pm 11 Mar 2008 09:06:50 -0000 1.57
@@ -268,13 +268,13 @@
$delta->{view_old_full_url} =
$url_builder->view_file_url($topicid, $filenumber, 0, $delta->{old_linenumber},
$mode, 0);
- $delta->{view_old_both_full_url} =
+ $delta->{view_old_full_both_url} =
$url_builder->view_file_url($topicid, $filenumber, 0, $delta->{old_linenumber},
$mode, 1);
$delta->{view_new_full_url} =
$url_builder->view_file_url($topicid, $filenumber, 1, $delta->{new_linenumber},
$mode, 0);
- $delta->{view_new_both_full_url} =
+ $delta->{view_new_full_both_url} =
$url_builder->view_file_url($topicid, $filenumber, 1, $delta->{new_linenumber},
$mode, 1);
}
|
|
From: <si...@us...> - 2008-06-16 06:01:05
|
User: sits
Date: 08/06/15 23:01:04
Modified: lib/Codestriker/Action ViewTopic.pm
Log:
Make sure the previous/next links for all delta objects are recorded so that the various views are rendered correctly.
Index: ViewTopic.pm
===================================================================
RCS file: /cvsroot/codestriker/codestriker/lib/Codestriker/Action/ViewTopic.pm,v
retrieving revision 1.60
retrieving revision 1.61
diff -u -r1.60 -r1.61
--- ViewTopic.pm 11 Jun 2008 12:00:31 -0000 1.60
+++ ViewTopic.pm 16 Jun 2008 06:01:04 -0000 1.61
@@ -247,9 +247,9 @@
# Set the per-delta URL links, such as adding a file-level comment,
# and links to the previous/next file.
- my $filenumber = 0;
my $current_filename = "";
foreach my $delta (@deltas) {
+ my $filenumber = $delta->{filenumber};
$delta->{add_file_comment_element} =
$delta_renderer->comment_link($filenumber, -1, 1, "[Add File Comment]");
@@ -276,8 +276,7 @@
}
# Create the next/previous file URL links.
- if ($current_filename ne $delta->{filename}) {
- if ($filenumber > 0) {
+ if ($filenumber > 0) {
$delta->{previous_file_url} =
$url_builder->view_url($topicid, -1, $mode, $brmode,
$filenumber-1) . "#" . $filenames[$filenumber-1];
@@ -288,10 +287,7 @@
$filenumber+1) . "#" . $filenames[$filenumber+1];
}
- # Keep track of the current filename being processed.
- $filenumber++;
$current_filename = $delta->{filename};
- }
}
# Annotate the deltas appropriately so that they can be easily rendered.
|
|
From: <si...@us...> - 2008-08-07 07:05:29
|
User: sits
Date: 08/08/07 00:05:27
Modified: lib/Codestriker/Action ViewTopic.pm
Log:
Another view topic URL that needed to be fixed.
Index: ViewTopic.pm
===================================================================
RCS file: /cvsroot/codestriker/codestriker/lib/Codestriker/Action/ViewTopic.pm,v
retrieving revision 1.65
retrieving revision 1.66
diff -u -r1.65 -r1.66
--- ViewTopic.pm 5 Aug 2008 10:35:34 -0000 1.65
+++ ViewTopic.pm 7 Aug 2008 07:05:27 -0000 1.66
@@ -304,8 +304,7 @@
$vars->{'view_topicinfo_url'} =
$url_builder->view_topicinfo_url($topic->{topicid});
$vars->{'view_topic_url'} =
- ## XX mode, last param
- $url_builder->view_url($topic->{topicid}, -1, 0);
+ $url_builder->view_url(topicid => $topic->{topicid});
$vars->{'view_comments_url'} =
$url_builder->view_comments_url($topic->{topicid});
|
×
Want the latest updates on software, tech news, and AI?
Get latest updates about software, tech news, and AI from SourceForge directly in your inbox once a month.
Thanks for helping keep SourceForge clean.
X