#15 Creating topic using subversion with 'propset' diffs fails

closed-fixed
nobody
None
5
2004-09-13
2004-09-09
Keith Levy
No

When creating a new topic using a subversion diff that
includes a 'propset' entry, the topic is not created
correctly.

The scenarios differ slightly depending on whether a
direct subversion source connection is used or if text
upload is used. If a direct subversion source
connection is used, there is no topic text (diffs)
included in the topic. If text upload is used, the
uploaded text file is shown as the only topic text
instead of it being parsed into the correct topic files.

An example of the 'propset' entry in subversion diffs is:

Property changes on: webapps/WEB-INF/struts-tiles.tld
___________________________________________________________________
Name: svn:eol-style
+ native

To add a property in subversion that will generate the
above diff message, run the following command:

svn propset svn:eol-style native 'filename'

Discussion

  • David Sitsky

    David Sitsky - 2004-09-10

    Logged In: YES
    user_id=208928

    I don't have subversion running on any of my machines at the
    moment. Could you attach an example diff file which shows
    just a property set change, and files which have both code
    and property set changes? Thanks.

    The more examples you can provide in a diff file, the
    better. If you can attach it as a file, that would be best,
    so that there are no line-wrapping spacing issues.

     
  • Keith Levy

    Keith Levy - 2004-09-10
     
  • Keith Levy

    Keith Levy - 2004-09-10

    Logged In: YES
    user_id=1118904

    I have attached 5 diff files:

    svnPropDiff1.txt - shows one file with a property change
    svnPropDiff2.txt - shows same file with a different property
    change
    svnPropDiff3.txt - shows diff of same file across both
    property changes (note all changes are under the same header)
    svnPropDiff4.txt - shows diffs of multiple files including
    single property change
    svnPropDiff5.txt - shows diffs of multiple files including
    multiple property changes

     
  • Keith Levy

    Keith Levy - 2004-09-10
     
  • Keith Levy

    Keith Levy - 2004-09-10

    Logged In: YES
    user_id=1118904

    uploading 2nd file

     
  • Keith Levy

    Keith Levy - 2004-09-10

    Logged In: YES
    user_id=1118904

    uploading 3rd file

     
  • Keith Levy

    Keith Levy - 2004-09-10

    Logged In: YES
    user_id=1118904

    uploading 3rd file, 2nd try

     
  • Keith Levy

    Keith Levy - 2004-09-10
     
  • Keith Levy

    Keith Levy - 2004-09-10

    Logged In: YES
    user_id=1118904

    uploading 4th file

     
  • Keith Levy

    Keith Levy - 2004-09-10
     
  • Keith Levy

    Keith Levy - 2004-09-10
     
  • Keith Levy

    Keith Levy - 2004-09-10

    Logged In: YES
    user_id=1118904

    uploading 5th file

     
  • David Sitsky

    David Sitsky - 2004-09-13
    • status: open --> open-fixed
     
  • David Sitsky

    David Sitsky - 2004-09-13

    Logged In: YES
    user_id=208928

    I have modified lib/Codestriker/FileParser/SubversionDiff.pm
    so that it can now handle diffs with propset changes in
    them. This is now in CVS, and just made it into the 1.8.3
    release, which is due out tomorrow morning. Thanks for
    uploading the example diffs. Hopefully this has fixed your
    problem.

     
  • David Sitsky

    David Sitsky - 2004-09-13
    • status: open-fixed --> closed-fixed
     

Log in to post a comment.

Get latest updates about Open Source Projects, Conferences and News.

Sign up for the SourceForge newsletter:

JavaScript is required for this form.





No, thanks