Menu

#30 Small cleanup of SaveTimer.java

open
nobody
None
3
2006-04-10
2005-08-10
No

It looks like SaveTimer was changed a while back to use a shutdown
hook instead of timed saves for the saving of the instrument file.

I cleaned up some of the commented out code and changed the
name of the class to better reflect its intent.

SaveTimer.java removed

Cleanup.zip has the diffs and the new file in it.

Just doing some cleanup as I familiarize myself with more of the
codebase.

Discussion

  • James Seigel

    James Seigel - 2005-08-10

    Zip file of the changes and the new file

     
  • Grzegorz Lukasik

    Logged In: YES
    user_id=1216999

    Maybe we can go the other way, and implement SaveTimer
    properly. Let's say that if property
    net.sourceforge.cobertura.flushtime is set, then new thread
    is created that flushes data periodically.

    It can be useful for server applications where people use
    hot deploy feature and server cannot be shutdowned (I know
    about one such case). Or reports could be generated during
    tests run.

    Just a proposition.

     
  • James Seigel

    James Seigel - 2005-08-10

    Logged In: YES
    user_id=1282699

    Sounds like an interesting approach. I will have a look.

    Is there a vision/todo document kicking around describing where we want
    to go with the development/features?

    Cheers
    James.

     
  • Grzegorz Lukasik

    Logged In: YES
    user_id=1216999

    There is probably no such a document. When Mark will be back
    maybe he will say something more.

     
  • James Seigel

    James Seigel - 2005-08-10

    Logged In: YES
    user_id=1282699

    Sounds good Grzegorz.

    Cheers
    James

     
  • Mark Doliner

    Mark Doliner - 2005-08-11

    Logged In: YES
    user_id=20979

    Nope, no such document. I've been happy just using the
    various trackers at sourceforge. As for the SaveTimer... It
    DID originally have the ability to save after an interval,
    but I removed it at some point. I don't really have an
    opinion either way. On the one hand, I don't really like
    adding features that people haven't asked for/might not use,
    but on the other hand, it IS something that could be
    extremely useful in some circumstances.

    Probably better to add the ability to save every x number of
    seconds.

     
  • James Seigel

    James Seigel - 2005-08-11

    Logged In: YES
    user_id=1282699

    Sounds good.

    Cheers
    James

     
  • Grzegorz Lukasik

    Logged In: YES
    user_id=1216999

    James,

    will you implement it?

     
  • James Seigel

    James Seigel - 2005-09-02

    Logged In: YES
    user_id=1282699

    Will look into it. just getting back from holidays.

     
  • Mark Doliner

    Mark Doliner - 2006-04-10
    • priority: 5 --> 3
     
  • Nobody/Anonymous

    Wow! I almost forgot ever working on this!

     
  • Nobody/Anonymous

    I have read some just right stuff here. Certainly value bookmarking for revisiting. I wonder how so much attempt you put to create the sort of great informative website. Burberry Sale http://burberrysale118.cabanova.com

     
  • Nobody/Anonymous

    Hermes Bags http://hermesbags.v5s7.com de gracieux qualit - colis agile et soign