RE: [Cobertura-devel] Patch: CommandLineBuilder added

[Mark D. <Mar...@sa...>]

I like this cleanup--very nice.

Instead of
    logger.fatal( "'--commandsfile' specified as last option, =
ignoring.");
Would it be better to throw an exception and have Cobertura exit with an =
error message?  It seems like the immediate feedback would be more =
useful to a user who happens to try passing in the --commandsfile =
argument without specifying a file.

I committed the file etc/jalopy.xml to CVS.  I've actually been using =
Eclipse to format my source, and the Eclipse rules I'm using are =
slightly different than the Jalopy rules, so if you run Jalopy over =
everything there will be a lot of changes.

If you really want to format some source, it may be a good idea to only =
format the files you've made changes to, instead of formating all files. =
 Or, I dunno, feel free to change the Jalopy file so that it formats =
things closer to what's in CVS.

-Mark


> -----Original Message-----
> From: cob...@li...=20
> [mailto:cob...@li...] On=20
> Behalf Of Grzegorz Lukasik
> Sent: Saturday, August 13, 2005 9:17 AM
> To: cobertura-devel
> Subject: [Cobertura-devel] Patch: CommandLineBuilder added
>=20
> Hi
>=20
> I have extracted support for long command lines into new class. It
> puts common parts of code to one place, and allows to test it better.
>=20
> Mark, do you have your version of jalopy.xml so that i can=20
> format new code?
>=20
> Grzegorz
>=20