RE: [Cobertura-devel] Multiple Source directories

[Mark D. <Mar...@sa...>]

I'll respond to this out of order...



> 2) In the xmlreport there is a line that looks like this: =09
> 			<coverage src=3D"sourceDirectory">
> that gets printed out at the top of the file.  What would you=20
> want to see in a multiple source directory format?

That's a pretty minor detail.  I'm not averse to removing the src =
attribute; I doubt many people are using it.  Or maybe add a nested =
<source> tag that mirrors the fileset specified by cobertura-report?  In =
any case, I have no problems with doing this as a separate patch, after =
this other stuff is working.



> 1) How many people do you feel are using the library in the=20
> NON-ant way?  Would a change in their API be acceptable?

Probably not too many.  An API change is definitely acceptable if it's =
required to support multiple source directories.  If the API change is =
not required, but will make things a whole lot less ugly, then that =
should be ok, too.



> 3) Instrumentation bug that only allows one fileset (aha!=20
> found it in the bug reports)  Would a change in the=20
> Main.class command line args be acceptable to fix this issue?

> I believe that if we are going the fileset route then we have=20
> to tie the sourcefile to its parent base directory and be=20
> diligent about picking the correct file.  I have implemented=20
> this approach.  However, it will take a bit of effort for the=20
> command line folks to change over to a new way of encoding=20
> the parameters.  They will have to specify a "--sourceFile=20
> <srcDir>,<srcFile>" for each source file they wish to include.

Yes, sourcefiles should definitely be tied to a specific parent base =
directory.  Could we ret rid of the --basedir argument completely and =
specify directories and files as follows

cobertura-instrument.bat --datafile C:\cobertura.ser C:\mysrcdir1 =
C:\mysrcdir2 C:\mysrcdir3\com\example\meatballfactory =
C:\mysrcdir3\com\example\meatballconsumer C:\mysrcdir4

-Mark