Re: [Cobertura-devel] Multiple Source directories

[Seigel, J. <Jam...@av...>]

Questions for the group:

1) How many people do you feel are using the library in the NON-ant way? =
 Would a change in their API be acceptable?
2) In the xmlreport there is a line that looks like this: 				<coverage =
src=3D"sourceDirectory">
that gets printed out at the top of the file.  What would you want to =
see in a multiple source directory format?

3) Instrumentation bug that only allows one fileset (aha! found it in =
the bug reports)  Would a change in the Main.class command line args be =
acceptable to fix this issue?

The problem for 1 & 3

Currently the way that the information is getting passed from the ant =
side to the back side is through command line parameters: "--basedir bob =
--datafile sherryfile srcfile1 srcfile2 srcfile3 ..." etc.  This leaves =
the listing of the source files without really any parent information =
(i.e. what basedir do they come from if we wanted to specify multiple =
base directories. =20

One could argue that if you don't find the source file in one directory =
just look in another one until you find it.  Well I have that approach =
implemented as well.  The problem with this approach is that we aren't =
really taking advantage of the fileset's include and exclude =
functionality then and we might as well just pass over a collection of =
basedirectories and forget about listing the files at all.  This is =
complicated by the fact that a file with the same name and package =
structure could be in multiple source directories and if someone =
carefully set up their includes and excludes to pick the right one, they =
might be in for a surprise if they get the other one.

I believe that if we are going the fileset route then we have to tie the =
sourcefile to its parent base directory and be diligent about picking =
the correct file.  I have implemented this approach.  However, it will =
take a bit of effort for the command line folks to change over to a new =
way of encoding the parameters.  They will have to specify a =
"--sourceFile <srcDir>,<srcFile>" for each source file they wish to =
include.

Anyway...feedback is needed.

This would be the only form supported, with no srcDir parameters, and as =
many filesets as you want.  If this approach is good for you guys, then =
I can submit a patch for the instrument bug as well. =20

                <cobertura-report destdir=3D"${coverage.html.dir}">
                        <fileset dir=3D"${src.dir}">
                                <include name=3D"**/*.java" />
                        </fileset>
                        <fileset dir=3D"${test.dir}">
                                <include name=3D"**/*.java" />
                                <exclude name=3D"**/*Test.java" />
                        </fileset>
                </cobertura-report>

Cheers
james.

P.S. I will submit the patch when I get some feedback...I feel I have =
been plugging up the patch hole on sf.net with wasted efforts.