RE: [Cobertura-devel] How can I get involved....

[Mark D. <Mar...@sa...>]

I talked to Jeremy for a few minutes about this yesterday.  I guess we =
kind of decided that the fix is an improvement from what it was.  After =
his patch, Cobertura lumps all inner classes with their parents.  So the =
HTML reports show everything on one page, but the XML reports no longer =
distinguish between inner classes and their parent.

I still think that ideally, inner classes would be listed independently =
of their parent class in the xml reports.  What do other people think?

-Mark

> -----Original Message-----
> From: Jeremy Thomerson [mailto:je...@th...]=20
> Sent: Wednesday, May 18, 2005 3:34 AM
> To: Mark Doliner; Jody Brownell
> Cc: cob...@li...; Adam Morgan
> Subject: Re: [Cobertura-devel] How can I get involved....
>=20
> I just committed the necessary changes to accomodate "coverage for the
> classes HelloWorld and HelloWorld$1 would both appear on the same HTML
> page".
>=20
> It also removed the map of classes maintained in ProjectData=20
> since we're
> already maintaining all of our classes in individual=20
> PackageData instances.
> Granted, it would've been handy to continue hanging on to ClassData
> instances in ProjectData, but it would have required copy and=20
> paste logic
> from PackageData determining how to aggregrate data from=20
> inner classes into
> its parent class.  I really hate copy and paste wcode, so I=20
> refactored it to
> avoid needing it.  However, I think the better way to=20
> refactor this in the
> future is have an object whose job it is to hold on to=20
> multiple ClassData
> instances, and it can be the only place that contains the aggregration
> logic.  Maybe?
>=20
> It's late enough for now.  Hope this was what you were=20
> looking for Mark.
> Let me know if it's not.  I can back out my changes.
>=20
> Jeremy Thomerson
> eBay
>=20
> ----- Original Message -----
> From: "Mark Doliner" <Mar...@sa...>
> To: "Jeremy Ryan Thomerson" <je...@th...>;=20
> "Jody Brownell"
> <jod...@Q1...>
> Cc: <cob...@li...>; "Adam Morgan"
> <ada...@Q1...>
> Sent: Tuesday, May 17, 2005 1:10 PM
> Subject: RE: [Cobertura-devel] How can I get involved....
>=20
>=20
> No, but how about Thursday?
>=20
> I was hoping to get the inner-class thing resolved before=20
> releasing 1.3, but
> I think I would rather release it as-in and then make changes later.
>=20
> What's wrong with inner-classes, you ask?
> In 1.2 the HTML reports ignored inner-classes, and did not=20
> show them as
> covered/not covered.
> In CVS the HTML reports show coverage for inner-classes, but=20
> they appear in
> a separate HTML page instead of being nestled in with their=20
> parent, like a
> happy baby bird.
> Ideally, the coverage for the classes HelloWorld and=20
> HelloWorld$1 would both
> appear on the same HTML page.
>=20
> In summary, CVS handles this better than 1.2 did, but it's still not
> perfect.  However, if people agree that it's better to release now and
> improve it later, then let's do that.
>=20
> -Mark
>=20
> > -----Original Message-----
> > From: Jeremy Ryan Thomerson [mailto:je...@th...]
> > Sent: Tuesday, May 17, 2005 4:03 PM
> > To: Mark Doliner; Jody Brownell
> > Cc: cob...@li...; Adam Morgan
> > Subject: Re: [Cobertura-devel] How can I get involved....
> >
> > Do we have a proposed release date for 1.3?  It seems like we
> > have some
> > pretty significant changes that are awaiting a release.
> >
> > Jeremy Thomerson
> >
> > ----- Original Message -----
> > From: "Mark Doliner" <Mar...@sa...>
> > To: "Jody Brownell" <jod...@Q1...>
> > Cc: <cob...@li...>; "Adam Morgan"
> > <ada...@Q1...>
> > Sent: Tuesday, May 17, 2005 2:57 PM
> > Subject: RE: [Cobertura-devel] How can I get involved....
> >
> >
> > No, there are no major changes happening in HEAD right now.
> > However, the
> > changes between 1.2 and HEAD are pretty big--I definitely
> > suggest developing
> > against CVS HEAD rather than 1.2.
> > -Mark
> >
> > > -----Original Message-----
> > > From: Jody Brownell [mailto:jod...@Q1...]
> > > Sent: Tuesday, May 17, 2005 3:55 PM
> > > To: Mark Doliner
> > > Cc: cob...@li...; Adam Morgan
> > > Subject: RE: [Cobertura-devel] How can I get involved....
> > >
> > > Agreed... Plan is to make it part of cobertura - assuming you
> > > accept the
> > > patches etc :) I have to get few a number of items at work,
> > > then I will
> > > start.
> > >
> > > I will be in touch shortly.
> > >
> > > BTW - is there anything major happening now on HEAD in cvs?
> > >
> > > -----Original Message-----
> > > From: Mark Doliner [mailto:Mar...@sa...]
> > > Sent: Tuesday, May 17, 2005 4:41 PM
> > > To: Jody Brownell
> > > Cc: cob...@li...; Adam Morgan
> > > Subject: RE: [Cobertura-devel] How can I get involved....
> > >
> > > It sounds like you have a good idea of what you want to do.
> > > I would be
> > > careful to try to keep the data harvesting and the report=20
> generation
> > > reasonably separate from each other.  Why?  Because
> > historical "change
> > > in coverage over time" graphs would be really cool, and I=20
> think it's
> > > something that could be an impressive addition to Cobertura.
> > > If it WAS
> > > made a part of Cobertura, it seems likely that the data
> > > harvesting parts
> > > of your code would need lots of changes, but hopefully the report
> > > generation stuff could remain largely unchanged.
> > >
> > > -Mark
> > >
> > > > -----Original Message-----
> > > > From: Jody Brownell [mailto:jod...@Q1...]
> > > > Sent: Friday, May 13, 2005 6:56 AM
> > > > To: Mark Doliner
> > > > Cc: cob...@li...; Adam Morgan
> > > > Subject: RE: [Cobertura-devel] How can I get involved....
> > > >
> > > > Sure does - thanks.
> > > >
> > > > My first thoughts were - this could be an addon
> > > package/application of
> > > > sorts which can use your .ser file or the XML reports (once
> > > > successfully
> > > > completed). I would prefer to not touch your guys code at all if
> > > > possible and just piggy back on what you have - make
> > enhancements if
> > > > required.
> > > >
> > > > This implies that, the way users run cobertura now would
> > > not change at
> > > > all - providing a single user mode of sorts. Then the new
> > additional
> > > > task (ant?) could be run to export that data to a central or non
> > > > volatile data store. (Data store could be RDBMS, flat file or
> > > > what have
> > > > you - makes no difference to me - as long as simple and fast).
> > > >
> > > > Key things for me are, it needs to be extremely simple to
> > > install and
> > > > maintain. No over complicated configuration etc - keep it as
> > > > it is today
> > > > as much as possible.
> > > >
> > > > Agree about the UI - has to be clean, intuitive, simple=20
> and fast.
> > > >
> > > > - Be nice to view reports on product? / project / package /
> > > > class / ...
> > > > hierarchy - as you navigate through the hierarchy -
> > > > graph/plot for where
> > > > you are
> > > > - plotting lines of code / coverage over time (Jfreechart has
> > > > some great
> > > > plots)
> > > > - Need to identify and ensure we have the right data in the
> > > > datastore. A
> > > > few reports which come to mind are
> > > >   - plain coverage stats
> > > >   - plain coverage stats plotted against lines of code
> > > >   - coverage stats of one project/package/class plotted
> > against the
> > > > baseline coverage of all projects (how does this
> > > project/package/class
> > > > compare to the running average) ( more advanced :))
> > > >
> > > > For now - I will focus on keeping it simple with two
> > additional ant
> > > > tasks, one for exporting/updating to non volatile
> > > datastore, the other
> > > > for generating reports from that data. I will put together a
> > > > more formal
> > > > list of features / requirements over the next few days.
> > > >
> > > > Thoughts?
> > > >
> > > > -----Original Message-----
> > > > From: Mark Doliner [mailto:Mar...@sa...]
> > > > Sent: Tuesday, May 10, 2005 12:03 PM
> > > > To: Jody Brownell
> > > > Cc: cob...@li...
> > > > Subject: RE: [Cobertura-devel] How can I get involved....
> > > >
> > > > *snip*
> > > >
> > > > > Anywho - the purpose of this email is to see how I can get
> > > > > involved. One
> > > > > gap in the product which I noticed (and may already be
> > planned) is
> > > > > coverage statistics over time. I was thinking, unless=20
> this is on
> > > > > someone's plate already I could start to get familiar with
> > > > > the code base
> > > > > and put together a plan of attack - an impact of sorts - and
> > > > > propose to
> > > > > you all.
> > > >
> > > > *snip*
> > > >
> > > > > Please let me know if this is of interest. BTW - what is
> > > the typical
> > > > > process of getting involved? Hope I am not jumping the gun.
> > > >
> > > > You're not jumping the gun at all.  I suppose the typical
> > process of
> > > > getting involved is to find something you're interested in
> > > > fixing/improving/adding and writing a patch for it.  I
> > don't know of
> > > > anyone working on statistics over time.  And it's
> > > definitely something
> > > > that would be nice to have.  You would definitely want to
> > > > work with CVS,
> > > > if you plan on making any changes.  Some of the stuff I
> > > mention below
> > > > applies to CVS but not to the last release.
> > > >
> > > > I guess the easy way to do it would be to name the XML
> > > > reports based on
> > > > the date and time they were created, and then you could parse a
> > > > directory of these files and determine the change over=20
> time.  This
> > > > wouldn't even need to be a part of Cobertura--it could be a
> > > completely
> > > > separate program.  Or maybe instead of reading the data
> > from the XML
> > > > reports, you could read it directly from cobertura.ser files.
> > > >  (The ser
> > > > file contains basically the same information as the XML
> > > reports.  The
> > > > ser file contains serialized classes from the package
> > > > net.sourceforge.cobertura.coveragedata.  If you choose to go
> > > > this route,
> > > > you would need to use these classes to read the=20
> serialized file.)
> > > >
> > > > However, it might be better to modify the classes in the
> > > coveragedata
> > > > package to natively support a time and date.  I'm not
> > sure how this
> > > > would work exactly.  Maybe you could tag the information in
> > > > the ser file
> > > > with a datestamp and then zero it out before running the
> > > next batch of
> > > > tests.
> > > >
> > > > I think it is important that this have a good user interface.
> > > >  How would
> > > > the statistics be displayed?  As a line graph, maybe?
> > How would the
> > > > user tell Cobertura to create these reports?  Would=20
> they specify a
> > > > "start date" and "end date"?  Would the report have a
> > > separate display
> > > > for each package?  For each class?  Would it have a way to show
> > > > differences in the source files?
> > > >
> > > > Does that help you, any?
> > > >
> > > > -Mark
> > > >
> > >
> >
> >
> > -------------------------------------------------------
> > This SF.Net email is sponsored by Oracle Space Sweepstakes
> > Want to be the first software developer in space?
> > Enter now for the Oracle Space Sweepstakes!
> > http://ads.osdn.com/?ad_idt12&alloc_id=16344&op=3Dick
> > _______________________________________________
> > Cobertura-devel mailing list
> > Cob...@li...
> > https://lists.sourceforge.net/lists/listinfo/cobertura-devel
> >
> >
> >
> >
>=20
>=20
> -------------------------------------------------------
> This SF.Net email is sponsored by Oracle Space Sweepstakes
> Want to be the first software developer in space?
> Enter now for the Oracle Space Sweepstakes!
> http://ads.osdn.com/?ad_idt12&alloc_id=16344&op=3Dick
> _______________________________________________
> Cobertura-devel mailing list
> Cob...@li...
> https://lists.sourceforge.net/lists/listinfo/cobertura-devel
>=20
>=20