[ cobertura-Patches-2950088 ] Patch to performance patch (2948696)

[SourceForge.net <no...@so...>]

Patches item #2950088, was opened at 2010-02-11 18:34
Message generated for change (Comment added) made by lewijw
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=720017&aid=2950088&group_id=130558

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
>Status: Closed
>Resolution: Accepted
Priority: 5
Private: No
Submitted By: Piotr Tabor (ptab)
Assigned to: John Lewis (lewijw)
Summary: Patch to performance patch (2948696)

Initial Comment:
There was a concurrency bug in TouchCollector.java file provided in the #2948696 patch. 

I've created the issue as not-logged so I have no permission to add there files. 

----------------------------------------------------------------------

>Comment By: John Lewis (lewijw)
Date: 2010-02-15 11:36

Message:
I have accepted this patch and most of the first one (2948696):

https://sourceforge.net/tracker/index.php?func=detail&aid=2948696&group_id=130558&atid=720017

Very good patch!   One of our tests that used to take 4.5 hours now takes
1.5!

The only code I did not take was the removal of the lock code in LineData
and ProjectData.   I don't have a problem with removing that code in a
future release, but right now, since the code is only executed in the
shutdown hook, and since it is not called nearly as much, it seemed not
worth the risk to remove it now.

Actually, is there any need to even use "syncronized" now for those
classes?   I have not had a chance to look into that yet.

Thank you very much!  

Committed revision 699

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=720017&aid=2950088&group_id=130558