[ cobertura-Patches-2859245 ] Removed oro regex dependency & some collection cleanup

[SourceForge.net <no...@so...>]

Patches item #2859245, was opened at 2009-09-15 05:53
Message generated for change (Comment added) made by thekingant
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=720017&aid=2859245&group_id=130558

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Joachim Hofer (jmhofer)
Assigned to: Nobody/Anonymous (nobody)
Summary: Removed oro regex dependency & some collection cleanup

Initial Comment:
Hi!

While trying to understand the cobertura code, I did a few simple modifications:

I removed the dependency on the Apache ORO matcher in favor of java.util.regex. - Or is there a reason for using ORO instead?
Also, I did some collections cleanup concerning generics for increased type-safety.
Also, I corrected a typo in ClassInstrumenter (regexs vs regexes). - I've now discovered that there's already another patch for that on the tracker.

I hope you find this useful.

----------------------------------------------------------------------

>Comment By: Mark Doliner (thekingant)
Date: 2009-09-15 07:08

Message:
My guess at the reason for using Apache ORO is that java.util.regex wasn't
added until java 1.4, and Cobertura used to be compatible with Java 1.3. 
But I think that compatibility has been dropped, so I think this should be
fine.  But I'm sure the ever-wise John Lewis will take a look at it

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=720017&aid=2859245&group_id=130558