[ cobertura-Patches-1918079 ] Fix for ArrayIndexOutOfBoundsException

[SourceForge.net <no...@so...>]

Patches item #1918079, was opened at 2008-03-18 06:49
Message generated for change (Comment added) made by lewijw
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=720017&aid=1918079&group_id=130558

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
>Status: Closed
>Resolution: Fixed
Priority: 5
Private: No
Submitted By: Nobody/Anonymous (nobody)
>Assigned to: John Lewis (lewijw)
Summary: Fix for ArrayIndexOutOfBoundsException

Initial Comment:
When running cobertura (v 1.9) in our multithreded tests, often an ArrayIndexOutOfBoundsException occurs when starting up our application server (similar to bugs 1838589 and 1913421).

We fixed the LineData class and made 2 methods synchronized (but may be, some of the ClassData and other methods which fill the collections are also in need of synchronization).

----------------------------------------------------------------------

>Comment By: John Lewis (lewijw)
Date: 2009-06-25 06:10

Message:
Thanks for submitting the patch.

This was fixed on June 5th with revision 602. I hope to release 1.9.2
today.

I was concerned with a possible deadlock during merges and equals, so I
ended up using the java concurrent Lock object added with Java 5. I am
aquiring a lock on both objects involved in the merge/equals before
proceeding.


----------------------------------------------------------------------

Comment By: Rick Oosterholt (ricktw)
Date: 2009-03-03 10:55

Message:
Hi, the patch is working; thanks for that!

It might be better though to make the merge function synchronized as well:
public synchronized void merge(CoverageData coverageData)

thanks anyways for this patch!
grtz,
Rick

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=720017&aid=1918079&group_id=130558