Menu
▾
▴
1 Attachments
#27 Standard filebrowser Controller Class - enhance for generic usage
Working on the tinymce4 imageUpload feature I realized it would be nice if the existing file upload classes (in standard file browser) could be enhanced for generic usage. The patchfile says more than word. I extended the upload method with optional parameter and return value. Doesn't harm existing users.
regards manu
I'd rather not enhance the filebrowser Controller for generic usage, primarily because the filebrowser plugin is meant to be replaceable (and as such might not be available). Instead I would prefer to have (an) upload class(es) in the core (i.e. cmsimple/classes), which can be (re-)used by plugins (amongst them the filebrowser).
Ideally, there would be a basic upload model class which can easily be tested (currently we don't have any tests for the filebrowser at all, if I'm not mistaken). IMHO, no full fledged solution is necessary (I'm sure there are several available, though) – it's CMSimple after all. :)
Anyhow, maybe it's best to bring that issue to the CMSimple_XH forum, because it seems to me that our SF trackers are not as frequently watched/visited, unfortunately.
Hmm, what is the status here, manu? There is an Uploader.php in the tinymce4 plugin – does that solve the issue?
Anyhow, I suggest to close this ticket, and open a new one on the Github project page.