Re: [cNFS-Devel] fix io/errors

[Bernd S. <ber...@we...>]

On Monday 03 February 2003 11:16, Michal Ludvig wrote:
> On Wed, 29 Jan 2003, Bernd Schubert wrote:
> > Attached is an improved and cleaned up version of the one I posted la=
st
> > year, so please apply to cvs.
>
> Please reformate it to avoid long lines (especially in comments, but
> preferably no line should be longer than cca 70 chars).
>
> And include a changelog please.
>

O.k., no problem I will do this.

> > Btw, as you can see I had to add some additional lines to
> > nfsd_nfsproc_readdir_2(), as noted in my comments IMHO it would be be=
tter
> > to introduce a subfunction now. What do you think about it ?
>
> Is it a duplicite code or is it there only once? It isn't *that* long,
> anyway, I'd leave it in-place.

O.k.,  I wasn't sure, thatswhy I asked.

>
> But the problem is, that you have introduced this construction:
>
> #ifdef TRANSLATE_NAMES
> {   /* bracket by Bernd, ... */
> #endif
> }   /* end of bracket by Brend. */
>
> Shouldn't the #ifdef/#endif be nested inside the brackets? This way it
> won't even compile if you undefine TRANSLATE_NAMES.

No, the construction is:

#ifdef TRANSLATE_NAMES
{   /* bracket by Bernd, ... */
#endif
res_size =3D 0;
=2E.. /* some other lines needed by both */
#ifdef TRANSLATE_NAMES
}   /* end of bracket by Bernd. */
#else
#endif

So it DOES compile if TRANSLATE_NAMES is undefined.


Anyway I will reformat it this evening end send a new patch.


Best regards,
=09Bernd