Re: [cNFS-Devel] fix io/errors

[Michal L. <mic...@lo...>]

On Wed, 29 Jan 2003, Bernd Schubert wrote:

> Attached is an improved and cleaned up version of the one I posted last year, 
> so please apply to cvs.

Please reformate it to avoid long lines (especially in comments, but 
preferably no line should be longer than cca 70 chars).

And include a changelog please.

> Btw, as you can see I had to add some additional lines to 
> nfsd_nfsproc_readdir_2(), as noted in my comments IMHO it would be better to 
> introduce a subfunction now. What do you think about it ?

Is it a duplicite code or is it there only once? It isn't *that* long, 
anyway, I'd leave it in-place.

But the problem is, that you have introduced this construction:

#ifdef TRANSLATE_NAMES
{   /* bracket by Bernd, ... */
#endif
}   /* end of bracket by Brend. */

Shouldn't the #ifdef/#endif be nested inside the brackets? This way it 
won't even compile if you undefine TRANSLATE_NAMES.

Michal Ludvig