Re: [ClusterNFS-Devel] bugs in my previous patch and other diff format

[Michal L. <mi...@lo...>]

On Tue, 5 Mar 2002, Bernd Schubert wrote:

> Oh yes, actually I only sent this patches, to have you a look on it and tell 
> me if you like my style of programming, but since you applied it to cvs, I 
> also think its better to remove these lines :-)

I have no problem with your coding style. Perhaps one thing: there is no 
need to write funct((struct->item), something)
Enough is: funct(struct->item, something)
Also I prefer to put one space after each comma in argument list like: 
(arg1, arg2) instead of (arg1,arg2). 

> Probably during the weekend I'll make use from the testlines below and write 
> a patch that prevents the input/output errors (by removing this files for the 
> client all) that currently occurs when a file with the  CREATE tag and a 
> servers file exists but not a client specific file.
> But I'm not sure if all users will like it -- could possibly a new tag be 
> necessary?

Since current status commits an IO errors (I noticed them also) I don't 
see a reason why not to bring a solution. I vote against another tag. 
Possibly you can add a compile-time option for this via #ifdef ... #endif 
so that anybody could switch it off if they don't like it.

Michal Ludvig