clusternfs-devel — ClusterNFS Development List

Re: [ClusterNFS-Devel] bugs in my previous patch and other diff format

[Michal L. <mi...@lo...>]

On Tue, 5 Mar 2002, Bernd Schubert wrote:

> here's another patch, my previous one had several bugs (mountd didn't compile 
> and another very critical one, introduced by me in tr2_getfarray).

Thanks for your patches. I've committed them into cnfsd's CVS on 
sourceforge, but haven't time to verify yet. If someone can do it, 
please pull out the sources from CVS as written on 
http://sourceforge.net/cvs/?group_id=5768 and tell us the results.

Brend, please use -bB switch to diff as well (or don't change whitespaces :-)

Michal Ludvig

[ClusterNFS-Devel] bugs in my previous patch and other diff format

[Bernd S. <ber...@we...>]

Hi,

here's another patch, my previous one had several bugs (mountd didn't compile 
and another very critical one, introduced by me in tr2_getfarray).


Best regards,

Bernd

[ClusterNFS-Devel] RE: improvements to the create tag

[Warnes, G. R <gre...@gr...>]

I think you meant to send this to <clusternfs-devel>.

-Greg

> -----Original Message-----
> From: Bernd Schubert [mailto:ber...@we...]
> Sent: Monday, March 04, 2002 7:03 PM
> To: clu...@li...
> Cc: Warnes, Gregory R
> Subject: improvements to the create tag
> 
> 
> Hi Greg and all the others,
> 
> several weeks ago I complained that even when the CREATE tag 
> is set, the 
> servers files are overwritten from the clients. For example 
> when a file with 
> filename, another with filename$$CREATE=IP$$ exist, but no file with 
> filename$$any_other_tag$$. 
> 
> So here's a small and still incomplete patch (I don't know 
> how to use the 
> diff command to create patch compatible formats -- I'll 
> lookup that tomorrow, 
> or can give someone of a hint to me?).
> 
> Actually, this patch only works properly together with 
> "$$IP=...$$" and 
> "$$CREATE=IP$$" tags but adding the other tags will not be 
> difficult (but its 
> late in the night here and I want to go to bed now).
> 
> Furthermore, you'll get input/output errors when doing for 
> example a ls and a 
> file with "$$CREATE=$$" exists but no file with the same 
> filename and the tag 
> "$$IP=..". But nevertheless the servers files shoulnd't be 
> overwritten any 
> longer.
> I think to prevent the input/output errors the servers 
> filename has to be 
> removed from the filelist when a file with 
> filename$$CREATE=..$$ exists. I 
> think this has to be done in nfsd.c:1121. Unfortunality 
> another loop is 
> necessary to scan files, that have the CREATE tag and then 
> delete this files 
> from the current while loop at nfsd.c:1121. Or has anyone 
> another idea?
> 
> 
> I'm only posting this incomlete patch, to ask if you agree 
> with my code (I'm 
> a C novice and want to make sure that I havn't done any mistakes).
> 
> 
> Thanks in advance for you patience,
> 
> Bernd
> 
> PS: Thanks again Greg for your hint about running it within 
> the debugger, it 
> worked fine.
> 


LEGAL NOTICE
Unless expressly stated otherwise, this message is confidential and may be privileged. It is intended for the addressee(s) only. Access to this E-mail by anyone else is unauthorized. If you are not an addressee, any disclosure or copying of the contents of this E-mail or any action taken (or not taken) in reliance on it is unauthorized and may be unlawful. If you are not an addressee, please inform the sender immediately.

[ClusterNFS-Devel] improvements to the create tag

[Bernd S. <ber...@we...>]

Hi Greg and all the others,

several weeks ago I complained that even when the CREATE tag is set, the 
servers files are overwritten from the clients. For example when a file with 
filename, another with filename$$CREATE=IP$$ exist, but no file with 
filename$$any_other_tag$$. 

So here's a small and still incomplete patch (I don't know how to use the 
diff command to create patch compatible formats -- I'll lookup that tomorrow, 
or can give someone of a hint to me?).

Actually, this patch only works properly together with "$$IP=...$$" and 
"$$CREATE=IP$$" tags but adding the other tags will not be difficult (but its 
late in the night here and I want to go to bed now).

Furthermore, you'll get input/output errors when doing for example a ls and a 
file with "$$CREATE=$$" exists but no file with the same filename and the tag 
"$$IP=..". But nevertheless the servers files shoulnd't be overwritten any 
longer.
I think to prevent the input/output errors the servers filename has to be 
removed from the filelist when a file with filename$$CREATE=..$$ exists. I 
think this has to be done in nfsd.c:1121. Unfortunality another loop is 
necessary to scan files, that have the CREATE tag and then delete this files 
from the current while loop at nfsd.c:1121. Or has anyone another idea?


I'm only posting this incomlete patch, to ask if you agree with my code (I'm 
a C novice and want to make sure that I havn't done any mistakes).


Thanks in advance for you patience,

Bernd

PS: Thanks again Greg for your hint about running it within the debugger, it 
worked fine.

[ClusterNFS-Devel] RE: using debugger for rpc.nfsd ??

[Warnes, G. R <gre...@gr...>]

Hi Bernd,

I'm not sure from your description exactly what you are trying to do.

Nevertheless, to use the debugger you need to tell rpc.nfsd not to fork into
the background when started.  The parameter "-F" or "--foreground" serves
this purpose.

Also, I've just created a ClusterNFS-Devel mailing list at sourcefore.
Please sign up at
http://lists.sourceforge.net/mailman/listinfo/clusternfs-devel. 

-Greg


> -----Original Message-----
> From: Bernd Schubert [mailto:ber...@we...]
> Sent: Friday, March 01, 2002 3:10 PM
> To: Warnes, Gregory R
> Subject: using debugger for rpc.nfsd ??
> 
> 
> Hi Greg,
> 
> my initial idea to make the clients see files with $$servr$$ 
> when a file with 
> a create flag exists, unfortunality doesn't work.
> So I'm trying to do it in another way, but using a debugger 
> would help very 
> much, but every time when I try it, the debugger process 
> finishes and another 
> rpc.nfsd process outside the debugger opens. This is very annoying. 
> 
> Is there a way to let rpc.nfsd running within a debugger, so 
> that I can run 
> trough every line of the sourcecode?
> 
> Thanks in advance,
> 
> Bernd
> 


LEGAL NOTICE
Unless expressly stated otherwise, this message is confidential and may be privileged. It is intended for the addressee(s) only. Access to this E-mail by anyone else is unauthorized. If you are not an addressee, any disclosure or copying of the contents of this E-mail or any action taken (or not taken) in reliance on it is unauthorized and may be unlawful. If you are not an addressee, please inform the sender immediately.