|
From: Ben v. K. <s40...@st...> - 2003-10-21 06:16:11
|
Hi All, Still haven't got CVS access... so here's some more changes. I followed on from Rob's work and found a few more instances of using delete where delete[] should have been used. I've replaced the stringDuplicate function with a function that allocates memory using new[] then doing a stringCopy. So I think there shouldn't be any code that uses malloc anymore. However i ran a quick comparison check using the tests program, comparing the old code that uses malloc against the new code that uses new[]. The old codes seems to be the slightest big faster. Does anyone know about if if there's any performance issues of malloc vs new[]? I also looked through all the places where "delete " was being used and found a few arrays that needed to be changed to "delete[]". Hopefully that gets them all, but Rob if you could check with valgrind when you get time. Also Rob, if you have time could you look at the tests program. I know there's some terrible test code in there (almost no resources are freed ;~} but when i run the tests in cygwin i get a segfault during the === Test Query Parser === test. I've posted 0.8.3 on sourceforge. Sorry about CVS, does anyone have any ideas how to get through a firewall onto sourceforge (no socks server either)? cheers, ben |