Re: [CLucene-dev] SpanQueryFilter.cpp - assignment of bDeleteQuerytoitself

[Šplíchal J. <spl...@to...>]

I pushed the bug fix into the memory_leaks branch.

Itamar, do you plan to merge this branch with master?

Jiri

 

From: Šplíchal Jiří [mailto:spl...@to...] 
Sent: Thursday, October 21, 2010 12:41 PM
To: clu...@li...
Subject: Re: [CLucene-dev] SpanQueryFilter.cpp - assignment of bDeleteQuerytoitself

 

Hello, 

 

yes this is definitely a bug, thank you. I will correct it.

 

Jiri

 

 

From: Rustem Alimov [mailto:ar...@gm...] 
Sent: Thursday, October 21, 2010 12:14 PM
To: clu...@li...
Subject: [CLucene-dev] SpanQueryFilter.cpp - assignment of bDeleteQuery toitself

 

Hi,

src/core/CLucene/search/SpanQueryFilter.cpp : line 24

<code>
SpanQueryFilter::SpanQueryFilter( CL_NS2(search,spans)::SpanQuery * query, bool bDeleteQuery )
{
    this->query = query;
    bDeleteQuery = bDeleteQuery;
}
</code>

bDeleteQuery = bDeleteQuery;
Hmmm... this->bDeleteQuery = bDeleteQuery; ?

Bad style for variable names